In the past I have used 'blkdiscard -f' to wipe my nvme drives but opinions on that seem to vary. I have seen recommendations to avoid the 'nvme sanitize' command altogether. I am considering simply deleting the old namespace and then formatting the drive with a new namespace. I know that 512 byte lba is supported by my drives and that makes it easy to know that I need to use 'ashift=12' when creating my zfs pool.
# nvme delete-ns /dev/nvme?n?
# nvme format -b 512 -n 1 /dev/nvme?
UPDATE:
The 'blkdiscard -f /dev/nvme?n?' command works just fine for simply wiping an NVMe drive.
According to the docs 'nvme format -f /dev/nvme?n?' will set the drive to defaults and clear the namespace.
ty
]]>