Thank you everyone! Hopefully I'll get around to submitting it later this evening.
]]> install -d "${pkgdir}/usr/bin"
ln -s "/usr/lib/${_pkgname}/${_pkgname}" "${pkgdir}/usr/bin/"
Is that better? I've read "install" is preferred over mkdir and cp, but not sure if it applies in this case.
]]> ln -s "/usr/lib/${_pkgname}/${_pkgname}" "${pkgdir}/usr/bin"
Creates /usr/bin where bin is a symlink to /usr/lib/photoview/photoview
]]>For the most part, though, just download a tarball once you get back on the releases.
]]>Upstream provides git tags; the source array could be replaced with
source=( "git+${url}.git#tag=v${pkgver}" ...
You'd be surprised how often upstreams change tags. You need to use the hash of the commit or the hash of the tag so you know when they do.
]]>loqs, I traced the prompt back to the call to "npm install" which is used for building the ui. I replaced it with "npm install --yes" and it no longer prompts. I apologize I missed this originally, I knew I was supposed to bypass all prompts, but with so many fixes that I found from reading the wiki pages for "Creating packages" and "Arch package guidelines", it slipped through the cracks. Also, I had 512sums for the included files and was iterating so often on them it was getting annoying to update those sums every time I wanted to test the pkgbuild in the chroot, that I removed them for the time being, during this early development phase. I've added them back now.
One question I had is about the "WorkingDirectory=". Ideally, should it be "/var/lib/photoview" as opposed to the current setting of "/usr/lib/photoview"? Currently the upstream code requires the "data/" (static models the program needs, that I placed in "/usr/lib/photoview") be in the current working directory. I can develop a pull request to configure the location of the data/ directory, but that will take some time. Reason I ask is because if the program does end up generating files in the current working directory (besides the cache which I've already configured), I would think they should 'just end up' in the "/var/lib/phtooview". Thoughts?
Also, I've committed the change for the prompt removal and shasums to the repo listed above.
]]>source=(
"git+${url}.git#tag=v${pkgver}"
...
source=(
"git+${url}.git#commit=${_commit}"
"${pkgname}.service"
"${pkgname}.env.patch"
)
sha512sums=(
'SKIP'
'SKIP'
'SKIP'
)
Please provide checksums for the none git entries.
go build -v -o photoview .
Please see https://wiki.archlinux.org/title/Go_package_guidelines]Go_package_guidelines
Need to install the following packages:
husky
Ok to proceed? (y)
PKGBUILDs should not prompt. Is there a way to stop this?
]]>I tried to run make "makerepropkg" on the pkg file, but it fails since there is a dependency from the aur? Is there a way to point to a built version on my local machine, like the -I option for "makechrootpkg".
Anyway, any input is appreciated. The current state is on github:
https://github.com/feinedsquirrel/aur_photoview
Thanks!
edit: Should I have placed this is in "Creating & Modifying Packages"?
edit 2: I'm pretty sure it should be in "Creating & Modifying Packages". Is there a way to move this, or do I just delete this and create this over there?
]]>