You are not logged in.

#1 2016-01-20 11:09:42

loh.tar
Member
Registered: 2010-10-17
Posts: 10

tbsm - Terminal Based Session Manager

Hello!

After I run in trouble with my Plasma 5 migration, I install LXQt as workaround and start it not by an usual display manager (makes trouble too) but by startx method from terminal.

That was nicely but not comfier, so I a came across CDM and tdm. Because I didn't like the ncurses interface a start to modify CDM and endet up in something else, tbsm.

So if someone like to try it, here you are.

Lothar

PS: Because it is my very first AUR package it would be nice some Guru may take a look at it.

Offline

#2 2016-01-20 16:56:58

sekret
Member
Registered: 2013-07-22
Posts: 205

Re: tbsm - Terminal Based Session Manager

loh.tar wrote:

Because it is my very first AUR package it would be nice some Guru may take a look at it.

I have suggestions:

With your PKGBUILD and its source line

source=("https://github.com/loh-tar/${pkgname}/archive/v${pkgver}.tar.gz")

you can run into trouble if you have SRCDEST defined in /etc/makepkg.conf (to collect all sources in one directory, which I have, that's why I noticed). The reason is, that the filename v0.1.tar.gz is too common, e.g. if another package does the same, makepkg finds its source file and of course fails the md5sum check. That's why I'd suggest something like this:

source=("$pkgname-$pkgver.tar.gz::https://github.com/loh-tar/$pkgname/archive/v$pkgver.tar.gz")

See, I also changed ${pkgname} and ${pkgver} to $pkgname and $pkgver, especially because the {} aren't required here and in the rest of the PKGBUILD you don't use the {}. Makes the code more consistent smile

Ok so after the build process I ran namcap on it and that's what I get:

$ namcap tbsm-0.1-1-any.pkg.tar.xz
tbsm E: Symlink (usr/share/doc/tbsm/99_License.txt) points to non-existing /usr/share/licenses/common/GPL2/license.txt

Seems like we don't need this 99_License.txt, not even as a symlink, because you chose a common license.

Or do you want to change the Makefile? I think this is up to you wink

Last edited by sekret (2016-01-20 16:57:31)

Offline

#3 2016-01-21 00:39:22

loh.tar
Member
Registered: 2010-10-17
Posts: 10

Re: tbsm - Terminal Based Session Manager

Hey, thanks for your help!

Huh, yes, I forgot to run namcap. But now I am pretty confused.
  - The license file exist, why does he report "non-existing"?
  - What is the 'right' way to handle license files?

From my point of view it is part of the documentation, so I ship it there. Then says the wiki it should only go to /usr/share/licenses/pkgname if its not common. If it is common a note in the PKGBUILD is enough. And then don't install the license, nowhere? I found it not as logic and make this linking stuff. Which works, until namcap.

I was also a little bit surprised that the tar file has such a short name. Is it a config thing at github, the wrong tag used or your solution absolutely usual?

Well the braces. Needed or not. But you are right, it should be consistent.

Offline

#4 2016-01-21 00:43:53

Trilby
Forum Moderator
From: Massachusetts, USA
Registered: 2011-11-29
Posts: 14,190
Website

Re: tbsm - Terminal Based Session Manager

loh.tar wrote:

  - The license file exist, why does he report "non-existing"?
  - What is the 'right' way to handle license files?

The file does not exist within the package.  It may exist on your system, but it is not in ${pkgdir}.

As for the proper way, see here.


InterrobangSlider
• How's my coding? See this page.
• How's my moderating? Feel free to email any concerns, complaints, or objections.

Offline

#5 2016-01-21 16:56:01

loh.tar
Member
Registered: 2010-10-17
Posts: 10

Re: tbsm - Terminal Based Session Manager

Ok, regarding the "non-existing" link the fog clears up, thanks.

But about the file handling not, sorry. I do not understand the meaning of that all in the wiki. So why should there be collected all (not included, or these specials) licenses?

It seems to me, as author, ignore it at all and me as packer set 'GPL' in license array and forget it.

It would be nice there is a convention that somewhere are collected license files and each author/packer can reference them to avoid redundance. The FHS would be a place to achieve this or perhaps freedesktop.org but I can't find something there.

Offline

Board footer

Powered by FluxBB