You are not logged in.

#26 2021-11-06 16:37:33

hossbeast
Member
From: Seattle
Registered: 2017-06-26
Posts: 24

Re: new PKGBUILD review - meshboard

willemw wrote:

Removing 'glibc'.

namcap complains if I do this.

todd@euclid ~/meshboard-headless-aur
0 master % g diff
diff --git a/PKGBUILD b/PKGBUILD
index acd9c18..ebf5bfe 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,7 +1,7 @@
# Maintainer: hossbeast <todd DOT freed AT gmail DOT com>

pkgname=meshboard-headless
-pkgver=v0.5.1
+pkgver=0.5.1
pkgrel=1
pkgdesc="Synchronize the clipboard across a mesh of hosts, without display server support"
provides=('meshboard')
@@ -9,10 +9,10 @@ conflicts=('meshboard' 'meshboard-wayland' 'meshboard-xorg')
arch=('x86_64')
url="https://github.com/hossbeast/meshboard"
license=('GPL3')
-depends=('glibc')
+#depends=('glibc')
makedepends=('git' 'perl')
source=(
-  "meshboard::git+https://github.com/hossbeast/meshboard#tag=${pkgver}?signed"
+  "meshboard::git+https://github.com/hossbeast/meshboard#tag=v${pkgver}?signed"
)
sha512sums=('SKIP')
validpgpkeys=('79154EE9C4811D32B814EB88B1B3C76D76638462') # hossbeast

todd@euclid ~/meshboard-headless-aur
0 master % namcap meshboard-headless-0.5.1-1-x86_64.pkg.tar.zst
meshboard-headless E: Dependency glibc detected and not included (libraries ['usr/lib/libpthread.so.0', 'usr/lib/librt.so.1', 'usr/lib/libc.so.6'] needed in files ['usr/bin/meshboard'])

With the other package variants, glibc is covered by either the wayland or x11 lib dependency. But in this case, glibc is an immediate library dependency.

willemw wrote:

Changing conflicts to 'conflicts=('meshboard') in the meshboard-* packages.

Fixed this also. It seems just having "conflicts=('meshboard')" and "provides=('meshboard')" in each of the meshboard-* packages is sufficient to make all 4 packages exclusive of the other 3.

Offline

#27 2021-11-06 16:46:55

willemw
Member
Registered: 2013-02-19
Posts: 113

Re: new PKGBUILD review - meshboard

'glibc' is in the core repository. It is such a fundamental package, it is safe not to list it in PKGBUILD.

Last edited by willemw (2021-11-06 17:50:16)

Offline

#28 2021-11-06 17:06:36

loqs
Member
Registered: 2014-03-06
Posts: 17,469

Re: new PKGBUILD review - meshboard

It is not against any guideline to have glibc in depends when it does depend on it though.

Offline

#29 2021-11-06 18:48:23

hossbeast
Member
From: Seattle
Registered: 2017-06-26
Posts: 24

Re: new PKGBUILD review - meshboard

I went ahead and pushed these PKGBUILDS. Thanks willemw and others for your review!

Offline

Board footer

Powered by FluxBB