You are not logged in.

#651 2012-02-15 11:12:15

portix
Member
Registered: 2009-01-13
Posts: 757

Re: dwb - a webkit web browser

Ok, this seems right, this also works here with revision 1041. I don't know why it doesn't work with your setup.

Offline

#652 2012-02-16 14:20:07

c00kiemon5ter
Member
From: Greece
Registered: 2010-06-01
Posts: 562
Website

Re: dwb - a webkit web browser

new segfault with todays build. here's the backtrace.

Starting program: /usr/bin/dwb 
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/libthread_db.so.1".
[New Thread 0x7fffeb3c0700 (LWP 28917)]
[New Thread 0x7fffaabbd700 (LWP 28918)]
[New Thread 0x7fffa9dea700 (LWP 28945)]
[Thread 0x7fffa9dea700 (LWP 28945) exited]
[New Thread 0x7fffa9197700 (LWP 28952)]
[New Thread 0x7fffa8996700 (LWP 28953)]
[Thread 0x7fffa9197700 (LWP 28952) exited]
[Thread 0x7fffa8996700 (LWP 28953) exited]
[New Thread 0x7fffa8996700 (LWP 29009)]
[New Thread 0x7fffa9197700 (LWP 29019)]
[New Thread 0x7fff9a3f7700 (LWP 29020)]
[Thread 0x7fffa8996700 (LWP 29009) exited]
[Thread 0x7fff9a3f7700 (LWP 29020) exited]
[New Thread 0x7fff9a3f7700 (LWP 29145)]
[Thread 0x7fff9a3f7700 (LWP 29145) exited]
[Thread 0x7fffa9197700 (LWP 29019) exited]
[New Thread 0x7fffa9197700 (LWP 29291)]
[New Thread 0x7fff9a3f7700 (LWP 29292)]
[Thread 0x7fffa9197700 (LWP 29291) exited]
[Thread 0x7fff9a3f7700 (LWP 29292) exited]
[New Thread 0x7fff9a3f7700 (LWP 29414)]
[New Thread 0x7fffa9197700 (LWP 29415)]
[Thread 0x7fff9a3f7700 (LWP 29414) exited]
[Thread 0x7fffa9197700 (LWP 29415) exited]
[New Thread 0x7fffa9197700 (LWP 29521)]
[Thread 0x7fffa9197700 (LWP 29521) exited]
[New Thread 0x7fffa9197700 (LWP 30322)]
[New Thread 0x7fff9a3f7700 (LWP 30323)]
[Thread 0x7fffa9197700 (LWP 30322) exited]
[Thread 0x7fff9a3f7700 (LWP 30323) exited]
[New Thread 0x7fff9a3f7700 (LWP 30650)]
[New Thread 0x7fffa9197700 (LWP 30651)]
[New Thread 0x7fffa8996700 (LWP 30677)]
[New Thread 0x7fff8b477700 (LWP 30758)]
[New Thread 0x7fff887fa700 (LWP 30803)]
[New Thread 0x7fff86ce6700 (LWP 30806)]
[New Thread 0x7fff864e5700 (LWP 30807)]
[New Thread 0x7fff85ce4700 (LWP 30810)]
[New Thread 0x7fff853af700 (LWP 30828)]
[New Thread 0x7fff84bae700 (LWP 30833)]
[Thread 0x7fff85ce4700 (LWP 30810) exited]
[Thread 0x7fff853af700 (LWP 30828) exited]
[Thread 0x7fff84bae700 (LWP 30833) exited]
[New Thread 0x7fff84bae700 (LWP 18367)]
[Thread 0x7fff84bae700 (LWP 18367) exited]

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff3932110 in WTF::Unicode::convertUTF16ToUTF8(unsigned short const**, unsigned short const*, char**, char*, bool) () from /usr/lib/libjavascriptcoregtk-1.0.so.0
#0  0x00007ffff3932110 in WTF::Unicode::convertUTF16ToUTF8(unsigned short const**, unsigned short const*, char**, char*, bool) () from /usr/lib/libjavascriptcoregtk-1.0.so.0
#1  0x00007ffff392e496 in WTF::String::utf8(bool) const () from /usr/lib/libjavascriptcoregtk-1.0.so.0
#2  0x00007ffff693d1d4 in ?? () from /usr/lib/libwebkitgtk-1.0.so.0
#3  0x00007ffff69cbfcd in webkit_dom_html_input_element_get_value () from /usr/lib/libwebkitgtk-1.0.so.0
#4  0x000000000041d011 in html_key_changed (target=0x8f9880) at html.c:278
#5  0x000000000041d71c in html_keydown_cb (ev=<optimized out>, el=<optimized out>, wv=<optimized out>) at html.c:208
#6  html_keydown_cb (el=<optimized out>, ev=<optimized out>, wv=<optimized out>) at html.c:201
#7  0x00007ffff693e065 in ?? () from /usr/lib/libwebkitgtk-1.0.so.0
#8  0x00007ffff6bd58dc in ?? () from /usr/lib/libwebkitgtk-1.0.so.0
#9  0x00007ffff6bd59f1 in ?? () from /usr/lib/libwebkitgtk-1.0.so.0
#10 0x00007ffff6c13ff9 in ?? () from /usr/lib/libwebkitgtk-1.0.so.0
#11 0x00007ffff6bd05e5 in ?? () from /usr/lib/libwebkitgtk-1.0.so.0
#12 0x00007ffff6bcf106 in ?? () from /usr/lib/libwebkitgtk-1.0.so.0
#13 0x00007ffff6bcfe9f in ?? () from /usr/lib/libwebkitgtk-1.0.so.0
#14 0x00007ffff6bdfdc3 in ?? () from /usr/lib/libwebkitgtk-1.0.so.0
#15 0x00007ffff6bd5590 in ?? () from /usr/lib/libwebkitgtk-1.0.so.0
#16 0x00007ffff6eb7e79 in ?? () from /usr/lib/libwebkitgtk-1.0.so.0
#17 0x00007ffff6975060 in ?? () from /usr/lib/libwebkitgtk-1.0.so.0
#18 0x00007ffff60190f8 in ?? () from /usr/lib/libgtk-x11-2.0.so.0
#19 0x00007ffff420003a in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#20 0x00007ffff4211e9f in ?? () from /usr/lib/libgobject-2.0.so.0
#21 0x00007ffff421b4c3 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#22 0x00007ffff421b892 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#23 0x00007ffff6132171 in ?? () from /usr/lib/libgtk-x11-2.0.so.0
#24 0x00007ffff6146cdb in gtk_window_propagate_key_event () from /usr/lib/libgtk-x11-2.0.so.0
#25 0x00007ffff61496cb in ?? () from /usr/lib/libgtk-x11-2.0.so.0
#26 0x00007ffff60190f8 in ?? () from /usr/lib/libgtk-x11-2.0.so.0
#27 0x00007ffff42000e4 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#28 0x00007ffff4211e9f in ?? () from /usr/lib/libgobject-2.0.so.0
#29 0x00007ffff421b4c3 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#30 0x00007ffff421b892 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#31 0x00007ffff6132171 in ?? () from /usr/lib/libgtk-x11-2.0.so.0
#32 0x00007ffff6017357 in gtk_propagate_event () from /usr/lib/libgtk-x11-2.0.so.0
#33 0x00007ffff60175e3 in gtk_main_do_event () from /usr/lib/libgtk-x11-2.0.so.0
#34 0x00007ffff5a2384c in ?? () from /usr/lib/libgdk-x11-2.0.so.0
#35 0x00007ffff34518bd in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
#36 0x00007ffff34520b8 in ?? () from /usr/lib/libglib-2.0.so.0
#37 0x00007ffff34525f2 in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
#38 0x00007ffff6016637 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
#39 0x000000000040ce2f in main (argc=1, argv=0x7fffffffe1f8) at dwb.c:3717
A debugging session is active.

	Inferior 1 [process 28899] will be killed.

Quit anyway? (y or n) 

and a link:  http://sprunge.us/MRfT

Last edited by c00kiemon5ter (2012-02-16 14:20:47)


.:[ git me! ] :.

Offline

#653 2012-02-16 14:30:15

portix
Member
Registered: 2009-01-13
Posts: 757

Re: dwb - a webkit web browser

Thanks, this seems to be a bug in webkit but i will try to reproduce it. Btw: the bugtracker is a better place for bugs.

Offline

#654 2012-02-19 10:45:14

Prezioso
Member
Registered: 2011-01-17
Posts: 83

Re: dwb - a webkit web browser

Hi, I keep seeing this bug on many pages, is there something I can do about it ?

tY3U3Zw

Offline

#655 2012-02-19 23:50:12

portix
Member
Registered: 2009-01-13
Posts: 757

Re: dwb - a webkit web browser

Prezioso wrote:

Hi, I keep seeing this bug on many pages, is there something I can do about it ?

http://omploader.org/tY3U3Zw

I haven't seen this yet, do you have webkit-1.6.3 from the repos installed? Btw: your dwb seems a bit outdated but this should not be the reason for this bug.

Offline

#656 2012-02-20 03:25:13

whooper
Member
From: Germany
Registered: 2008-12-24
Posts: 37

Re: dwb - a webkit web browser

Hi,

Is it possible to implement a setting to change the default white color of the settings/bookmarks page of dwb?

Offline

#657 2012-02-20 09:37:57

portix
Member
Registered: 2009-01-13
Posts: 757

Re: dwb - a webkit web browser

You can user a user-stylesheet:

 
#dwb_main_container, .dwb_table_row {
    background-color: <your color>!important;
}

There is no id for the body but it will get an id with the next commit. The stylesheet for settings is defined in /usr/share/dwb/lib/head.html, you can also modify it there but this gets overwritten when you update dwb.

Edit: dwb now first looks for files in ~/.local/share/dwb/lib, so you can copy /usr/share/dwb/lib/head.html to ~/.local/share/dwb/lib/head.html and modify it there.

Last edited by portix (2012-02-20 10:24:33)

Offline

#658 2012-02-20 16:50:11

Prezioso
Member
Registered: 2011-01-17
Posts: 83

Re: dwb - a webkit web browser

portix wrote:
Prezioso wrote:

Hi, I keep seeing this bug on many pages, is there something I can do about it ?

http://omploader.org/tY3U3Zw

I haven't seen this yet, do you have webkit-1.6.3 from the repos installed? Btw: your dwb seems a bit outdated but this should not be the reason for this bug.

Yes, webkit-1.6.3.1 installed and just updatet dwb.  Still the same error.  hmm

Offline

#659 2012-02-23 05:39:25

intermaggio
Member
Registered: 2012-02-23
Posts: 1

Re: dwb - a webkit web browser

Hey all- I'm entirely new to Archlinux, with a good friend showing me the ropes. I'm currently browsing using dwb and have installed the ttf-ms-webfonts pack, but I'm currently only seeing one font, as in the screenshot. Any ideas how to fix this? http://omploader.org/vY3YyaQ

Offline

#660 2012-02-23 05:59:24

djp
Member
Registered: 2012-02-11
Posts: 12

Re: dwb - a webkit web browser

intermaggio wrote:

Hey all- I'm entirely new to Archlinux, with a good friend showing me the ropes. I'm currently browsing using dwb and have installed the ttf-ms-webfonts pack, but I'm currently only seeing one font, as in the screenshot. Any ideas how to fix this? http://omploader.org/vY3YyaQ

Try the packages mentioned at https://wiki.archlinux.org/index.php/MS_Fonts.  You'll need to pull the fonts from a legit copy of windows for it to work (and you may need to modify the hashes in the pkgbuild to match your local files)

Also, unless an issue is specific to dwb, it should probably go in a separate thread so others can more easily find the solution as well.

Offline

#661 2012-02-23 08:39:13

portix
Member
Registered: 2009-01-13
Posts: 757

Re: dwb - a webkit web browser

You could also install ttf-freefont.

Offline

#662 2012-02-23 10:08:27

Gusar
Member
Registered: 2009-08-25
Posts: 3,605

Re: dwb - a webkit web browser

portix wrote:

You could also install ttf-freefont.

I'd recommend ttf-liberation instead. Liberation was made to have the same metrics as the ms corefonts.

Offline

#663 2012-02-25 03:41:50

stryder
Member
Registered: 2009-02-28
Posts: 500

Re: dwb - a webkit web browser

Is it possible to use lastpass with dwb?

Offline

#664 2012-02-27 10:51:23

bloom
Member
Registered: 2010-08-18
Posts: 749
Website

Re: dwb - a webkit web browser

I can't log in to bitbucket anymore (I get "CSRF verification failed. Request aborted.").

So, I'm reporting here:

It would be nice to save the session when receiving SIGSEGV.

I experienced a crash (flash related it seems) and when I restarted dwb, the restored tabs were ancient.

Wouldn't it be possible to save the session before each tab creation/deletion?

Backtrace of the aforementioned crash:

 51: dwb() [0x40c9d0]
 50: dwb() [0x41935d]
 49: /lib/libpthread.so.0(+0xf270) [0x7fca9f4c6270]
 48: /usr/lib/mozilla/plugins/libflashplayer.so(+0x353010) [0x7fca44ed3010]
 47: /usr/lib/mozilla/plugins/libflashplayer.so(+0x46dc10) [0x7fca44fedc10]
 46: /usr/lib/mozilla/plugins/libflashplayer.so(+0x1aea6e) [0x7fca44d2ea6e]
 45: /usr/lib/libwebkitgtk-1.0.so.0(+0xa90447) [0x7fcaa326a447]
 44: /usr/lib/libwebkitgtk-1.0.so.0(+0xa9062a) [0x7fcaa326a62a]
 43: /usr/lib/libwebkitgtk-1.0.so.0(+0x960b52) [0x7fcaa313ab52]
 42: /usr/lib/libwebkitgtk-1.0.so.0(+0x960920) [0x7fcaa313a920]
 41: /usr/lib/libwebkitgtk-1.0.so.0(+0x920652) [0x7fcaa30fa652]
 40: /usr/lib/libwebkitgtk-1.0.so.0(+0x92098a) [0x7fcaa30fa98a]
 39: /usr/lib/libwebkitgtk-1.0.so.0(+0x92ba72) [0x7fcaa3105a72]
 38: /usr/lib/libwebkitgtk-1.0.so.0(+0x9339f1) [0x7fcaa310d9f1]
 37: /usr/lib/libwebkitgtk-1.0.so.0(+0x933b2d) [0x7fcaa310db2d]
 36: /usr/lib/libwebkitgtk-1.0.so.0(+0x956e68) [0x7fcaa3130e68]
 35: /usr/lib/libwebkitgtk-1.0.so.0(+0x959906) [0x7fcaa3133906]
 34: /usr/lib/libwebkitgtk-1.0.so.0(+0x43bd2c) [0x7fcaa2c15d2c]
 33: /usr/lib/libwebkitgtk-1.0.so.0(+0x95b0f0) [0x7fcaa31350f0]
 32: /usr/lib/libwebkitgtk-1.0.so.0(+0x934031) [0x7fcaa310e031]
 31: /usr/lib/libwebkitgtk-1.0.so.0(+0x935080) [0x7fcaa310f080]
 30: /usr/lib/libwebkitgtk-1.0.so.0(+0x936767) [0x7fcaa3110767]
 29: /usr/lib/libwebkitgtk-1.0.so.0(+0x937142) [0x7fcaa3111142]
 28: /usr/lib/libwebkitgtk-1.0.so.0(+0x9375d3) [0x7fcaa31115d3]
 27: /usr/lib/libwebkitgtk-1.0.so.0(+0x938504) [0x7fcaa3112504]
 26: /usr/lib/libwebkitgtk-1.0.so.0(+0x7d54b4) [0x7fcaa2faf4b4]
 25: /usr/lib/libwebkitgtk-1.0.so.0(+0x7d5d15) [0x7fcaa2fafd15]
 24: /usr/lib/libwebkitgtk-1.0.so.0(+0x6be5b4) [0x7fcaa2e985b4]
 23: /usr/lib/libwebkitgtk-1.0.so.0(+0x6ca64e) [0x7fcaa2ea464e]
 22: /usr/lib/libwebkitgtk-1.0.so.0(+0x6bde9f) [0x7fcaa2e97e9f]
 21: /usr/lib/libwebkitgtk-1.0.so.0(+0x6d2075) [0x7fcaa2eac075]
 20: /usr/lib/libwebkitgtk-1.0.so.0(+0x9a68ba) [0x7fcaa31808ba]
 19: /usr/lib/libwebkitgtk-1.0.so.0(+0x9a73d7) [0x7fcaa31813d7]
 18: /usr/lib/libwebkitgtk-1.0.so.0(+0x462540) [0x7fcaa2c3c540]
 17: /usr/lib/libgtk-x11-2.0.so.0(+0x1360f8) [0x7fcaa22e10f8]
 16: /usr/lib/libgobject-2.0.so.0(g_closure_invoke+0x154) [0x7fcaa04c60e4]
 15: /usr/lib/libgobject-2.0.so.0(+0x20e9f) [0x7fcaa04d7e9f]
 14: /usr/lib/libgobject-2.0.so.0(g_signal_emit_valist+0x623) [0x7fcaa04e14c3]
 13: /usr/lib/libgobject-2.0.so.0(g_signal_emit+0x82) [0x7fcaa04e1892]
 12: /usr/lib/libgtk-x11-2.0.so.0(+0x24f171) [0x7fcaa23fa171]
 11: /usr/lib/libgtk-x11-2.0.so.0(gtk_propagate_event+0xc3) [0x7fcaa22df283]
 10: /usr/lib/libgtk-x11-2.0.so.0(gtk_main_do_event+0x283) [0x7fcaa22df5e3]
  9: /usr/lib/libgdk-x11-2.0.so.0(+0x5c84c) [0x7fcaa1ceb84c]
  8: /usr/lib/libglib-2.0.so.0(g_main_context_dispatch+0x1dd) [0x7fca9f7178bd]
  7: /usr/lib/libglib-2.0.so.0(+0x450b8) [0x7fca9f7180b8]
  6: /usr/lib/libglib-2.0.so.0(g_main_loop_run+0x162) [0x7fca9f7185f2]
  5: /usr/lib/libgtk-x11-2.0.so.0(gtk_main+0xa7) [0x7fcaa22de637]
  4: /usr/lib/libgio-2.0.so.0(g_application_run+0x19e) [0x7fcaa079c94e]
  3: dwb() [0x4130b8]
  2: /lib/libc.so.6(__libc_start_main+0xed) [0x7fca9f13938d]
  1: dwb() [0x40ca99]

gh · da · ds

Offline

#665 2012-02-28 19:13:09

Onyros
Member
From: Lisbon, Portugal
Registered: 2007-10-11
Posts: 307

Re: dwb - a webkit web browser

Hi there, just started using dwb and I already prefer it over jumanji. Great work, portix smile

Is there any way to use middle-click to close tabs instead of right-click? I read some pages before that you were thinking about implementing configurable mouse buttons, that would be awesome.

Also, is there a way to make new tabs open always at the rightmost, instead of opening after the active window?

Finally, I can't seem to set "Control+Tab" to cycle between tabs, I tried using Control S-Tab and a few other combinations but none worked, is there a solution for this?

Thanks in advance!

Last edited by Onyros (2012-02-28 19:18:25)

Offline

#666 2012-02-28 19:43:12

Gusar
Member
Registered: 2009-08-25
Posts: 3,605

Re: dwb - a webkit web browser

Onyros wrote:

Is there any way to use middle-click to close tabs instead of right-click?

Yeah, it's a simple source modification:

diff -r ee07c16e00f4 src/view.c
--- a/src/view.c	Wed Jan 11 17:08:41 2012 +0100
+++ b/src/view.c	Wed Jan 11 17:43:35 2012 +0100
@@ -646,7 +646,7 @@
     dwb_focus_view(gl);
     return true;
   }
-  else if (e->button == 3 && e->type == GDK_BUTTON_PRESS) {
+  else if (e->button == 2 && e->type == GDK_BUTTON_PRESS) {
     view_remove(gl);
     return true;
   }
Onyros wrote:

Also, is there a way to make new tabs open always at the rightmost, instead of opening after the active window?

I have a hack for that too, no idea if it's actually correct or just works by chance (I'm not much of a coder):

diff -r ee07c16e00f4 src/view.c
--- a/src/view.c	Wed Jan 11 17:08:41 2012 +0100
+++ b/src/view.c	Wed Jan 11 17:45:34 2012 +0100
@@ -819,8 +819,8 @@
     return;
   }
   if (gl == dwb.state.fview) {
-    if ( !(dwb.state.fview = dwb.state.fview->prev) ) {
-      dwb.state.fview = g_list_first(dwb.state.views)->next;
+    if ( !(dwb.state.fview = dwb.state.fview->next) ) {
+      dwb.state.fview = g_list_last(dwb.state.views)->prev;
       if (dwb.state.bar_visible & BAR_VIS_TOP) 
         gtk_widget_show_all(dwb.gui.topbox);
     }
@@ -914,11 +914,11 @@
   View *v = view_create_web_view();
   gtk_box_pack_end(GTK_BOX(dwb.gui.topbox), v->tabevent, true, true, 0);
   if (dwb.state.fview) {
-    int p = g_list_position(dwb.state.views, dwb.state.fview) + 1;
+    int p = g_list_length(dwb.state.views);
     gtk_box_reorder_child(GTK_BOX(dwb.gui.topbox), v->tabevent, g_list_length(dwb.state.views) - p);
     gtk_box_insert(GTK_BOX(dwb.gui.mainbox), v->scroll, true, true, 0, p);
     dwb.state.views = g_list_insert(dwb.state.views, v, p);
-    ret = dwb.state.fview->next;
+    ret = g_list_last(dwb.state.views);
 
     if (background) {
       view_set_normal_style(ret);

The first chunk changes tab closing behavior (switch to the right instead of to the left), the second chuck makes tabs open at the end of the tabbar.

Offline

#667 2012-02-28 20:17:33

Onyros
Member
From: Lisbon, Portugal
Registered: 2007-10-11
Posts: 307

Re: dwb - a webkit web browser

Gusar, first of all, thank you very much! Free beer on me if we ever meet wink

First patch worked perfectly, the second one game me an error

view.c:957:6: error: too few arguments to function ‘gtk_box_insert’

I'm not a coder, by any means and C is pretty alien to me tongue

BTW: using dwm-hg, which you may have concluded from the line 957 instead of line 91x wink

Last edited by Onyros (2012-02-28 20:23:57)

Offline

#668 2012-02-28 20:32:30

portix
Member
Registered: 2009-01-13
Posts: 757

Re: dwb - a webkit web browser

Onyros wrote:

Hi there, just started using dwb and I already prefer it over jumanji. Great work, portix smile
Is there any way to use middle-click to close tabs instead of right-click? I read some pages before that you were thinking about implementing configurable mouse buttons, that would be awesome.

I thought about implementing configurable mouse buttons but i'm still not sure if they will ever come because i rarely use mousebuttons and the focus is to be keyboard-friendly.

Onyros wrote:

Also, is there a way to make new tabs open always at the rightmost, instead of opening after the active window?

This is on my todo-list and will definitely be implemented but currently it is not possible.

Onyros wrote:

Finally, I can't seem to set "Control+Tab" to cycle between tabs, I tried using Control S-Tab and a few other combinations but none worked, is there a solution for this?

Keys without output or with whitespace output have to be encapsulated with @. So you can bind focus_next to Control @Tab@. If you want to bind Control Shift Tab it has to be Control Shift @ISO_Left_Tab@.

Offline

#669 2012-02-28 20:44:22

Gusar
Member
Registered: 2009-08-25
Posts: 3,605

Re: dwb - a webkit web browser

Onyros wrote:

BTW: using dwm-hg, which you may have concluded from the line 957 instead of line 91x wink

I'm using dwb-hg too. And while the patch is old, hg updates always merged fine, so I thought the patch is still good. It is actually, you must have done something wrong applying it. Try this one, it's updated for the latest hg:

--- a/src/view.c	Mon Feb 27 14:34:06 2012 +0100
+++ b/src/view.c	Tue Feb 28 21:41:52 2012 +0100
@@ -859,8 +859,8 @@
     return;
   }
   if (gl == dwb.state.fview) {
-    if ( !(dwb.state.fview = dwb.state.fview->prev) ) {
-      dwb.state.fview = g_list_first(dwb.state.views)->next;
+    if ( !(dwb.state.fview = dwb.state.fview->next) ) {
+      dwb.state.fview = g_list_last(dwb.state.views)->prev;
       if (dwb.state.bar_visible & BAR_VIS_TOP) 
         gtk_widget_show_all(dwb.gui.topbox);
     }
@@ -952,11 +952,11 @@
   View *v = view_create_web_view();
   gtk_box_pack_end(GTK_BOX(dwb.gui.topbox), v->tabevent, true, true, 0);
   if (dwb.state.fview) {
-    int p = g_list_position(dwb.state.views, dwb.state.fview) + 1;
+    int p = g_list_length(dwb.state.views);
     gtk_box_reorder_child(GTK_BOX(dwb.gui.topbox), v->tabevent, g_list_length(dwb.state.views) - p);
     gtk_box_insert(GTK_BOX(dwb.gui.mainbox), v->scroll, true, true, 0, p, GTK_PACK_START);
     dwb.state.views = g_list_insert(dwb.state.views, v, p);
-    ret = dwb.state.fview->next;
+    ret = g_list_last(dwb.state.views);
 
     if (background) {
       view_set_normal_style(ret);

Offline

#670 2012-02-28 21:22:17

Onyros
Member
From: Lisbon, Portugal
Registered: 2007-10-11
Posts: 307

Re: dwb - a webkit web browser

Gusar, thank you for the updated diff, it did the trick! I applied it by hand before, must've done something wrong there. It works perfectly now.

portix, thank you, too, once again! Configurable mouse buttons isn't much of a priority for me, too. Apart from the middle-click to close tab, which Gusar so promptly helped me with. Also, Control @Tab@ did it, as well as Control @Right@ and Control @Left@ (which I use for forward and back).

If any of you ever drop by Lisbon one of these days, guaranteed free beers for the night.

Offline

#671 2012-02-29 00:35:37

portix
Member
Registered: 2009-01-13
Posts: 757

Re: dwb - a webkit web browser

Onyros wrote:

Also, is there a way to make new tabs open always at the rightmost, instead of opening after the active window?

There is now a new setting in the hg-version called "new-tab-position-policy".

Offline

#672 2012-02-29 01:18:07

Onyros
Member
From: Lisbon, Portugal
Registered: 2007-10-11
Posts: 307

Re: dwb - a webkit web browser

portix, you're incredible. Really, I hadn't seen such a responsive dev in a long while.

It's much appreciated and dwb is absolutely fantastic.

Offline

#673 2012-02-29 06:36:55

bananagranola
Member
From: US
Registered: 2011-08-07
Posts: 88
Website

Re: dwb - a webkit web browser

I just started using dwb after trying jumanji, uzbl, and vimprobable, and I personally like dwb the most. Imagine my glee at discovering such an active forum thread. I haven't had any problems yet.

One question: is there a way to "search" bookmarks that I haven't managed to find in the documentation? As it stands, I have about 40 bookmarks, and cyling through them with Tab and Shift-Tab can take awhile. Am I missing something silly?

Thanks for a great browser!

Offline

#674 2012-02-29 08:44:18

portix
Member
Registered: 2009-01-13
Posts: 757

Re: dwb - a webkit web browser

I have already started to implement an update-as-you-type completion but it is not already done. For now after pressing o or O you can type a search string and then press Control-Shift-b, that will only complete bookmarks that match the already typed string.

Offline

#675 2012-02-29 09:36:26

jakob
Member
From: Berlin
Registered: 2005-10-27
Posts: 419

Re: dwb - a webkit web browser

Onyros wrote:

Finally, I can't seem to set "Control+Tab" to cycle between tabs, I tried using Control S-Tab and a few other combinations but none worked, is there a solution for this?

Hello Onyros,

just to be sure, you know about the bindings gT and gt, right?

portix wrote:

I have already started to implement an update-as-you-type completion but it is not already done. For now after pressing o or O you can type a search string and then press Control-Shift-b, that will only complete bookmarks that match the already typed string.

Hasn’t complete-bookmarks been availabe for a long time already? After pressing o, typing in a string is there any difference between pressing »Tab« and »Control-Shift-b«?

Thanks again for that great browser!

Offline

Board footer

Powered by FluxBB