You are not logged in.
Alt + Left / Right does not work for me in qtfm, but I get the idea, thanks
Offline
Hey Witfella, I did some testing, and noticed that:
1) 1ms on singleShot is enough not to show any reordering (maybe if it's set to 0 it acts as a simple function call? If that's the case consider adding 1ms on each singleShot call)
QTimer::singleShot(1,this,SLOT(treeSelectionChangedLate()));
*****
2) Not sure what this part of code is for (force-scroll somewhere in details view?) but it causes segfault I was talking about before (check the video). Commenting it out fixes the segfaults.
void MainWindow::treeSelectionChangedLate()
{
...
//if(backIndex.parent() == baseIndex)
// if(detailAct->isChecked()) detailTree->scrollTo(backIndex,QAbstractItemView::EnsureVisible);
//else list->scrollTo(backIndex,QAbstractItemView::EnsureVisible);
}
*****
3) I think I figured out the delete bug. I guess if a folder has any write-protected stuff inside, after we try to delete the folder all the stuff inside will be deleted but the folder itself won't (and maybe few empty folders inside). But strangely we must enter the folder first to trigger this bug. So, for example, do this:
svn co https://cloudcity.svn.sourceforge.net/svnroot/cloudcity
Then enter this folder, then go back one folder up and try to delete it. All files are deleted except the folder itself and few empty hidden folders inside. Try to delete it again - you get unable to delete some items error.
*****
4) Merge folders happens without confirmation. User should be asked if he wants to merge the folder with existing one (and then confirm if he wants to replace any conflicting files in the merge)? This is because one may "pollute" a folder by accident with a large number of folders and/or files, even though there's no possibility of overwrite.
*****
5) One other thing I noticed is that hidden folders get stuck after hovering (a bug from while back) only on some QT styles. For example, they get stuck on Cleanlooks, but not on GTK. On QTcurve sometimes they get stuck sometimes they don't? Wittfella, what style do you use and did you notice this bug on your QT style when I mentioned this bug a while ago?
*****
6) Direct link on www.qtfm.org website to download 4.1 doesn't work ;)
*****
Okay, that was a lot of editing ;) Wittfella, please confirm that you got all 6 of these entries because I added few over time ;)
Last edited by karabaja4 (2011-01-07 00:24:04)
Offline
Needs a GTK port
Offline
@thoffmeyer - Don't expect it. Wittfella already said no to someone who asked before.
Offline
@thoffmeyer - Don't expect it. Wittfella already said no to someone who asked before.
Oh I didn't ask, I just said that it needs one . I could make it, but don't feel like it.
Offline
I'm using a tiling wm (awesome) and I noticed that qtfm takes a few seconds to redraw whenever I close/open a new program. Is there anyway to speed that up?
Offline
karabaja4 - I fixed 1 & 2 in 4.1, are you sure you have the latest. I'm not sure what happened to the link on the page, it was working before. I fixed it now, can you try it again. I changed to singleshot back to 10ms. I also fixed that bug with the 'back' action which was causing the segfault you describe.
I'll have a look into the delete problem.
With the merging, I don't see how this is not expected behaviour. If you copy a folder to a place where that folder already exists, what do you want to happen? Before it would just delete the existing folder, and everything in it which I think could be quite unexpected/dangerous.
I use cleanlooks style and yes I see the hidden file remain if you hover but I have no idea why that happens. Interesting that it doesn't happen with other styles, I didn't know that.
anonymous_user - On every machine I try, even my slowest netbook qtfm is almost instant startup, certainly not 'several seconds'. I don't use tiling window manager, not sure if that is a factor, I doubt it.
The only other thing I can think of that could slow it down at startup is if it has to load a large thumb cache immediately. That would only happen if you are in 'icon' mode, and you have images in your home directory. Do you mainly use icon mode. Try switching to 'list' or 'detail' and then open/close, does it make a difference.
Offline
Im not talking about startup speed. I mean the time for qtfm to refresh the UI when its resized.
Offline
Oh ok, maybe that is window manager related, not sure. Do other Qt programs act the same. There is nothing specific in qtfm relating to the redraw, that is a system issue.
Offline
There is nothing specific in qtfm relating to the redraw, that is a system issue.
Oh well.
Offline
Wittfella - yes, I have the latest v4.1 - I think the 2) issue wasn't just with the back button. Just in case I downloaded 4.1 just now and recompiled: the issue 2) remains, try to reproduce it the way it is displayed in the video (extract, one down folder, one up folder, delete, repeat). If you comment the code
//if(backIndex.parent() == baseIndex)
// if(detailAct->isChecked()) detailTree->scrollTo(backIndex,QAbstractItemView::EnsureVisible);
//else list->scrollTo(backIndex,QAbstractItemView::EnsureVisible);
it doesn't happen anymore.
As for 1), I know you switched it back to 10ms and there's no more reordering. My point was that you can have it at 1ms instead of 10ms for the same effect.
As for merging - as I said, maybe I don't want the folders to merge - maybe I don't know that the folder with the same name is already there. If that is the case I just polluted the destination folder without knowing it's original content. I was just suggesting some kind of confirmation before merging happens (before it would ask confirmation before replacing the folder, right?).
Last edited by karabaja4 (2011-01-07 07:23:50)
Offline
@bug - Are you sure its not responding, you might just have to leave it a bit longer. Sometimes it takes a while to get the properties, especially on a large directory, like /usr or the whole drive. If you do 'Properties' in the bookmark list with no selection, it defaults to the current folder ie. what is in the address bar at the time.
'Delete' deletes stuff :) That is intended. I hate it when I get asked to confirm every delete. It you want a bit more safety you can use a custom action to make a 'Trash' option and assign it to the delete key if you want.
The 'Edit filetype' was in the context menu a long time ago if I recall, but it turns out to be a waste because you use it a lot initially but then once you have your default apps set you hardly ever use it again, so it just takes up needless space. You can also set a keyboard shortcut for quicker access.
1) Yes, it seems you are correct, it just stalled for a long time feeling like it's getting stuck. Maybe you can do something so the interface wouldn't lock up when calculating.
Also, why does it say the number of files negatively, i.e. "-741 files".
2) I would really prefer an option for getting asked, I care less for the trash part. It's just that I have a light finger on the delete key for an unknown reason. Not sure how to get rid of such habit :).
Still, I would appreciate it if you tell me how to set up that 'Trash' option 'till you might implant that tick-box in the options.
3) I guess that is reasonable. But an 'Open-With' option would still be nice. Sometimes my default program which I prefer fails to open a file. At which I would respond with an alternate which isn't as good as the original, but sometimes does manage to open such files.
4) As you already have an extract here for 'gz'. It would be nice if you add such an option by default to other archive types as well. [So nobody would have to rewrite that. Because `everyone` needs it].
Offline
1) Yes, it seems you are correct, it just stalled for a long time feeling like it's getting stuck. Maybe you can do something so the interface wouldn't lock up when calculating.
Also, why does it say the number of files negatively, i.e. "-741 files".
I can confirm that number of files sometimes goes negative.
2) I would really prefer an option for getting asked, I care less for the trash part. It's just that I have a light finger on the delete key for an unknown reason. Not sure how to get rid of such habit .
Still, I would appreciate it if you tell me how to set up that 'Trash' option 'till you might implant that tick-box in the options.
You can setup a custom action 'mv %f ~/.trash' to trash the files. I too prefer no confirmation on delete. If you really want confirmation you could implement that with zenity & rm.
3) I guess that is reasonable. But an 'Open-With' option would still be nice. Sometimes my default program which I prefer fails to open a file. At which I would respond with an alternate which isn't as good as the original, but sometimes does manage to open such files.
You could setup custom actions 'Open with this', 'Open with that' etc. and choose what program to open with.
Now this gives me an idea. Wittfella - you could make submenus inside custom actions (something like obmenu application) to group actions together, for example 'edit with' -> 'gimp', 'kolourpaint' etc. and have up/down buttons to move custom actions in the list which would be cleaner than dragging them around. BTW, even without submenus, up/down buttons seem cleaner solution than dragging custom actions to change the order. Also, when you add new custom action (click on '+'), the list doesn't scroll to (and select?) the last one, so you don't see it actually get added. So we need to either add it as the first in the list or force-scroll to the last one.
4) As you already have an extract here for 'gz'. It would be nice if you add such an option by default to other archive types as well. [So nobody would have to rewrite that. Because `everyone` needs it].
I think those default custom actions are intended just as an example. You can easily add additional actions yourself.
Last edited by karabaja4 (2011-01-07 09:01:27)
Offline
One more thing, we could transfer 'Run' action on default custom action ('/bin/bash %f' or whatever) since is redundant with custom actions available. Same goes for Delete (use rm), but I guess delete action is something most file managers have by default so maybe it's not such a good idea. Anyway, just my thoughts.
Offline
Fixed some of the stuff above.
4.2 10-January-2011
- modified custom actions dialog to highlight/scroll to newly added item.
- modified folder properties, now threaded operation.
- added 'merge' conformation for copy/paste on existing folders.
- fixed bug when deleting nested hidden folders.
Offline
Thanks!
Bug: scroll down to last custom action and select it. Then add a new one, the new one gets selected. Click delete, the previous one is deleted instead of the new selected (empty) one. Also, try adding then immediately deleting new custom action - it doesn't get deleted, it just scrolls up.
A little bug/tip: when asking "do you want to merge folders" instead of "no" you should write "replace the folder", because I just interpreted "no" as "don't do anything".
Here's few more ideas for you to think about:
1) We could eliminate xdg-open completely by defining open commands inside dialog similar to custom actions. For example, for file type ".bmp" we define "gimp %f", that would define our filetype to open with gimp. One more advantage of this we could pass additional arguments for programs to execute for certain file type. This seems much more simple/logical/powerful than using xdg-open which is a mess anyway.
2) You could add additional menu next to File, Edit, View called "Global" and in custom actions have additonal filetype called "GLOBAL" or whatever, where we could define custom actions that would go into that menu. This would enable us to have actions that are not tied to specific file (such as mount/unmount etc.)
3) We could make path completion exactly as the one in bash shell prompt using tab key (at the moment tab switches between window parts), so when a user clicks tab qtfm would complete the path, add a / at the end if path exists and de-select the whole string, so user can keep on typing. In other words, exactly as bash completion. Also, to make things more pretty, you could paint the textbox light-red if a user requested (mashed enter) a non-existing path, then make it white again when a user keeps on typing.
***
EDIT: also, if it's not a problem Wittfella, could you explain in short this code:
if(backIndex.parent() == baseIndex)
if(detailAct->isChecked()) detailTree->scrollTo(backIndex,QAbstractItemView::EnsureVisible);
else list->scrollTo(backIndex,QAbstractItemView::EnsureVisible);
and why does segfault still sometime appear when going in and back into extracted folder?
Thanks!
Last edited by karabaja4 (2011-01-10 21:17:12)
Offline
Thanks for such a good app!
We could eliminate xdg-open completely by defining open commands inside dialog similar to custom actions. For example, for file type ".bmp" we define "gimp %f", that would define our filetype to open with gimp. One more advantage of this we could pass additional arguments for programs to execute for certain file type. This seems much more simple/logical/powerful than using xdg-open which is a mess anyway.
Oh! Opening files depend on it extension is such bad idea. I think so. I don't want to make software open files based on opt-s that can be easily changed.
Anyway you can in xdg-open also path additional arguments for programs...
Last edited by m0nhawk (2011-01-10 16:44:01)
Offline
Offline
make path completion exactly as the one in bash shell prompt using tab key
I played with this, I couldn't make the address box receive the tab key, it always goes to the parent to cycle windows. If it completes to the thing you want you can hit right arrow to move to the end and deselect so you can keep typing. It doesn't add the trailing / though, maybe I can try to do that automatically.
I changed the up/back code a little bit again because you said it was still happening, but I cannot reproduce the segfault.
That bit of code makes it scroll to the previous folder (the folder you were just in) if you go 'back' to the parent folder. Useful if you are in a folder with a lot of subfolders which you have to scroll, you go into a subfolder, and then go back, you are still at the same place in the parent, without having to scroll again to find were you were. Different from going 'up' which will take you back to the start of parent directory.
Offline
Some nice changes and a few little bug fixes.
4.3 13-January-2011
- added two new '$folder' types to custom actions. Allows custom actions on specific folders. See README.
- added support for specific folder theme icons. eg. Documents, Movies, Downloads, Trash etc.
- added option to enable confirmation on all delete operations.
- modified 'merge/replace' dialog for folders, more intuitive.
Most significantly:
It should now automatically use your theme icons for those common folders like 'Documents, Movies, Downloads' etc. Also works in bookmarks. If you don't think they are working properly, check your theme 'places' folder. There doesn't seem to be a coherent standard with the naming, the themes I checked use different names which is a pain. eg. Oxygen has 'folder-video' while gnome has 'folder-videos', same with 'Download' vs 'Downloads', stuff like that...I tried to catch all the common ones.
You will have to reset the theme icons in qtfm to take effect, just delete the '.config/qtfm/file.cache' file.
EDIT: I've been testing a bunch of themes and maybe this is not so great. The basic themes in our repository work great, gnome, oxygen, human etc. Most other themes I try are hit and miss. They don't have these icons, or there are too many different names. Normally if it doesn't find the icon it just defaults back to the standard folder icon of the theme, ok, no real loss. But if the theme inherits from something else, say gnome, it will cascade down until it finds the particular icon in the gnome theme. So then you have a mish-mash of icons, different colours etc., looks crappy!
EDIT 2: It was annoying me so I pulled the folder icon stuff. You can still change the bookmark icons manually like before though.
The new custom action types allows you to set custom actions for specific folders. So instead of using 'folder' to match every folder you just use the actual folder name of the one you want to match. An obvious example is 'Trash'. You can create an 'Empty trash' action, set the filetype to 'Trash' (or whatever your folder name is) and the 'Empty trash' action will only appear on that folder.
The other one is a slight variation, use the full path to a parent folder. This means 'match all folders below this one'. This would be useful for mount/unmount actions. This way you can have an unmount action appear only on things in '/media' for example, and not every folder.
Also added the 'delete confirmation' option if you like that.
Cheers,
Wittfella
Last edited by Wittfella (2011-01-14 01:29:39)
Offline
bug wrote:4) As you already have an extract here for 'gz'. It would be nice if you add such an option by default to other archive types as well. [So nobody would have to rewrite that. Because `everyone` needs it].
I think those default custom actions are intended just as an example. You can easily add additional actions yourself.
Maybe, but it would save a lot of hassle for many people to do so.
I mean, those extract commands are generic, so most people who are not lazy would add 'em anyway. Why not save the hassle for 'em?
Offline
The included example has 'gz,bz2'. What other ones are you thinking of? I'm only including ones that can be handled by the 'tar xf' command, because as you say, everybody has that already. I'm not including 'rar, 7z, zip' and the like because not everyone has them installed.
Offline
I will be pushing the latest version as soon as I can get in contact with Loui to change my SSH key. Apologies if it will be a little late, I have both of the packages built, I simply cannot submit them yet.
Offline
Hey Brad, no problem, I was hoping you hadn't pushed them yet, because I changed it this morning anyway
Offline
The included example has 'gz,bz2'. What other ones are you thinking of? I'm only including ones that can be handled by the 'tar xf' command, because as you say, everybody has that already. I'm not including 'rar, 7z, zip' and the like because not everyone has them installed.
Well... Unless it's configured in in 4.3 then I can only see gz on my system.
Either way, because it's based on extention it should have tgz, tbz, txz along with the gz, bz2 & xz.
I'm not 100% sure about the xz. I know it comes by default in Arch, but I am not sure what is the case in other operating systems.
Nor I have ANY idea if you can unzip by default or not [Though I'm pretty sure you should be able to].
Offline