You are not logged in.
I was wondering if this patch is still needed. I vaguely remember that one of the previous xserver versions removed that "ugly pattern" which I will call 'gray background' (it's a fine checkerboard).
The pattern itself
./dix/window.c
static unsigned char _back_lsb[4] = {0x88, 0x22, 0x44, 0x11};
static unsigned char _back_msb[4] = {0x11, 0x44, 0x22, 0x88};is still present in the source code, but there might have been some changes that e.g. relegated it to non-default settings.
Even xorg-server-1.5.1 has a switch that makes the background black, not gray:
-br
sets the default root window to solid black instead of the standard root weave
pattern.
xorg-server-1.7.1 adds '-retro' switch:
-retro
starts the stipple with the classic stipple and cursor visible. The default
is to start with a black root window, and to suppress display of the cursor
until the first time an application calls XDefineCursor(). For the Xorg
server, this also sets the default for the DontZap option to FALSE. For
kdrive servers, this implies -zap.
The current (1.10) xserver:
-br
sets the default root window to solid black instead of the standard root weave
pattern. This is the default unless -retro or -wr is specified.
(emphasis mine)
I've compiled the current xserver w/o the patch and I still got black background by default. Unlike the patched one, I could use the '-retro' switch and get the gray background. In the patched server (i.e. the Arch stock one), '-retro' switch doesn't do anything - the background remains black.
There's also another switch:
-wr
sets the default root window to solid white instead of the standard root weave
pattern.
which works in both the patched and unpatched server.
I understand why this bug got closed, but maybe somebody could check if I'm right.
It's simple: recompile xorg-server based on this diff:
[karol@black test]$ LC_ALL=C TZ=GMT0 diff -Naur a/xorg-server/PKGBUILD b/xorg-server/PKGBUILD
--- a/xorg-server/PKGBUILD 2011-07-29 10:46:03.000000000 +0000
+++ b/xorg-server/PKGBUILD 2011-07-29 10:47:30.000000000 +0000
@@ -14,7 +14,7 @@
#git-fixes.patch
bg-none-revert.patch
xserver-1.10-pointer-barriers.patch
- xorg-redhat-die-ugly-pattern-die-die-die.patch
+ #xorg-redhat-die-ugly-pattern-die-die-die.patch
autoconfig-nvidia.patch
xvfb-run
xvfb-run.1
@@ -23,7 +23,7 @@
# '6dd2bcd9d8b17d1a50ed8c15eb1cba480558e695'
'629c6d8d52126eab81ee1b72a9e4209535f8cb81'
'1b95e91384a57d966428c7db98ed06f4cc562f91'
- '0efcdf61bde3c0cd813072b94e2b30ab922775b9'
+ #'0efcdf61bde3c0cd813072b94e2b30ab922775b9'
'f9328fd7bc931bb02c8909ecfcef35403de33782'
'c94f742d3f9cabf958ae58e4015d9dd185aabedc'
'6838fc00ef4618c924a77e0fb03c05346080908a'
@@ -32,7 +32,7 @@
build() {
cd "${srcdir}/${pkgbase}-${pkgver}"
# Get rid of the ugly pattern
- patch -Np3 -i "${srcdir}/xorg-redhat-die-ugly-pattern-die-die-die.patch"
+ #patch -Np3 -i "${srcdir}/xorg-redhat-die-ugly-pattern-die-die-die.patch"
# Add pointer barrier support, patch from Fedora
patch -Np1 -i "${srcdir}/xserver-1.10-pointer-barriers.patch"and adjust one file
[karol@black test]$ cat /etc/X11/xinit/xserverrc
#exec /usr/bin/X -nolisten tcp "$@"
exec /usr/bin/X -nolisten tcp -retro "$@"- assuming you're using the regular 'startx'.
You can even boot w/o any .xinitrc. With the default settings (the first line in '/etc/X11/xinit/xserverrc') you should see black background, and with '-retro' switch a gray one.
I'd rather not open bug report just yet - if I'm wrong, if I missed something, it would surely piss-off the devs and I pretend I'm a good boy, so I don't want to do this.
Last edited by karol (2011-08-09 11:47:35)
Offline
The ugly pattern is dead indeed and the patch has been removed from the trunk.
Offline