[solved] comment in PKGBUILD

nTia89 · 2011-08-22 08:14:06

hi to all

i'm trying to edit a PKGBUILD (amule-adnza-svn)
so i've added some comment but this breaks the build
http://pastebin.com/uENBbNui

where i make error/s ?

thanks

Last edited by nTia89 (2011-08-22 10:27:09)

steabert · 2011-08-22 08:21:11

It helps if you tell people:
-> what exactly you changed/added
-> what exactly goes wrong (error messages)?

probably, it's because you left uncommented empty lines

nTia89 · 2011-08-22 08:31:32

yes, i get this:

....
....
....
....
config.status: creating po/POTFILES
config.status: creating po/Makefile
config.status: executing denoiser commands


  Configure script has finished system check.

  Configured aMule 2.2.6 (AdunanzA mod) for 'x86_64-unknown-linux-gnu'.

  aMule enabled options:

  **** aMule Core ****
  Prefix where aMule should be installed?                    /usr
  Should aMule be compiled with i18n support?                yes
  Should aMule be compiled in debug mode?                    yes
  Should aMule be compiled with profiling?                   no
  Should aMule be compiled with optimizations?               no
  Should aMule be compiled with UPnP support?                no
  Should aMule be compiled with IP2country support?          no
  Should aMule monolithic application be built?              yes
  Should aMule daemon version be built?                      no
  Should aMule remote gui be built? (EXPERIMENTAL)           no
  Crypto++ library/headers style?                            installed

  **** aMule TextClient ****
  Should aMule Command Line Client be built?                 no

  **** aMule WebServer ****
  Should aMule WebServer be built?                           no

  **** aMule ED2K Links Handler ****
  Should aMule ED2K Links Handler be built?                  yes

  **** aMuleLinkCreator ****
  Should aMuleLinkCreator GUI version (alc) be built?        no
  Should aMuleLinkCreator for console (alcc) be built?       no

  **** aMule Statistics ****
  Should C aMule Statistics (CAS) be built?                  no
  Should aMule GUI Statistics (wxCas) be built?              no

  **** General Libraries and Tools ****
  Should ccache support be enabled?                          no
  Libraries aMule will use to build:
                                       wxWidgets             2.8.12 (gtk2,shared)
                                       crypto++              5.6.1 (installed, in /usr)
                                       libintl               system
                                       zlib                  1.2.5
/home/mattia/Desktop/amule-adnza-svn/PKGBUILD: line 66: --disable-debug: command not found
==> ERRORE: Si è verificato un errore in build().
    L'operazione sta per essere interrotta...

seeing to output, the compiler misunderstand the option coming after the commented line....
because removing commented lines everything works fine, the problem is just the commented part !

tomk · 2011-08-22 08:46:27

Put the comments just before 'make'.

Allan · 2011-08-22 09:02:17

    --disable-debug \
    --enable-optimize

are being treated as new commands. Move them up to the main configure line.

nTia89 · 2011-08-22 09:59:47

ok, but this isn't the solution !

if

stand for comment line, the interpreter should skip TOTALLY these lines .....

but this doesn't happen......

why ?
perhaps

doesn't stand for comment ?

Allan · 2011-08-22 10:06:36

I does not even get to the first comment... You have a blank line after "--disable-upnp \" which is the end of the command.

falconindy · 2011-08-22 10:09:18

No, that is the solution. The comment is ignored and the command ends. Consider it a feature of Bash's parser. Still not happy? Report it to upstream.

If you want to insist on inline comments in the middle of a command, work around it with an array:

configureopts=(
  --prefix=/usr
  --optfoo

  # enable bar for more bar
  # --enable-bar

  # disable baz if you don't want baz
  # --disable-baz

  --enablemoreopts
)

./configure "${configureopts[@]}"

nTia89 · 2011-08-22 10:22:06

@ Allan:
ok, then i replace empty lines with commented empty lines
but this doesn't work.... so blank lines aren't the problem
-----

reading what falconindy says, this is a "strange" bash feature ...... so because i can't do anything, i can bypass it by using an array
i'll try it

EDIT: yay, this works. thanks very much falconindy. a question i can substitute array with a variable ?

Last edited by nTia89 (2011-08-22 10:26:58)

falconindy · 2011-08-22 11:09:19

No. That wouldn't be any different that trying to shove it in the middle of the command. Comments inside simple variables are not possible.

Consider that what you're trying to do is essentially the same as ...

./configure --prefix foo # this is a comment
  --enable-bar

You can't continue that line and there's no way you can differentiate that comment from noncommented text inside a var.

nTia89 · 2011-08-22 12:12:08

ok

Arch Linux

#1 2011-08-22 08:14:06

[solved] comment in PKGBUILD

#2 2011-08-22 08:21:11

Re: [solved] comment in PKGBUILD

#3 2011-08-22 08:31:32

Re: [solved] comment in PKGBUILD

#4 2011-08-22 08:46:27

Re: [solved] comment in PKGBUILD

#5 2011-08-22 09:02:17

Re: [solved] comment in PKGBUILD

#6 2011-08-22 09:59:47

Re: [solved] comment in PKGBUILD

#7 2011-08-22 10:06:36

Re: [solved] comment in PKGBUILD

#8 2011-08-22 10:09:18

Re: [solved] comment in PKGBUILD

#9 2011-08-22 10:22:06

Re: [solved] comment in PKGBUILD

#10 2011-08-22 11:09:19

Re: [solved] comment in PKGBUILD

#11 2011-08-22 12:12:08

Re: [solved] comment in PKGBUILD

Board footer