[Solve] Bash: Rename file in folder to sequential numbers saving path

cypherinside · 2011-11-13 14:58:57

I have a folder with many subfolders with many files. I want to rename all files to sequential numbers (0001.jpg, 0002.jpg, .0003,jpg ...) but i want to save the path. I mean that the files should not be saved in the root directory (where i launched the script), but I want them to remain in original subdirectorys. How can i do this?

Last edited by cypherinside (2011-11-14 18:37:16)

karol · 2011-11-13 15:02:11

What script are you using? Or are you trying to write one?

Last edited by karol (2011-11-13 15:03:28)

falconindy · 2011-11-13 15:06:59

#!/bin/bash

[[ $1 ]] || exit 1

for src in "$1"/*; do
  printf -v dest '%s/%04d.jpg' "$1" "$(( ++i ))"
  mv "$src" "$dest"
done

cypherinside · 2011-11-13 17:29:14

@Karol: I'm trying to write one
@Falconindi: It doesn't works

I tried this

i=0
find -type f -iname "*.jpg" | while read x; do
    mv "${x}" "$(printf "%04d" ${i}).jpg"
    i=$((i+1))
done

and it works but all the file are moved to the root directory! I want to preserve their path.

Last edited by cypherinside (2011-11-13 19:25:49)

ewaller · 2011-11-13 17:43:55

falconindy wrote:

...
for src in "$1"/*; do
  printf -v dest '%s/%04d.jpg' "$1" "$(( ++i ))"
  mv "$src" "$dest"
...

Question: I have done most of my coding in C and C++, I hack in Python. I have learned the hard way avoid structures like that. What is happening under-the-hood that makes it safe to modify the collection through which you are iterating?

thisoldman · 2011-11-13 19:24:48

This worked on a test directory with a single subdirectory. You must give it the parent directory name. I haven't tested it thoroughly.

#!/bin/bash
# requires a parent directory name

find "$1" -depth -iname "*.jpg" | while read file ; do
    directory=$(dirname "$file")
    oldfilename=$(basename "$file")
    newfilename=$(printf "%04d" ${i}).jpg
    i=$((i+1))
    mv "$directory/$oldfilename" "$directory/$newfilename"
done
exit 0

falconindy · 2011-11-13 19:33:26

ewaller wrote:

falconindy wrote:
...
for src in "$1"/*; do
  printf -v dest '%s/%04d.jpg' "$1" "$(( ++i ))"
  mv "$src" "$dest"
...
Question: I have done most of my coding in C and C++, I hack in Python. I have learned the hard way avoid structures like that. What is happening under-the-hood that makes it safe to modify the collection through which you are iterating?

"$1"/* isn't a collection persay. It expands to the list of matches for the glob. You're essentially making a copy of a list and then writing a new list, based on the old names.

Anyways, yeah I missed the part with about subdirectories. find works, but I'd prefer to do this still in bash:

#!/bin/bash

walk() {
  for src in "$1"/*; do
    if [[ -d $src ]]; then
      walk "$src"
      continue
    fi
    printf -v dest '%s/%04d.jpg' "$1" "$(( ++i ))"
    mv "$src" "$dest"
  done
}

[[ $1 ]] || exit 1

walk "$1"

cypherinside · 2011-11-13 21:38:02

@thisoldman: it doesn't works (the numeration is caotic)
@falconindy: thanks it works, but i want the numbering starts with 0001 for each folder.
I did not know you could define functions in bash scripts... this is wonderful.
I understand something (but not too much) about C. Can you explain me the script?

walk() {

You have defined a function

for src in "$1"/*; do ## "$1"/*

are all the subdirectory. Can i use "$(pwd)/*" instead of "$1/*"? In this way i don't write the parent directory

if [[ -d $src ]];
      walk "$src"
      continue
    fi

I dont' understand

printf -v dest '%s/%04d.jpg' "$1" "$(( ++i ))"

Stores in dest... what? I assume that %s is a string as in C language, infact you give "$1" as argument (but why?). And I assume that "$((++i))" is like i=$((i+1)). Is it right?

mv "$src" "$dest"
  done
}

Ok

[[ $1 ]] || exit 1

I don't understand.

walk "$1"

Ok

falconindy · 2011-11-13 21:47:04

cypherinside wrote:

for src in "$1"/*; do ## "$1"/*
are all the subdirectory. Can i use "$(pwd)/*" instead of "$1/*"? In this way i don't write the parent directory

If you want to specify $PWD, just call the script with an argument of '.' to point it at PWD.

cypherinside wrote:

if [[ -d $src ]];
      walk "$src"
      continue
    fi

I dont' understand

It's simple recursion. You don't want to rename directories, you want to process the contents of the directory in the same way you're processing the current directory.

cypherinside wrote:

printf -v dest '%s/%04d.jpg' "$1" "$(( ++i ))"
Stores in dest... what? I assume that %s is a string as in C language, infact you give "$1" as argument (but why?). And I assume that "$((++i))" is like i=$((i+1)). Is it right?

It's the bash equivalent of sprintf(3).

cypherinside wrote:

[[ $1 ]] || exit 1
I don't understand.

If $1 doesn't exist (i.e. you passed no arguments to the script), then refuse to run and exit immediately with an error.

You weren't really clear in your requirements, so I wrote it as I interpreted it. If you want to reset the numbering for each directory, scope 'i' locally:

#!/bin/bash

walk() {
  local -i i=0

  for src in "$1"/*; do
    if [[ -d $src ]]; then
      walk "$src"
      continue
    fi
    printf -v dest '%s/%04d.jpg' "$1" "$(( ++i ))"
    mv "$src" "$dest"
  done
}

[[ $1 ]] || exit 1

walk "$1"

cypherinside · 2011-11-13 22:39:49

Yes, I'm sorry if I was not very clear in my question (as you may have noticed I did not express very well in English... Google translate helps me! )

falconindy wrote:

If you want to specify $PWD, just call the script with an argument of '.' to point it at PWD.

No, really I want call the script without arguments (if this is possible), because this script will be part of a bigger script that doesn't use arguments (so I must run it inside the parent directory).

falconindy · 2011-11-13 22:41:22

Then remove the conditional and change the last line to:

walk "${1:-$PWD}"

Last edited by falconindy (2011-11-13 23:57:37)

cypherinside · 2011-11-13 22:50:29

I'm sorry if I insist but I do not want to use the script without understanding it: what's the benefit to use "$1"? Can i directly use $(pwd)?

EDIT: with walk "${1:$PWD}" it don't work. The script is executed in / directory!!! Luckily I used immediately CTRL+C... (fiuuuuu!) otherwise my home directory would be irretrievably compromised

Last edited by cypherinside (2011-11-13 23:12:03)

falconindy · 2011-11-13 23:04:36

The point of the change I just mentioned is that if you do not supply an argument, the script will default to $PWD.

Yes, you can hardcode in $PWD, but I fail to see the point of doing so.

http://mywiki.wooledge.org/BashGuide

cypherinside · 2011-11-13 23:09:27

read the edit, please

Last edited by cypherinside (2011-11-13 23:18:25)

falconindy · 2011-11-13 23:57:51

An unfortunate typo. Fixed.

cypherinside · 2011-11-14 18:35:19

Thanks for everything.

Arch Linux

#1 2011-11-13 14:58:57

[Solve] Bash: Rename file in folder to sequential numbers saving path

#2 2011-11-13 15:02:11

Re: [Solve] Bash: Rename file in folder to sequential numbers saving path

#3 2011-11-13 15:06:59

Re: [Solve] Bash: Rename file in folder to sequential numbers saving path

#4 2011-11-13 17:29:14

Re: [Solve] Bash: Rename file in folder to sequential numbers saving path

#5 2011-11-13 17:43:55

Re: [Solve] Bash: Rename file in folder to sequential numbers saving path

#6 2011-11-13 19:24:48

Re: [Solve] Bash: Rename file in folder to sequential numbers saving path

#7 2011-11-13 19:33:26

Re: [Solve] Bash: Rename file in folder to sequential numbers saving path

#8 2011-11-13 21:38:02

Re: [Solve] Bash: Rename file in folder to sequential numbers saving path

#9 2011-11-13 21:47:04

Re: [Solve] Bash: Rename file in folder to sequential numbers saving path

#10 2011-11-13 22:39:49

Re: [Solve] Bash: Rename file in folder to sequential numbers saving path

#11 2011-11-13 22:41:22

Re: [Solve] Bash: Rename file in folder to sequential numbers saving path

#12 2011-11-13 22:50:29

Re: [Solve] Bash: Rename file in folder to sequential numbers saving path

#13 2011-11-13 23:04:36

Re: [Solve] Bash: Rename file in folder to sequential numbers saving path

#14 2011-11-13 23:09:27

Re: [Solve] Bash: Rename file in folder to sequential numbers saving path

#15 2011-11-13 23:57:51

Re: [Solve] Bash: Rename file in folder to sequential numbers saving path

#16 2011-11-14 18:35:19

Re: [Solve] Bash: Rename file in folder to sequential numbers saving path

Board footer