You are not logged in.
Updated today. It crashed before the update with the same error. If you run it from the Settings panel you get the Execution error window. If you run it from the command line:
$ driconf
Traceback (most recent call last):
File "/usr/bin/driconf", line 28, in <module>
driconf.main()
File "/usr/lib/driconf/driconf.py", line 142, in main
simpleui.start(configList)
File "/usr/lib/driconf/driconf_simpleui.py", line 869, in start
mainWindow = MainWindow(configList)
File "/usr/lib/driconf/driconf_simpleui.py", line 520, in __init__
self.selectScreen(0)
File "/usr/lib/driconf/driconf_simpleui.py", line 605, in selectScreen
self.selectApp(self.deviceConfig.apps[1])
File "/usr/lib/driconf/driconf_simpleui.py", line 641, in selectApp
self.appPage = AppPage (self.driver, app)
File "/usr/lib/driconf/driconf_simpleui.py", line 347, in __init__
self.refreshOptions()
File "/usr/lib/driconf/driconf_simpleui.py", line 370, in refreshOptions
lineWrap(opt.getDesc([lang]).text), sectI, optI])
File "/usr/lib/driconf/driconf_simpleui.py", line 271, in lineWrap
head, tail = head + tail[:i] + '\n', tail[j:]
UnboundLocalError: local variable 'j' referenced before assignmentAny help welcome. ![]()
Also it shows no icon on the settings panel. Before the update it did. But thats not a big one.
Last edited by 89c51 (2013-09-12 12:10:44)
Offline
Old bug, never closed:
http://sourceforge.net/p/driconf/bugs/3/
The first proposed patch works for me.
Last edited by ilsensine (2013-09-12 15:36:08)
Offline
It used to work fine. I don't use it frequently and i got this today. It's impossible to know what caused the trouble.
Maybe the maintainer can apply the patch to the package.
Offline
Not sure if it's the same thing, but I was having problems with Bodhi E17 segfaulting after an update. I have Intel Sandy Bridge hardware. I was able to change GPU acceleration to uxa (from sna), and that stopped the segfaulting. Later an update to xserver-xorg-video-intel resolved the issue for me and I was able to use sna acceleration again.
Offline
Not sure if it's the same thing, but I was having problems with Bodhi E17 segfaulting after an update. I have Intel Sandy Bridge hardware. I was able to change GPU acceleration to uxa (from sna), and that stopped the segfaulting. Later an update to xserver-xorg-video-intel resolved the issue for me and I was able to use sna acceleration again.
Totally unrelated. E17 doesn't crash on me. Driconf is what crashes.
Offline
Hello, I have a similar problem. I applied the patch to the file mentioned but it does not solve the problem, instead generating a new error.
Traceback (most recent call last):
File "/usr/bin/driconf", line 26, in <module>
import driconf
File "/usr/lib/driconf/driconf.py", line 35, in <module>
import driconf_simpleui
File "/usr/lib/driconf/driconf_simpleui.py", line 261
while i >= chars/3:
^
IndentationError: unexpected indentI'm not sure if it is me applying the patch wrong or some thing else.
Offline
@Anders H
Do you use enlightenment??
Offline
@ 89c51
No I do not, I currently use KDE.
I found this thread googling the error that came up when I ran "driconf", it was exactly the same that you got. I applied the patch like I was supposed to but I came up with the error that I posted above. From some further research it appears to be an error with how python is interpreting the "white space" but I can't seem to figure out how to get it to run properly...
Offline
Could you post the relevant code? I'm not really great at Python but I'm sure someone else is. If the patch is still somewhat relevant it shouldn't be very difficult to spot a whitespace error I guess.
Offline
Here is the file with the patch applied. The error relates to line 261. I added a line as per the patch instructions at line 260.
# DRI configuration GUI: simplified UI components
# Copyright (C) 2003-2006 Felix Kuehling
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
# Contact: http://fxk.de.vu/
import os
import dri
import pygtk
pygtk.require ("2.0")
import gtk
import gobject
import driconf_commonui
import driconf_complexui
commonui = driconf_commonui # short cut
complexui = driconf_complexui
from driconf_commonui import _, lang
def isUserConfig(config):
return config.fileName.startswith(os.environ["HOME"])
def getUserConfig(configList):
userConfigs = [config for config in configList if isUserConfig(config)]
if not userConfigs:
return None
else:
return userConfigs[0]
def genNormalDeviceConfigs (configList, dpy):
""" Generate a list of normalized device configurations.
One device configuration for each installed device. Each contains
a default application configuration that explicitly sets all
options to their default values in order to override values in
previous less specific device sections. Then it appends
application configurations for all application configurations in
all configuration files that affect the respective device. The
result is one device configuration per existing device that
summarizes the entire configuration of existing devices and
overrides any previous settings.
If there is no user configuration file, an empty list is returned. """
userConfig = getUserConfig(configList)
if not userConfig:
return []
screens = [screen for screen in dpy.screens if screen]
deviceConfigs = []
# Create one device configuration for each installed device on this display
for screen in screens:
if screen == None:
continue
driver = screen.driver
deviceConfig = dri.DeviceConfig(userConfig, str(screen.num), driver.name)
defaultApp = dri.AppConfig(deviceConfig, "Default")
deviceConfig.apps.append(defaultApp)
for sect in driver.optSections:
for opt in sect.options.values():
defaultApp.options[opt.name] = dri.ValueToStr(opt.default, opt.type)
deviceConfig.isNormalized = True
deviceConfigs.append(deviceConfig)
for config in configList:
configIsUser = isUserConfig(config)
for device in config.devices:
# Determine all installed devices affected by this device-section
# in the original configuration file
curDeviceConfigs = [deviceConfig for deviceConfig in deviceConfigs
if (device.screen == None or
device.screen == deviceConfig.screen)
and (device.driver == None or
device.driver == deviceConfig.driver)]
for curDevice in curDeviceConfigs:
driver = dpy.getScreen(int(curDevice.screen)).driver
for app in device.apps:
# Determine all applications on this device affected by
# this application section in the original config file.
# It should be one at most. Create a new application
# configuration if needed.
curApps = [curApp for curApp in curDevice.apps
if app.executable == curApp.executable]
assert len(curApps) <= 1
if curApps:
curApp = curApps[0]
else:
curApp = dri.AppConfig(curDevice, app.name, app.executable)
curDevice.apps.append(curApp)
# Update all option settings. Non-existing options
# or invalid values are only considered in
# redundant device sections.
for opt,value in app.options.items():
isValid = False
if configIsUser and \
device.screen != None and device.driver != None:
isValid = True
else:
optInfo = driver.getOptInfo(opt)
if optInfo and optInfo.validate(value):
isValid = True
if isValid:
curApp.options[opt] = value
return deviceConfigs
def removeRedundantDevices (config, normalDeviceConfigs, onlyTest = False):
""" Remove device configurations that are redundant ...
... after appending normalized device configurations. If onlyTest
is True, the configuration file is not modified and this function
returns True iff there are redundant device sections. Otherwise
False is returned. """
screens = [device.screen for device in normalDeviceConfigs]
# Iterate over a copy of the device list, so that devices can be
# removed safely.
for device in config.devices[:]:
if not (hasattr(device, "isNormalized") and device.isNormalized) and \
device.screen != None and device.driver != None:
# See if there is a normalized device configuration for
# this device. In that case this section is redundant.
try:
i = screens.index(device.screen)
except ValueError:
pass
else:
if normalDeviceConfigs[i].driver == device.driver:
if onlyTest:
return True
# Remove redundant device section
config.devices.remove(device)
config.isModified = True
return False
def isRedundant (configList, dpy, normalDeviceConfigs = None):
""" Check if the user configuration is redundant.
Returns True iff there is a user configuration file that would
contain redundant device configurations after appending
normalDeviceConfigs. """
userConfig = getUserConfig(configList)
if not userConfig:
return False
if normalDeviceConfigs == None:
normalDeviceConfigs = genNormalDeviceConfigs (configList, dpy)
return removeRedundantDevices (userConfigs, normalDeviceConfigs,
onlyTest=True)
def isNormalized(configList, dpy, normalDeviceConfigs = None):
""" Check if the user configuration file is normalized ...
... in a set of configuration files, that is if the user
configuration file would be the same (except for names) after
normalization. If the user configuration file is normalized, a
list of existing normalized device configurations is returned. If
there is no user configuration file, an empty list is
returned. Otherwise, if there is a user configuration file that is
not normalized, this function returns None."""
userConfig = getUserConfig(configList)
if not userConfig:
return []
userDevs = userConfig.devices
# Find a consistent list of specific device configurations at the
# end of the user configuration file.
i = len(userDevs) - 1
while i >= 0 and userDevs[i].screen != None and userDevs[i].driver != None:
i = i - 1
i = i + 1
specificDevs = userDevs[i:]
# Make sure there is at least one for each configurable screen.
# If there are several the last one counts.
screens = [screen for screen in dpy.screens if screen]
screenDevs = [None for i in range(len(screens))]
for device in specificDevs:
screenNum = int(device.screen)
if screenNum >= len(screenDevs):
continue
if screens[screenNum].driver.name == device.driver:
screenDevs[screenNum] = device
if [None for device in screenDevs if device == None]:
return None # There are unconfigured screens
if normalDeviceConfigs == None:
normalDeviceConfigs = genNormalDeviceConfigs (configList, dpy)
# Compare existing normalized device configs with generated
# ones. If they are equivalent, the configuration file is
# normalized.
for device,normalDev in zip (screenDevs,normalDeviceConfigs):
# Check that the first executable is None and that each
# executable is configured exactly once.
executables = [app.executable for app in device.apps]
if not executables or executables[0] != None:
return None
del executables[0]
if [None for exe in executables if exe == None]:
return None
executables.sort()
normalExes = [app.executable for app in normalDev.apps]
del normalExes[0]
normalExes.sort()
if normalExes != executables:
return None
# Now check that each application contains the same option settings
# as the generated normalized configuration
for normalApp in normalDev.apps:
app = [dApp for dApp in device.apps
if dApp.executable == normalApp.executable][0]
if app.options != normalApp.options:
return None
# The configuration is normalized. Return the list of normalized device
# configurations from the user configuration files.
return screenDevs
def normalizeConfig(configList, dpy):
""" Normalize the user configuration file (if it exists) ...
... by appending normalized device configurations for each
installed device and removing redundant device configurations. If
the user configuration file is already normalized, only existing
normalized device configurations are marked as such and redundant
device configurations are removed. """
newDeviceConfigs = genNormalDeviceConfigs (configList, dpy)
existingDeviceConfigs = isNormalized (configList, dpy, newDeviceConfigs)
if not existingDeviceConfigs and not newDeviceConfigs:
return []
userConfig = getUserConfig(configList)
if existingDeviceConfigs:
# is already normalized, mark existing normalized device
# configurations as such.
for deviceConfig in existingDeviceConfigs:
deviceConfig.isNormalized = True
deviceConfigs = existingDeviceConfigs
elif newDeviceConfigs:
userConfig.devices.extend(newDeviceConfigs)
userConfig.isModified = True
deviceConfigs = newDeviceConfigs
# Remove redundant device configurations from the user
# configuration file
removeRedundantDevices (userConfig, deviceConfigs)
return deviceConfigs
def lineWrap (string, chars=30):
head = ""
tail = string
while len(tail):
if len(tail) <= chars:
return head + tail
else:
i = chars
j = i
while i >= chars/3:
if tail[i] == ' ':
j = i + 1
break
elif tail[i] == '-':
i = i + 1
j = i
break
i = i - 1
if i < chars/3:
i = chars
head, tail = head + tail[:i] + '\n', tail[j:]
return head
class AppDialog (gtk.Dialog):
def __init__ (self, title, parent, app=None):
gtk.Dialog.__init__(self, title, parent,
gtk.DIALOG_MODAL|gtk.DIALOG_DESTROY_WITH_PARENT,
("gtk-ok", gtk.RESPONSE_OK,
"gtk-cancel", gtk.RESPONSE_CANCEL))
self.set_resizable(False)
table = gtk.Table(3, 2)
nameLabel = gtk.Label(_("Application Name"))
nameLabel.show()
table.attach(nameLabel, 0, 1, 0, 1, 0, gtk.EXPAND, 10, 5)
self.nameEntry = gtk.Entry()
if app:
self.nameEntry.set_text(app.name)
self.nameEntry.connect("activate",
lambda widget: self.response(gtk.RESPONSE_OK))
self.nameEntry.show()
table.attach(self.nameEntry, 1, 2, 0, 1,
gtk.EXPAND|gtk.FILL, gtk.EXPAND, 10, 5)
execLabel = gtk.Label(_("Executable Name"))
execLabel.show()
table.attach(execLabel, 0, 1, 1, 2, 0, gtk.EXPAND, 10, 5)
self.execEntry = gtk.Entry()
if app:
self.execEntry.set_text(app.executable)
self.execEntry.connect("activate",
lambda widget: self.response(gtk.RESPONSE_OK))
self.execEntry.show()
table.attach(self.execEntry, 1, 2, 1, 2,
gtk.EXPAND|gtk.FILL, gtk.EXPAND, 10, 5)
hBox = gtk.HBox(spacing=10)
infoImageVBox = gtk.VBox()
infoImage = commonui.StockImage(gtk.STOCK_DIALOG_INFO,
gtk.ICON_SIZE_DIALOG)
infoImage.show()
infoImageVBox.pack_start(infoImage, False, False, 0)
infoImageVBox.show()
hBox.pack_start(infoImageVBox, False, False, 0)
infoLabel = gtk.Label(_(
"The executable name is important for identifying the "
"application. If you get it wrong, your settings will not "
"apply. Beware that some applications are started by a "
"shell script, that has a different name than the real "
"executable."))
# TODO: Add a small database of known applications with their
# executable names that can be picked from a menu.
infoLabel.set_line_wrap (True)
infoLabel.show()
hBox.pack_start(infoLabel, False, False, 0)
hBox.show()
table.attach (hBox, 0, 2, 2, 3,
gtk.EXPAND|gtk.FILL, gtk.EXPAND, 10, 5)
table.show()
self.vbox.pack_start(table, True, True, 5)
self.show()
self.nameEntry.grab_focus()
def getName (self):
return self.nameEntry.get_text()
def getExecutable (self):
return self.execEntry.get_text()
class AppPage (gtk.ScrolledWindow):
def __init__ (self, driver, app):
""" Constructor. """
gtk.ScrolledWindow.__init__ (self)
self.set_policy (gtk.POLICY_NEVER, gtk.POLICY_AUTOMATIC)
self.driver = driver
self.app = app
self.tooltips = gtk.Tooltips()
self.table = None
self.refreshOptions()
def refreshOptions (self):
if self.table:
self.remove(self.get_child())
self.optLines = []
self.table = gtk.Table(len(self.app.options)+1, 3)
self.add_with_viewport(self.table)
self.optionTree = gtk.TreeStore(gobject.TYPE_STRING, gobject.TYPE_INT, gobject.TYPE_INT)
i = 0
sectI = 0
for sect in self.driver.optSections:
sectIter = self.optionTree.append(None, [
lineWrap(sect.getDesc([lang])), sectI, -1])
sectHasOpts = False
optI = 0
for opt in sect.optList:
if self.app.options.has_key(opt.name):
self.optLines.append(
commonui.OptionLine(self, i, opt, True, True))
i = i + 1
else:
self.optionTree.append(sectIter, [
lineWrap(opt.getDesc([lang]).text), sectI, optI])
sectHasOpts = True
optI = optI + 1
if not sectHasOpts:
self.optionTree.remove(sectIter)
sectI = sectI + 1
if len(self.optionTree) > 0:
addLabel = commonui.WrappingDummyCheckButton(_("Add setting"),
width=200)
addLabel.show()
self.table.attach(addLabel, 0, 1, i, i+1, gtk.EXPAND|gtk.FILL, 0, 5, 5)
addCombo = gtk.ComboBox(self.optionTree)
addCombo.connect("changed", self.addOption)
cell = gtk.CellRendererText()
addCombo.pack_start(cell, True)
addCombo.add_attribute(cell, 'text', 0)
addCombo.show()
self.table.attach(addCombo, 1, 2, i, i+1, gtk.FILL, 0, 5, 5)
self.table.show()
def optionModified (self, optLine):
self.app.modified(self.app)
def removeOption (self, optLine, opt):
del self.app.options[opt.name]
self.refreshOptions()
self.app.modified(self.app)
def addOption (self, combo):
activeIter = combo.get_active_iter()
if not activeIter:
# Got triggered by the set_active(-1) below.
return
sectI = self.optionTree.get_value(activeIter, 1)
optI = self.optionTree.get_value(activeIter, 2)
if optI < 0:
combo.set_active(-1)
return
opt = self.driver.optSections[sectI].optList[optI]
self.app.options[opt.name] = dri.ValueToStr(opt.default, opt.type)
self.refreshOptions()
self.app.modified(self.app)
def doValidate (self):
pass
def commit (self):
for optLine in self.optLines:
name = optLine.opt.name
value = optLine.getValue()
if value == None and self.app.options.has_key(name):
del self.app.options[name]
elif value != None:
self.app.options[name] = value
class MainWindow (gtk.Window):
def __init__ (self, configList):
gtk.Window.__init__(self)
self.set_title(_("Direct Rendering Preferences"))
self.set_type_hint(gtk.gdk.WINDOW_TYPE_HINT_DIALOG)
self.set_border_width(10)
self.connect("destroy", lambda dummy: gtk.main_quit())
self.connect("delete_event", self.exitHandler)
self.configList = configList # Remember for switching to expert mode
self.userConfig = getUserConfig(configList)
self.screens = [screen for screen in commonui.dpy.screens if screen]
self.vbox = gtk.VBox(spacing=10)
if len(self.screens) > 1:
self.deviceCombo = gtk.combo_box_new_text()
for screen in self.screens:
if screen.glxInfo:
self.deviceCombo.append_text(_("Screen") + " %d: %s (%s)" % (
screen.num, screen.glxInfo.renderer, screen.glxInfo.vendor))
else:
self.deviceCombo.append_text(_("Screen") + " %d: %s" % (
screen.num, screen.driver.name.capitalize()))
self.deviceCombo.set_active(0)
self.deviceCombo.connect("changed", self.changeDevice)
self.deviceCombo.show()
self.vbox.pack_start(self.deviceCombo, False, False, 0)
else:
screen = self.screens[0]
if screen.glxInfo:
text = "%s (%s)" % (
screen.glxInfo.renderer, screen.glxInfo.vendor)
else:
text = _("Screen") + " %d: %s" % (
screen.num, screen.driver.name.capitalize())
deviceHBox = gtk.HBox()
deviceLabel = gtk.Label()
deviceLabel.set_justify(gtk.JUSTIFY_LEFT)
deviceLabel.set_markup("<b>" + commonui.escapeMarkup(text) + "</b>")
deviceLabel.show()
deviceHBox.pack_start(deviceLabel, False, False, 0)
deviceHBox.show()
self.vbox.pack_start(deviceHBox, False, False, 0)
buttonBox = gtk.HButtonBox()
buttonBox.set_layout(gtk.BUTTONBOX_END)
expertButton = gtk.Button()
expertHBox = gtk.HBox()
expertImage = commonui.StockImage("gtk-jump-to", gtk.ICON_SIZE_BUTTON)
expertImage.show()
expertHBox.pack_start(expertImage)
expertLabel = gtk.Label(_("Expert Mode"))
expertLabel.show()
expertHBox.pack_start(expertLabel)
expertHBox.show()
expertButton.add(expertHBox)
expertButton.connect("clicked", self.expertHandler)
expertButton.show()
buttonBox.add(expertButton)
closeButton = gtk.Button(stock="gtk-close")
closeButton.connect("clicked", lambda dummy: gtk.main_quit())
closeButton.show()
buttonBox.add(closeButton)
aboutButton = gtk.Button(stock="gtk-about")
aboutButton.connect("clicked", self.aboutHandler)
aboutButton.show()
buttonBox.add(aboutButton)
buttonBox.set_child_secondary(aboutButton, True)
buttonBox.show()
self.vbox.pack_end(buttonBox, False, False, 0)
self.expander = gtk.Expander(
"<b>" + commonui.escapeMarkup(_("Application settings")) + "</b>")
self.expander.set_use_markup(True)
self.expander.connect("activate", self.expanderChanged)
self.expander.show()
self.vbox.pack_end(self.expander, False, True, 0)
self.expanderVBox = gtk.VBox(spacing=10)
self.appButtonBox = gtk.HBox()
self.appRemoveButton = gtk.Button(stock="gtk-remove")
self.appRemoveButton.connect("clicked", self.removeApp)
self.appRemoveButton.show()
self.appButtonBox.pack_end(self.appRemoveButton, False, False, 0)
addButton = gtk.Button(stock="gtk-add")
addButton.connect("clicked", self.addApp)
addButton.show()
self.appButtonBox.pack_end(addButton, False, False, 0)
self.appPropButton = gtk.Button(stock="gtk-properties")
self.appPropButton.connect("clicked", self.appProperties)
self.appPropButton.show()
self.appButtonBox.pack_end(self.appPropButton, False, False, 0)
self.appButtonBox.show()
self.expanderVBox.pack_start(self.appButtonBox, False, False, 0)
self.expanderVBox.show()
self.expander.add(self.expanderVBox)
self.notebook = None
self.appCombo = None
self.appNotebook = None
self.appPage = None
self.selectScreen(0)
self.vbox.show()
self.add(self.vbox)
def selectScreen (self, n):
self.curScreen = self.screens[n]
# Find that device's configuration in the user config. Search
# from the end, because that's where the normalized configs are.
self.deviceConfig = None
i = len(self.userConfig.devices)-1
while i >= 0 and self.userConfig.devices[i].screen != None and \
self.userConfig.devices[i].driver != None:
if self.curScreen.num == int(self.userConfig.devices[i].screen) and \
self.curScreen.driver.name == self.userConfig.devices[i].driver:
self.deviceConfig = self.userConfig.devices[i]
self.driver = self.curScreen.driver
break
i = i - 1
# Sanity checks. These should all be true after normalization.
assert(self.deviceConfig)
assert(self.deviceConfig.isNormalized)
assert(len(self.deviceConfig.apps) > 0 and
self.deviceConfig.apps[0].executable == None)
# Register modified callback
self.deviceConfig.apps[0].modified = self.configModified
# Build UI for the screen configuration
if self.notebook:
self.vbox.remove(self.notebook)
self.notebook = gtk.Notebook()
self.notebook.popup_enable()
self.sectPages = []
self.sectLabels = []
unknownPage = commonui.UnknownSectionPage (self.driver,
self.deviceConfig.apps[0])
if len(unknownPage.opts) > 0:
unknownPage.show()
unknownLabel = gtk.Label (_("Unknown options"))
unknownLabel.show()
self.notebook.append_page (unknownPage, unknownLabel)
self.sectPages.append (unknownPage)
self.sectLabels.append (unknownLabel)
for sect in self.driver.optSections:
sectPage = commonui.SectionPage (sect, self.deviceConfig.apps[0],
True)
sectPage.set_policy(gtk.POLICY_NEVER, gtk.POLICY_AUTOMATIC)
sectPage.show()
desc = sect.getDesc([lang])
if desc:
sectLabel = gtk.Label (desc)
sectLabel.set_line_wrap (True)
else:
sectLabel = gtk.Label (_("(no description)"))
sectLabel.show()
self.notebook.append_page (sectPage, sectLabel)
self.sectPages.append (sectPage)
self.sectLabels.append (sectLabel)
if len(self.sectLabels) > 0:
style = self.sectLabels[0].get_style()
self.default_normal_fg = style.fg[gtk.STATE_NORMAL].copy()
self.default_active_fg = style.fg[gtk.STATE_ACTIVE].copy()
self.validate()
self.notebook.show()
self.vbox.pack_start(self.notebook, True, True, 0)
if self.appCombo:
self.appButtonBox.remove(self.appCombo)
self.appCombo = gtk.combo_box_new_text()
for i in range(1,len(self.deviceConfig.apps)):
self.appCombo.append_text(self.deviceConfig.apps[i].name)
if len(self.deviceConfig.apps) > 1:
self.appCombo.set_active(0)
self.expander.set_expanded(True)
self.vbox.set_child_packing(self.expander, True, True,
0, gtk.PACK_END)
self.appPropButton.set_sensitive(True)
self.appRemoveButton.set_sensitive(True)
else:
self.expander.set_expanded(False)
self.vbox.set_child_packing(self.expander, False, True,
0, gtk.PACK_END)
self.appPropButton.set_sensitive(False)
self.appRemoveButton.set_sensitive(False)
self.appCombo.connect("changed", self.changeApp)
self.appCombo.show()
self.appButtonBox.pack_start(self.appCombo, True, True, 0)
if len(self.deviceConfig.apps) > 1:
self.selectApp(self.deviceConfig.apps[1])
else:
self.selectApp(None)
def selectApp (self, app):
if self.appNotebook:
self.expanderVBox.remove(self.appNotebook)
self.appNotebook = None
self.appPage = None
elif self.appPage:
self.expanderVBox.remove(self.appPage)
self.appPage = None
if not app:
self.appPropButton.set_sensitive(False)
self.appRemoveButton.set_sensitive(False)
return
self.appPropButton.set_sensitive(True)
self.appRemoveButton.set_sensitive(True)
app.modified = self.configModified
unknownPage = commonui.UnknownSectionPage (self.driver,
app)
if len(unknownPage.opts) > 0:
self.appNotebook = gtk.Notebook()
self.appNotebook.popup_enable()
unknownPage.show()
unknownLabel = gtk.Label (_("Unknown options"))
unknownLabel.show()
self.appNotebook.append_page (unknownPage, unknownLabel)
self.appPage = AppPage (self.driver, app)
self.appPage.show()
appPageLabel = gtk.Label (_("Known options"))
appPageLabel.show()
self.appNotebook.append_page (self.appPage, appPageLabel)
self.appNotebook.show()
appWidget = self.appNotebook
else:
self.appPage = AppPage (self.driver, app)
self.appPage.show()
appWidget = self.appPage
self.expanderVBox.pack_start (appWidget, True, True, 0)
def validate (self):
""" Validate the configuration.
Labels of invalid section pages are highlighted. Returns whether
there were invalid option values. """
index = 0
allValid = True
for sectPage in self.sectPages:
valid = sectPage.validate()
if not valid:
# strange, active and normal appear to be swapped :-/
self.sectLabels[index].modify_fg (
gtk.STATE_NORMAL, gtk.gdk.Color (65535, 0, 0))
self.sectLabels[index].modify_fg (
gtk.STATE_ACTIVE, gtk.gdk.Color (65535, 0, 0))
else:
self.sectLabels[index].modify_fg (
gtk.STATE_NORMAL, self.default_normal_fg)
self.sectLabels[index].modify_fg (
gtk.STATE_ACTIVE, self.default_active_fg)
allValid = allValid and valid
index = index+1
return allValid
def commit (self):
for sectPage in self.sectPages:
sectPage.commit()
if self.appPage:
self.appPage.commit()
def changeDevice (self, combo):
self.selectScreen(combo.get_active())
def changeApp (self, combo):
active = combo.get_active()
if active >= 0:
app = self.deviceConfig.apps[active+1]
else:
app = None
if self.appPage:
lastApp = self.appPage.app
else:
lastApp = None
if app != lastApp:
if lastApp:
self.appPage.commit()
self.selectApp(app)
def expanderChanged (self, expander):
# This signal handler seems to get called before the expander
# state is changed. So the logic is reversed.
if not self.expander.get_expanded():
self.vbox.set_child_packing(self.expander, True, True,
0, gtk.PACK_END)
else:
self.vbox.set_child_packing(self.expander, False, True,
0, gtk.PACK_END)
def checkAppProperties (self, dialog, name, executable, sameApp=None):
errorStr = None
if name == "" or executable == "":
# Error message
errorStr = _("You must enter both an application name and "
"an executable name.")
else:
for app in self.deviceConfig.apps:
if app != sameApp and name == app.name:
errorStr = _("There exists an application "
"configuration with the same name. "
"Please enter a different name.")
break
elif app != sameApp and executable == app.executable:
errorStr = _("There exists an application "
"configuration for the same "
"executable. You can't create multiple "
"application configurations for the "
"same executable.")
break
if errorStr:
dialog = gtk.MessageDialog(
dialog, gtk.DIALOG_MODAL|gtk.DIALOG_DESTROY_WITH_PARENT,
gtk.MESSAGE_ERROR, gtk.BUTTONS_OK, errorStr)
dialog.run()
dialog.destroy()
return False
return True
def addApp (self, button):
dialog = AppDialog(_("Add Application"), self)
done = False
while not done:
response = dialog.run()
if response == gtk.RESPONSE_OK:
name = dialog.getName().strip()
executable = dialog.getExecutable().strip()
if self.checkAppProperties (dialog, name, executable):
app = dri.AppConfig(self.deviceConfig, name, executable)
self.deviceConfig.apps.append(app)
self.appCombo.append_text(name)
self.appCombo.set_active(len(self.deviceConfig.apps)-2)
self.configModified (self.deviceConfig)
done = True
else:
done = True
dialog.destroy()
def appProperties (self, button):
if not self.appPage:
return
dialog = AppDialog(_("Application Properties"), self, self.appPage.app)
done = False
while not done:
response = dialog.run()
if response == gtk.RESPONSE_OK:
name = dialog.getName().strip()
executable = dialog.getExecutable().strip()
if self.checkAppProperties (dialog, name, executable,
self.appPage.app):
i = self.deviceConfig.apps.index(self.appPage.app)
self.appCombo.remove_text(i-1)
self.appCombo.insert_text(i-1, name)
self.appCombo.set_active(i-1)
self.appPage.app.name = name
self.appPage.app.executable = executable
self.configModified (self.appPage.app)
done = True
else:
done = True
dialog.destroy()
def removeApp (self, button):
if not self.appPage:
return
i = self.deviceConfig.apps.index(self.appPage.app)
if i+1 < len(self.deviceConfig.apps):
newI = i
newApp = self.deviceConfig.apps[i+1]
elif i > 1:
newI = i-1
newApp = self.deviceConfig.apps[i-1]
else:
newI = 0
newApp = None
del self.deviceConfig.apps[i]
self.selectApp(newApp)
self.appCombo.remove_text(i-1)
self.appCombo.set_active(newI-1)
self.configModified(self.deviceConfig)
def exitHandler (self, widget, event=None):
# Always ok to destroy the window
return False
def aboutHandler (self, widget):
dialog = commonui.AboutDialog()
dialog.show()
dialog.run()
dialog.destroy()
def expertHandler (self, widget):
self.destroy() # triggers main_quit
complexui.start(self.configList)
gtk.main()
def configModified (self, node, b=True):
if b != True:
return
# Save the configuration file
try:
file = open (self.userConfig.fileName, "w")
except IOError:
dialog = gtk.MessageDialog (
commonui.mainWindow, gtk.DIALOG_DESTROY_WITH_PARENT,
gtk.MESSAGE_ERROR, gtk.BUTTONS_OK,
_("Can't open \"%s\" for writing.") % self.userConfig.fileName)
dialog.run()
dialog.destroy()
self.inConfigModified = False
return
self.commit()
file.write (str(self.userConfig))
file.close()
def validateDriverPanel (self):
self.validate()
def start (configList):
userConfig = getUserConfig(configList)
if not userConfig:
dialog = gtk.MessageDialog (
None, 0, gtk.MESSAGE_ERROR, gtk.BUTTONS_OK,
_("The DRI configuration file \"%s\" is broken or could not be "
"created.") % os.path.join (os.environ["HOME"], ".drirc") +" "+
_("DRIconf will be started in expert mode."))
dialog.run()
dialog.destroy()
complexui.start(configList)
return
if not userConfig.writable:
# Not writable: start expert mode
dialog = gtk.MessageDialog (
None, 0, gtk.MESSAGE_WARNING, gtk.BUTTONS_OK,
_("Your DRI configuration file \"%s\" is not writable.") %
userConfig.fileName +" "+
_("DRIconf will be started in expert mode."))
dialog.run()
dialog.destroy()
complexui.start(configList)
return
normalizedDeviceConfigs = normalizeConfig(configList, commonui.dpy)
if normalizedDeviceConfigs == None:
dialog = gtk.MessageDialog (
None, 0, gtk.MESSAGE_ERROR, gtk.BUTTONS_OK,
_("Normalization of your DRI configuration file \"%s\" failed. "
"Please report a bug with the original configuration file "
"attached. The file will be treated as read-only for now.") %
userConfig.fileName +" "+
_("DRIconf will be started in expert mode."))
dialog.run()
dialog.destroy()
userConfig.writable = False
complexui.start(configList)
return
mainWindow = MainWindow(configList)
commonui.mainWindow = mainWindow
mainWindow.set_default_size (-1, 500)
mainWindow.show()
# Save modified normalized configuration before we start
if hasattr(userConfig, "isModified") and userConfig.isModified:
mainWindow.configModified(userConfig)Offline
@89c51
Did you get this patch working? If so could you post your code as well so I may compare.
Offline
No. Sorry. Didn't bother with it at all. Driconf isn't something that i use regularly.
Offline
Someone opened a bug report and the patch to fix it is there: https://bugs.archlinux.org/task/36934
Just removing the lines 270 and 271 and replacing with:
270 - else:
271 - i = j = chars
And with that it definitely works.
Last edited by AnnS (2013-09-18 21:24:09)
ASUS ROG G15 AMD Advantage | AMD Ryzen 9 5900HX | 8GB DDR4-3200 | AMD Radeon RX 6800M 12GB GDDR6 |
Acer Aspire 7741G-6426 | Intel Core i5-480M 2.66GHz | 8GB RAM DDR3 1333MHz | 640GB HDD 5400RPM | AMD Radeon 6550M 1GB DDR3 |
Lenovo 3000 C200 | Intel Core 2 Duo T5500 1.66GHz | 2GB RAM DDR2 667MHz | 250GB HDD 5400RPM | Intel GMA 950 |
Offline
@AnnS That fixed it for me. Thanks a bunch! However for me the lines were 269 & 270.
@89c51 Does this patch work for you too?
Last edited by Anders H (2013-09-19 23:52:22)
Offline
@Anders H
Didn't bother applying the patch. I ll just wait for the packager to fix it.
Offline
The package was updated today, but the problem's still there.
Also, the thread title is misleading as all hell - E17 has nothing to do with it (I use Openbox, on its own as well).
Last edited by aphirst (2013-10-10 13:10:48)
ArchLinux | x86_64 | linux-ck-ivybridge
ThinkPad X230 | 12.5" | i5-3320M (2.5GHz) | HD 4000 | 16GB (1600MHz) | 256GB mSATA SSD | 2TB HDD
ThinkPad T430 | 14.1" | i7-3520M (2.9GHz) | GF108M (NVS 5400M) | 16GB (1600MHz) | 256GB mSATA SSD | 1TB HDD | 500GB HDD
Offline
The package was updated today, but the problem's still there.
Also, the thread title is misleading as all hell - E17 has nothing to do with it (I use Openbox, on its own as well).
When i started the thread i thought it was an E related thing. I don't use any other DE. Anyway.
I just updated and it works ok for me. The only problem is the icon that doesn't display on the settings menu (in E17 that is) but thats just a minor thing.
If it works for the rest i can mark it as Solved.
Offline