Arch Linux

android_808

Member

Registered: 2011-10-17

Posts: 19

[SOLVED] Help with updating conky-colors PKGBUILD

I'm looking to update my PKGBUILD for https://aur.archlinux.org/packages/conky-colors/ to support the latest version.  After getting annoyed with DeviantArt replacing the zips of the package when it is updated upstream, I've decided to pull in specific commits from the git repo instead.  I'm trying to use the ...#commit= option on the source line.  It seems to be building ok but I'm getting the following errors:

/usr/bin/makepkg: eval: line 2225: unexpected EOF while looking for matching `"'
/usr/bin/makepkg: eval: line 2226: syntax error: unexpected end of file

Can anyone give any help as to what may be the cause here.  If i remove the #commit it goes away.  I need to clean up the depends section to remove those that are no longer needed, but I can do that easy enough.

# Maintainer:  Android_808 <android underscore 808 at hotmail dot com>
# Contributor: Pauline123 <321eniluap at gmail dot com>
# Contributor: Shanto <shanto at hotmail>
# Contributor: Piotr Rogoża <rogoza dot piotr at gmail dot com>
pkgname=conky-colors
_pkgname=conky_colors
pkgver=9.0
pkgrel=1
pkgdesc="An easier way to configure Conky."
arch=('i686' 'x86_64')
url="http://gnome-look.org/content/show.php/CONKY-colors?content=92328"
license=('GPL')
depends=('pystatgrab' 'ttf-liberation' 'hddtemp' 'curl' 'lm_sensors' 'conky' 'ttf-droid' 'ttf-ubuntu-font-family' 'ttf-ms-fonts')
makedepends=('perl' 'git')
optdepends=('conky-lua')
conflicts=('ttf-openlogos' 'ttf-weather')
options="!strip"
install=$pkgname.install
source=("$pkgname::git+https://github.com/helmuthdu/conky_colors.git#commit=f4b530a94d5f3f73d4c21c4417c51b6011a71b28")
md5sums=('SKIP')


build() {
	cd "$srcdir/conky-colors"
	make
}

package() {
	cd "$srcdir/conky-colors"
	
	mkdir -p ${pkgdir}/usr/share
	mkdir -p ${pkgdir}/usr/share/fonts
	mkdir -p ${pkgdir}/usr/bin
	cp -v conky-colors ${pkgdir}/usr/bin
	cp -v -r conkycolors ${pkgdir}/usr/share
	#cp -v -r fonts ${pkgdir}/usr/share/conkycolors
	cp -v -r fonts/conkycolors ${pkgdir}/usr/share/fonts/TTF
	ln -fs /usr/share/conkycolors/bin/conkyTask ${pkgdir}/usr/bin/ct
	#ln -fs /usr/share/conkycolors/fonts/conkycolors ${pkgdir}/usr/share/fonts/
	chmod +x ${pkgdir}/usr/share/conkycolors/scripts/*
	chmod +x ${pkgdir}/usr/share/conkycolors/bin/*
	chmod -R 755 ${pkgdir}/usr/share/conkycolors/
}

Last edited by android_808 (2013-11-11 19:33:06)

Scimmia

Fellow

Registered: 2012-09-01

Posts: 13,729

Re: [SOLVED] Help with updating conky-colors PKGBUILD

Check your install file.

android_808

Member

Registered: 2011-10-17

Posts: 19

Re: [SOLVED] Help with updating conky-colors PKGBUILD

I've not really edited the install file in a long time, but it was pretty much a copy & paste from an existing package.  I've checked it over and I can't see anything obviously wrong here either.

post_install() {
	echo -n "Updating font cache... "
	fc-cache -f > /dev/null
	echo "done."
}

post_upgrade() {
	post_install $1
}

post_remove() {
	post_install $1
}

Scimmia

Fellow

Registered: 2012-09-01

Posts: 13,729

Re: [SOLVED] Help with updating conky-colors PKGBUILD

I don't get an error using your PKGBUILD and .install file. I do get it if the .install file doesn't exist, but it goes away when I comment out the line for the install file.

android_808

Member

Registered: 2011-10-17

Posts: 19

Re: [SOLVED] Help with updating conky-colors PKGBUILD

I didn't post the install earlier because I've never had an issue with it, been using the same file for several releases of several custom built packages.  The eval: lines posted appear before "Making package: conky-colors 9.0-1 (Mon 11 Nov 18:58:03 GMT 2013)" but doesn't prevent it from building.  Just don't get what's causing them.

Install files "s have matching end ", brackets have brackets. namcap PKGBUILD gave no error.
PKGBUILD ' has matching '
                 " has matching "
                 ( has matching )

Scimmia

Fellow

Registered: 2012-09-01

Posts: 13,729

Re: [SOLVED] Help with updating conky-colors PKGBUILD

ah, you're right, it does still show them, I didn't notice them after it continued.

Looking at makepkg line 2225, it's happening when reading the options. options should be an array, not single variable. add perens.

android_808

Member

Registered: 2011-10-17

Posts: 19

Re: [SOLVED] Help with updating conky-colors PKGBUILD

Thank you.  I'd just worked out it went away if I commented that line out.  Thats probably the only line I've never edited since I inherited the PKGBUILD when I took over as maintainer.