Arch Linux

badosu

Member

Registered: 2013-11-01

Posts: 7

Feedback on submitting a new package

Hi Guys,

I am quite new to the Arch community and I just created a project to enable users of Asus laptops to adjust their keyboard backlights without depending of a specific Desktop Environment.

I'd like to have some feedback on the PKGBUILD and compliance with Arch standards, before submitting it to AUR.

For me this package is extremely useful, so I hope for other users it can be too.

Please check: https://github.com/badosu/asuskblctl

Thanks!

badosu

Member

Registered: 2013-11-01

Posts: 7

Re: Feedback on submitting a new package

Just found https://aur.archlinux.org/packages/asus-kbd-backlight, so I won't submit it to AUR. But some feedback would still be nice!

karol

Archivist

Registered: 2009-05-06

Posts: 25,440

Re: Feedback on submitting a new package

You're not building anything, these are scripts to be interpreted, no compilation needed, so what's the purpose of build() in your PKGBUILD?
'chmod +x asuskblctl asuskblperm' is not necessary as you use 'install' in package() part.
Since this is a script, I think

arch=(any)

is the correct choice https://wiki.archlinux.org/index.php/Pkgbuild#arch :

The value any can also be used for architecture-independent packages.

See e.g. https://aur.archlinux.org/packages/al/a … r/PKGBUILD how to create a simple PKGBUILD that just drops a script into place.

Stebalien

Member

Registered: 2010-04-27

Posts: 1,239

Website

Re: Feedback on submitting a new package

The build section is redundant; `install -Dm755` will make the scripts executable. Also (technically), you should "discover" the systemd unit directory using `pkg-config systemd --variable=systemdsystemunitdir`. That is:

install -Dm644 asuskblperm.service "${pkgdir}$(pkg-config systemd --variable=systemdsystemunitdir)/asuskblperm.service"

---

Steven [ web : git ]
GPG:  327B 20CE 21EA 68CF A7748675 7C92 3221 5899 410C

badosu

Member

Registered: 2013-11-01

Posts: 7

Re: Feedback on submitting a new package

Nice! Thanks karol, and Stebalien.

WIll certainly address these issues!

Actually it looks like asus-kbd-backlight is not giving (others) permissions, so maybe I will get back to use this package!

badosu

Member

Registered: 2013-11-01

Posts: 7

Re: Feedback on submitting a new package

Take a look at the new PKGBUILD: https://github.com/badosu/asuskblctl/bl … r/PKGBUILD!

Also, what do you think about using heredocs like https://aur.archlinux.org/packages/as/a … t/PKGBUILD?

karol

Archivist

Registered: 2009-05-06

Posts: 25,440

Re: Feedback on submitting a new package

I don't like it, but heredocs are at least readable, unlike e.g. encoding it in base64 ...