You are not logged in.

#1 2014-03-23 19:28:19

thanos
Member
From: Greece
Registered: 2008-11-22
Posts: 22

Eucalyptus cloud on archlinux

Hello,

I built Eucalyptus cloud under archlinux and created a PKGBUILD for it.I didn't upload it to AUR as i want to make sure that everything is ok with the PKGBUILD,the packages and make/depends.

You can find the PKGBUILD here with the other sources.Do you have any suggestions  for improvement?

Thank you


Reference links:
INSTALL file for eucalyptus
RPMspec for eucalyptus
Eucalyptus on Slackware

Offline

#2 2014-03-23 19:53:23

Scimmia
Bug Wrangler
Registered: 2012-09-01
Posts: 4,804

Re: Eucalyptus cloud on archlinux

Wow, that's quite a PKGBUILD.

Why do most of the pkgdesc's start with "This package contains...". Seems redundant.
Why is it split up so much? For instance, python-eucadmin says it's never to be used alone, so why isn't it just part of the eucalyptus-admin-tools package?
You have a lot of path containing $srcdir and $pkgdir that are not quoted.
I think you could eliminate a lot of the install command by using the -D option or by globbing.

Offline

#3 2014-03-23 20:12:00

progandy
Member
Registered: 2012-05-17
Posts: 2,146

Re: Eucalyptus cloud on archlinux

I believe it would be a nice idea to move the part below "make fakeinstall install" in a new function like this:
Edit: And then use mv instead of copy to create the separate packages.

_fakeinstalldir=""

build() {
...
   make
}

# 1 parameter: file to test if a new fakeinstall is required
_fakeinstall() {
    _fakeinstalldir="$srcdir/_fakeinstall"
    [ -f "$_fakeinstalldir/$1" ] && return
    install -dm644 "$_fakeinstalldir"
    make DESTDIR="$_fakeinstalldir" install
...
}

package_foo() {
    cd "$pkgdir"
    _fakeinstall usr/bin/foo
    install -dm644 $pkgdir/usr
    mv "$_fakeinstalldir"/usr/bin "$pkgdir"/usr/
}

package_foo-bar() {
    cd "$pkgdir"
    _fakeinstall usr/lib/bar
    install -dm644 $pkgdir/usr
    mv "$_fakeinstalldir"/usr/lib "$pkgdir"/usr/
}

Last edited by progandy (2014-03-23 20:16:15)

Offline

#4 2014-03-24 12:14:26

thanos
Member
From: Greece
Registered: 2008-11-22
Posts: 22

Re: Eucalyptus cloud on archlinux

Scimmia wrote:

Wow, that's quite a PKGBUILD.
Why is it split up so much? For instance, python-eucadmin says it's never to be used alone, so why isn't it just part of the eucalyptus-admin-tools package?

You're right.I followed the upstream packaging structure and i don't know why they split eucadmin in two packages.
Maybe they want to have one package for admin's cli tools and another one for python libs.Anyway i will ask them in their mailing list.

Offline

#5 2014-03-24 12:37:25

Lone_Wolf
Member
From: Netherlands, Europe
Registered: 2005-10-04
Posts: 4,167

Re: Eucalyptus cloud on archlinux

I've looked  a bit at the splits , and there are way to many.

I agree with Scimmia python-eucadmin should be part of eucalytus-admin-tools
also eucalyptus-common-java-libs is only used by ecualyptus-common-java, so should be combined with it.

The package_eucalyptus is used by all other package_* (except eucalyptus-common-java-libs) , so should have a name that reflects that , like eucalyptus-common .

Since eucalyptus-common-java requires eucalyptus , every package_* that requires eucalyptus-common-java doesn't need to list eucalyptus as dependency.


Booting with apg Openrc, NOT systemd.
Automounting : not needed, i prefer pmount
Aur helpers : makepkg + my own local repo === rarely need them

Offline

#6 2014-03-24 14:57:29

Scimmia
Bug Wrangler
Registered: 2012-09-01
Posts: 4,804

Re: Eucalyptus cloud on archlinux

thanos wrote:
Scimmia wrote:

Wow, that's quite a PKGBUILD.
Why is it split up so much? For instance, python-eucadmin says it's never to be used alone, so why isn't it just part of the eucalyptus-admin-tools package?

You're right.I followed the upstream packaging structure and i don't know why they split eucadmin in two packages.
Maybe they want to have one package for admin's cli tools and another one for python libs.Anyway i will ask them in their mailing list.

This is standard on many other distros, they seem to split things up nearly to the point of one file per package sometimes. Arch doesn't do such sillyness.

Offline

#7 2014-03-25 11:33:56

thanos
Member
From: Greece
Registered: 2008-11-22
Posts: 22

Re: Eucalyptus cloud on archlinux

So i combined python-eucadmin with admin-tools and java-libs with java-common.Added quotes to $srcdir and $pkgdir and dependencies.
About dependencies,shouild i assume that the base group is installed in a system? If so,i have to update the depends array for some packages.


About eucalyptus-admin-tools and python-eucadmin,the answer i got:

At one point there were plans to have more than just the admin tools
using that python module.  Those plans have since evaporated, so at this
point putting them both in the same package should be perfectly safe.

Offline

#8 2014-03-25 20:39:51

Lone_Wolf
Member
From: Netherlands, Europe
Registered: 2005-10-04
Posts: 4,167

Re: Eucalyptus cloud on archlinux

for AUR packages, the base-devel group is assumed to be installed .

You can use namcap from repos to help checking dependencies.


Booting with apg Openrc, NOT systemd.
Automounting : not needed, i prefer pmount
Aur helpers : makepkg + my own local repo === rarely need them

Offline

Board footer

Powered by FluxBB