You are not logged in.

#1 2015-06-12 08:09:50

mrz87
Member
Registered: 2011-05-11
Posts: 8

[Feedback] tarsnap-gui PKGBUILD

Hello forum,

I've created a PKGBUILD for the newly released beta of tarsnap-gui, and I was thinking of uploading it to AUR.
Since this would be my first public PKGBUILD, I'd like to have some feedback on the quality of the script before going with this.

Here it is:

_gitname=tarsnap-gui                                                                                                                                                             
pkgname=tarsnap-gui-git                                                                                                                                                          
pkgver=v0.5.r2.g1b3b346                                                                                                                                                          
pkgrel=1                                                                                                                                                                         
pkgdesc="Cross platform GUI for the Tarsnap command line client"                                                                                                                 
arch=('i686' 'x86_64')                                                                                                                                                           
url="https://github.com/Tarsnap/tarsnap-gui"                                                                                                                                     
license=('BSD')                                                                                                                                                                  
depends=('qt5-base')                                                                                                                                                             
makedepends=('git')                                                                                                                                                              
provides=('tarsnap-gui')                                                                                                                                                         
source=("${_gitname}::git+https://github.com/Tarsnap/tarsnap-gui.git")                                                                                                           
md5sums=('SKIP')                                                                                                                                                                 
                                                                                                                                                                                 
pkgver() {                                                                                                                                                                       
    cd $_gitname                                                                                                                                                                 
    git describe --long | sed 's/\([^-]*-g\)/r\1/;s/-/./g'                                                                                                                       
}                                                                                                                                                                                
                                                                                                                                                                                 
build() {                                                                                                                                                                        
    cd $_gitname                                                                                                                                                                 
                                                                                                                                                                                 
    qmake                                                                                                                                                                        
    make                                                                                                                                                                         
}                                                                                                                                                                                
                                                                                                                                                                                 
package() {                                                                                                                                                                      
    cd $_gitname                                                                                                                                                                 
    install -Dm755 ./tarsnap-gui "${pkgdir}/usr/bin/tarsnap-gui"                                                                                                                 
}     

Thanks for your time.


EDIT:

I've noticed after posting that there's already a package on AUR. I'd guess this is not useful anymore then!

Last edited by mrz87 (2015-06-12 08:11:17)

Offline

#2 2015-06-12 08:17:44

jasonwryan
Anarchist
From: .nz
Registered: 2009-05-09
Posts: 30,426
Website

Re: [Feedback] tarsnap-gui PKGBUILD

Yours is a better PKGBUILD...


Arch + dwm   •   Mercurial repos  •   Surfraw

Registered Linux User #482438

Offline

#3 2015-06-15 16:53:19

mrz87
Member
Registered: 2011-05-11
Posts: 8

Re: [Feedback] tarsnap-gui PKGBUILD

jasonwryan wrote:

Yours is a better PKGBUILD...

Hey, thanks. Perhaps I'll contact the current maintainer to see if there's something I can do to help.

Offline

#4 2015-06-17 19:26:01

thiagowfx
Member
Registered: 2013-07-09
Posts: 586

Re: [Feedback] tarsnap-gui PKGBUILD

Yes, publish a comment in the already existing package page pointing to your PKGBUILD.

I also find yours better and cleaner.

Offline

Board footer

Powered by FluxBB