Abort on failed check in pre_upgrade()

windy · 2015-11-21 08:38:45

Hi,

my AUR package should check for an existing backup of config data before upgrading the package. If there is no backup, the upgrade should abort.

However, my attempt to stop the upgrade with "exit 1" did not succeed. How can I perform this?

Lone_Wolf · 2015-11-21 12:35:16

I assume you're using the pre_upgrade section of an .install script for that ?

please post your .install file and PKGBUILD

WorMzy · 2015-11-21 12:39:27

Can you explain your usecase? If you're trying to prevent overwriting a customised config file, I'm wondering why you're not just using the backup array in the PKGBUILD.

EDIT: Moving to Creating & Modifying Packages.

Last edited by WorMzy (2015-11-21 12:40:50)

Allan · 2015-11-21 12:46:48

That won't work - pre_upgrade is run before that particular package is updated. As that could be in the middle of a system update, aborting the update may lead to an unusable system.

You will be able to do this with hooks in the next pacman release.

windy · 2015-11-21 12:59:56

My use case is the following package:

https://aur.archlinux.org/packages/upsource/

The new major version requires an import of old backup files. I would like to abort the upgrade process if no backup is available.

Lone_Wolf · 2015-11-21 13:34:06

Windy,would it be sufficient to check for an existing backup at build-time ?

If so,you could add the backup-check to the PKGBUILD body (before any functions) and use ||return 1 to have the build fail.
(add an echo statement so the user will know why the build fails).

It's not ideal, but should work for an AUR package.

WorMzy · 2015-11-21 14:21:14

I'm still not getting the reasoning behind this. Presumably it is possible to run the software without this backup, or else people who install v2 directly (not upgrading from v1) will be unable to run it.

It seems you're trying to automate the migration for users. I strongly recommend against that. Displaying a message in the post_install scriptlet explaining what the user needs to do to migrate their configuration should be sufficient.

windy · 2015-11-22 12:05:27

WorMzy wrote:

It seems you're trying to automate the migration for users. I strongly recommend against that. Displaying a message in the post_install scriptlet explaining what the user needs to do to migrate their configuration should be sufficient.

Normally I would agree to this, but Upsource requires a backup made with the previous version. Once the update is done, there is no way other than downgrading again and performing a backup.

Arch Linux

#1 2015-11-21 08:38:45

Abort on failed check in pre_upgrade()

#2 2015-11-21 12:35:16

Re: Abort on failed check in pre_upgrade()

#3 2015-11-21 12:39:27

Re: Abort on failed check in pre_upgrade()

#4 2015-11-21 12:46:48

Re: Abort on failed check in pre_upgrade()

#5 2015-11-21 12:59:56

Re: Abort on failed check in pre_upgrade()

#6 2015-11-21 13:34:06

Re: Abort on failed check in pre_upgrade()

#7 2015-11-21 14:21:14

Re: Abort on failed check in pre_upgrade()

#8 2015-11-22 12:05:27

Re: Abort on failed check in pre_upgrade()

Board footer