Arch Linux

Psirus

Member

Registered: 2012-01-29

Posts: 45

Review my PKGBUIlD for python-ahkab

This is my first try for a PKGBUILD for ahkab. What needs changing before I can up it to the AUR?

# Maintainer: Christoph Pohl <christophpohl@gmx.com>
pkgname=python-ahkab
pkgver=0.18
pkgrel=1
pkgdesc="A SPICE-like electronic circuit simulator written in Python"
arch=('any')
url="https://ahkab.github.io/ahkab/"
license=('GPL')
depends=('python-numpy' 'python-scipy' 'python-sympy' 'python-tabulate')
optdepends=('python-matplotlib: plotting')
checkdepends=('python-nose')
source=("https://github.com/ahkab/ahkab/archive/v0.18.tar.gz")
md5sums=('9f82ed50cf654e87437713a87ced4f1f')

package() {
  cd "$srcdir/ahkab-$pkgver"
  python setup.py install --root="$pkgdir/" --optimize=1
}

Scimmia

Fellow

Registered: 2012-09-01

Posts: 11,553

Re: Review my PKGBUIlD for python-ahkab

Looks very good. I can only see two things.

1. The license seems to be GPL2. GPL is used when it is 2 or any later version, this one seems to specify version 2 only.

2. The source filename should use $pkgver. As it is right now, you have to change the version in two places on each update, which is an easy thing to forget. You should also use a different filename, if $SRCDIR is set and another PKGBUILD downloads a file with the same name (which is very possible when dealing with github), it will give errors.

Edit, a third thing! checkdepends doesn't do anything if there's no check function.

Last edited by Scimmia (2015-12-07 17:47:31)

Psirus

Member

Registered: 2012-01-29

Posts: 45

Re: Review my PKGBUIlD for python-ahkab

Okay, the first thing is easy enough.

license=('GPL2')

The second point I only partially understand. The first part means changing the source line to

source=("https://github.com/ahkab/ahkab/archive/v$pkgver.tar.gz")

right? How I then go about changing the filename, I don't know.

To the third point, I'll just leave out the checkdepends. Would that be alright?

Last edited by Psirus (2015-12-07 17:56:11)

Scimmia

Fellow

Registered: 2012-09-01

Posts: 11,553

Re: Review my PKGBUIlD for python-ahkab

For the second point, you got the $pkgver part. For the other part, you can rename the file locally by putting "<filename>::" in front of the URL.

On the third point, yeah, you'd either leave out the checkdepends or add a check function. Your choice.

Psirus

Member

Registered: 2012-01-29

Posts: 45

Re: Review my PKGBUIlD for python-ahkab

Thank you very much. I've uploaded it, with your corrections, to the AUR.