Arch Linux

bach

Member

Registered: 2014-10-20

Posts: 27

creating noebox package

Hello there,

i'm really happy to post here my first arch package
it would be nice if some of you could check/test it before i push it to the aur
more details about nodebox here :   https://www.nodebox.net/
and the sources of the package are here : https://g-u-i.me/gogs/bachir/nodebox-git

bach

Scimmia

Fellow

Registered: 2012-09-01

Posts: 11,560

Re: creating noebox package

I don't know anything about this software or node, really, so my comments will be on the packaging only.

The pkgdesc should not contain "Nodebox is"
Is there anything architecture specific in the final package? If not, the architecture array is wrong.
Does it specifically need jdk8-openjdk, or would java-environment or java-runtime do?
The git repo is already called "nodebox", so renaming it to "nodebox" does nothing. Similarly, git+git:// is redundant.
Personally, I would remove the leading "v" in the pkgver.
Combination of tab and space indents can be confusing. I'm guessing you had tabs set to 2 spaces and everything looked right, but it's not. Just look at the source and md5sums arrays.

Edit:
GPL2 is a standard license, it doesn't need to be installed again.
Is validpgpkeys doing anything here? I see no signatures

Last edited by Scimmia (2016-02-04 16:59:49)

bach

Member

Registered: 2014-10-20

Posts: 27

Re: creating noebox package

Thank you Scimmia !
i fixed every things you pointed out. (not sure about the tabs/spaces)

Scimmia

Fellow

Registered: 2012-09-01

Posts: 11,560

Re: creating noebox package

Looks good to me.

About the tabs/spaces, installing the license was indented with 2 spaces before, where everything else was indented with a tab. A tab can be interpreted in a lot of ways, most commonly as 8 columns. This was also an issue when you were using tabs to align things in the source and md5sums arrays, as you were using 4 tabs making it appear in the web interface as 32 columns instead of the 8 that you intended.

bach

Member

Registered: 2014-10-20

Posts: 27

Re: creating noebox package

i have a problem while i'm trying to push to aur
i generated the .SRCINFO with mksrcinfo command but i have this message
some help would be much appreciated

$ git push aur master
Décompte des objets: 51, fait.
Delta compression using up to 8 threads.
Compression des objets: 100% (49/49), fait.
Écriture des objets: 100% (51/51), 581.79 KiB | 0 bytes/s, fait.
Total 51 (delta 19), reused 0 (delta 0)
remote: error: The following errors occurred when parsing .SRCINFO in commit
remote: error: 82e232b88a6e49e6371f5647378a73994a8fab40:
remote: error: line 4: unexpected new section not starting with 'pkgname' found
remote: error: line 5: unexpected new section not starting with 'pkgname' found
remote: error: line 6: unexpected new section not starting with 'pkgname' found
remote: error: line 7: unexpected new section not starting with 'pkgname' found
remote: error: line 8: unexpected new section not starting with 'pkgname' found
remote: error: line 9: unexpected new section not starting with 'pkgname' found
remote: error: line 10: unexpected new section not starting with 'pkgname' found
remote: error: line 11: unexpected new section not starting with 'pkgname' found
remote: error: line 12: unexpected new section not starting with 'pkgname' found
remote: error: line 13: unexpected new section not starting with 'pkgname' found
remote: error: line 14: unexpected new section not starting with 'pkgname' found
remote: error: line 15: unexpected new section not starting with 'pkgname' found
remote: error: line 16: unexpected new section not starting with 'pkgname' found
remote: error: line 17: unexpected new section not starting with 'pkgname' found
remote: error: line 18: unexpected new section not starting with 'pkgname' found
remote: error: line 19: unexpected new section not starting with 'pkgname' found
remote: error: line 20: unexpected new section not starting with 'pkgname' found
remote: error: line 21: unexpected new section not starting with 'pkgname' found
remote: error: line 22: unexpected new section not starting with 'pkgname' found
remote: error: line 23: unexpected new section not starting with 'pkgname' found
remote: error: hook declined to update refs/heads/master
To ssh://aur@aur.archlinux.org/nodebox-git.git
 ! [remote rejected] master -> master (hook declined)
error: impossible de pousser des références vers 'ssh://aur@aur.archlinux.org/nodebox-git.git'

[edit]
i resolved the problem by wiping out the repos and starting from the start, as every commits in the git tree must have .SRCINFO file.

nodebox-git is now on aur

Last edited by bach (2016-02-04 22:23:58)