Arch Linux

djscholl

Member

From: Michigan, USA

Registered: 2006-05-24

Posts: 56

Newbie vtwm PKGBUILD for review, w/ license='custom' query

I would appreciate comments on this newbie PKGBUILD before I post it on AUR. This builds vtwm, a lightweght X11 window manager based on twm. It is highly customizable, and I particularly like its elegant implementation of a virtual desktop. vtwm is a mature package, but not well known. Configuration is via text file, so Arch users should feel right at home. This is basically a stock build with one exception: I turned off desktop sound support. I did this because vtwm only supports sound via rplay, which I don't see in any of the Arch repositories.

# Contributor: David Scholl <djscholl>
pkgname=vtwm
pkgver=5.4.7
pkgrel=1
pkgdesc="A lightweght, customizable window manager with a virtual desktop"
url="http://www.vtwm.org"
license="custom"
depends=('libxpm' 'libxmu' 'm4')
makedepends=('imake')
backup=('etc/X11/vtwm/system.vtwmrc')
source=("http://www.vtwm.org/downloads/$pkgname-$pkgver.tar.gz")
md5sums=('707f8d93b19b46fb3d036053be66288b')

build() {
  cd $startdir/src/$pkgname-$pkgver
  sed -i '/^XCOMM NO_SOUND_SUPPORT/s/^XCOMM//' Imakefile
  sed -i '/^SOUNDLIB/s//XCOMM SOUNDLIB/' Imakefile
  sed -i '/^SOUNDINC/s//XCOMM SOUNDINC/' Imakefile
  sed -i '/VTWMLIBDIR/s/$(LIBDIR)/twm//etc/X11/vtwm/' Imakefile
  xmkmf || return 1
  make || return 1
  make DESTDIR=$startdir/pkg install
  mkdir -p $startdir/pkg/usr/share/licenses/$pkgname
  head -26 add_window.c > $startdir/pkg/usr/share/licenses/$pkgname/EH_MIT
  head -20 applets.c > $startdir/pkg/usr/share/licenses/$pkgname/MIT
  head -18 desktop.c > $startdir/pkg/usr/share/licenses/$pkgname/DE_ICSTM
  head -24 gram.c > $startdir/pkg/usr/share/licenses/$pkgname/Bison_GPL
  head -22 sound.c > $startdir/pkg/usr/share/licenses/$pkgname/DJHJ
  cp contrib/nexpm/xpm.COPYRIGHT $startdir/pkg/usr/share/licenses/$pkgname/
  chmod 644 $startdir/pkg/usr/share/licenses/$pkgname/* 
}

namcap warns about the dependence on m4, which is optionally called during configuration file processing, and namcap can't see that. The build worked fine on my system and a friend's system, for what it's worth.

I particularly wanted to ask about the Arch way of handling the license material. The individual source code files are covered under six different licenses, five of them provided as file headers. It offended my personal sense of order to dump a bunch of C code into /usr/share/licenses/, so I wrote the build script to pop off the file headers and place them into individual files. If this is contrary to the Arch way, or if someone has already come up with a better solution for this situation, I would be glad to hear about it.

Thanks in advance for any suggestions/corrections anyone might have.

David Scholl

Snowman

Developer/Forum Fellow

From: Montreal, Canada

Registered: 2004-08-20

Posts: 5,212

Re: Newbie vtwm PKGBUILD for review, w/ license='custom' query

Looks fine to me. Very impressive for a first PKGBUILD.