Arch Linux

bearvrrr

Member

Registered: 2016-12-20

Posts: 3

PKGBUILD review request: python3/Gtk3 lightdm greeter

Please could you let me know if there are any problems or quality issues with the PKGBUILD below

# Maintainer: Andrew Bates <andrew dot bates at cantab dot net>

pkgname=lightdm-kbswitch-greeter-git
_pkgname=lightdm-kbswitch-greeter
pkgver=0.1.r1.gfd79f5e
pkgrel=1
pkgdesc="Python and Gtk+ greeter for LightDM"
arch=('any')
url="https://github.com/bearvrrr/lightdm-kbswitch-greeter"
license=('GPL3')
depends=('python-gobject' 'gobject-introspection' 'lightdm' 'gtk3')
optdepends=('lightdm-gtk-greeter: session badge icons')
makedepends=('git' 'python-distutils-extra')
source=("${_pkgname}"::'git+https://github.com/bearvrrr/lightdm-kbswitch-greeter.git')
md5sums=('SKIP')
provides=('lightdm-kbswitch-greeter')
conflicts=('lightdm-kbswitch-greeter')
backup=('etc/lightdm-kbswitch-greeter.conf')

pkgver() {
  cd "${srcdir}/${_pkgname}"
  git describe --tags | sed 's|^v||;s|\([^-]*-g\)|r\1|;s|-|.|g'
}

package() { 
  cd "${srcdir}/${_pkgname}"
  python setup.py install --root="$pkgdir/" --prefix=/usr --optimize=1
}

# vim:set ts=2 sw=2 et:

Scimmia

Fellow

Registered: 2012-09-01

Posts: 11,550

Re: PKGBUILD review request: python3/Gtk3 lightdm greeter

Looks very good. Only things I see are extremely minor and don't really matter. You have braces on all of the variables except $pkgdir, and you don't need to include ${srcdir} when you cd, as functions already start there.

x33a

Forum Fellow

Registered: 2009-08-15

Posts: 4,587

Re: PKGBUILD review request: python3/Gtk3 lightdm greeter

Looks fine to me. Have you tried building it?

Edit: Ninja'd by Scimmia.

bearvrrr

Member

Registered: 2016-12-20

Posts: 3

Re: PKGBUILD review request: python3/Gtk3 lightdm greeter

You have braces on all of the variables except $pkgdir

Okay, so actually I think I'd be better removing them since I'm not doing parameter expansion.

Have you tried building it?

Yes, built and installed it

$ pacman -Ql lightdm-kbswitch-greeter-git
lightdm-kbswitch-greeter-git /etc/
lightdm-kbswitch-greeter-git /etc/lightdm/
lightdm-kbswitch-greeter-git /etc/lightdm/lightdm-kbswitch-greeter.conf
lightdm-kbswitch-greeter-git /usr/
lightdm-kbswitch-greeter-git /usr/bin/
lightdm-kbswitch-greeter-git /usr/bin/lightdm-kbswitch-greeter
lightdm-kbswitch-greeter-git /usr/lib/
lightdm-kbswitch-greeter-git /usr/lib/python3.5/
lightdm-kbswitch-greeter-git /usr/lib/python3.5/site-packages/
lightdm-kbswitch-greeter-git /usr/lib/python3.5/site-packages/lightdm_kbswitch_greeter-0.1-py3.5.egg-info
lightdm-kbswitch-greeter-git /usr/lib/python3.5/site-packages/lightdm_kbswitch_greeter/
lightdm-kbswitch-greeter-git /usr/lib/python3.5/site-packages/lightdm_kbswitch_greeter/__init__.py
lightdm-kbswitch-greeter-git /usr/lib/python3.5/site-packages/lightdm_kbswitch_greeter/__pycache__/
lightdm-kbswitch-greeter-git /usr/lib/python3.5/site-packages/lightdm_kbswitch_greeter/__pycache__/__init__.cpython-35.opt-1.pyc
lightdm-kbswitch-greeter-git /usr/lib/python3.5/site-packages/lightdm_kbswitch_greeter/__pycache__/__init__.cpython-35.pyc
lightdm-kbswitch-greeter-git /usr/lib/python3.5/site-packages/lightdm_kbswitch_greeter/__pycache__/greeter.cpython-35.opt-1.pyc
lightdm-kbswitch-greeter-git /usr/lib/python3.5/site-packages/lightdm_kbswitch_greeter/__pycache__/greeter.cpython-35.pyc
lightdm-kbswitch-greeter-git /usr/lib/python3.5/site-packages/lightdm_kbswitch_greeter/__pycache__/greeter_background.cpython-35.opt-1.pyc
lightdm-kbswitch-greeter-git /usr/lib/python3.5/site-packages/lightdm_kbswitch_greeter/__pycache__/greeter_background.cpython-35.pyc
lightdm-kbswitch-greeter-git /usr/lib/python3.5/site-packages/lightdm_kbswitch_greeter/greeter.py
lightdm-kbswitch-greeter-git /usr/lib/python3.5/site-packages/lightdm_kbswitch_greeter/greeter_background.py
lightdm-kbswitch-greeter-git /usr/share/
lightdm-kbswitch-greeter-git /usr/share/doc/
lightdm-kbswitch-greeter-git /usr/share/doc/lightdm-kbswitch-greeter/
lightdm-kbswitch-greeter-git /usr/share/doc/lightdm-kbswitch-greeter/README.rst
lightdm-kbswitch-greeter-git /usr/share/icons/
lightdm-kbswitch-greeter-git /usr/share/icons/hicolor/
lightdm-kbswitch-greeter-git /usr/share/icons/hicolor/scalable/
lightdm-kbswitch-greeter-git /usr/share/icons/hicolor/scalable/places/
lightdm-kbswitch-greeter-git /usr/share/icons/hicolor/scalable/places/last-session_badge-symbolic.svg
lightdm-kbswitch-greeter-git /usr/share/icons/hicolor/scalable/places/openbox_badge-symbolic.svg
lightdm-kbswitch-greeter-git /usr/share/lightdm-kbswitch-greeter/
lightdm-kbswitch-greeter-git /usr/share/lightdm-kbswitch-greeter/lightdm-kbswitch-greeter-application.css
lightdm-kbswitch-greeter-git /usr/share/lightdm-kbswitch-greeter/lightdm-kbswitch-greeter.ui
lightdm-kbswitch-greeter-git /usr/share/locale/
lightdm-kbswitch-greeter-git /usr/share/locale/en_GB/
lightdm-kbswitch-greeter-git /usr/share/locale/en_GB/LC_MESSAGES/
lightdm-kbswitch-greeter-git /usr/share/locale/en_GB/LC_MESSAGES/lightdm-kbswitch-greeter.mo
lightdm-kbswitch-greeter-git /usr/share/xgreeters/
lightdm-kbswitch-greeter-git /usr/share/xgreeters/lightdm-kbswitch-greeter.desktop

bearvrrr

Member

Registered: 2016-12-20

Posts: 3

Re: PKGBUILD review request: python3/Gtk3 lightdm greeter

Here it is with corrections. backup was also wrong, not sure how I missed that when I first built it. Thanks for your help

# Maintainer: Andrew Bates <andrew dot bates at cantab dot net>

pkgname=lightdm-kbswitch-greeter-git
_pkgname=lightdm-kbswitch-greeter
pkgver=0.1.r1.gfd79f5e
pkgrel=1
pkgdesc="Python and Gtk+ greeter for LightDM"
arch=('any')
url="https://github.com/bearvrrr/lightdm-kbswitch-greeter"
license=('GPL3')
depends=('python-gobject' 'gobject-introspection' 'lightdm' 'gtk3')
optdepends=('lightdm-gtk-greeter: session badge icons')
makedepends=('git' 'python-distutils-extra')
source=("${_pkgname}"::'git+https://github.com/bearvrrr/lightdm-kbswitch-greeter.git')
md5sums=('SKIP')
provides=('lightdm-kbswitch-greeter')
conflicts=('lightdm-kbswitch-greeter')
backup=('etc/lightdm/lightdm-kbswitch-greeter.conf')

pkgver() {
  cd "$srcdir/$_pkgname"
  git describe --tags | sed 's|^v||;s|\([^-]*-g\)|r\1|;s|-|.|g'
}

package() { 
  cd "$srcdir/$_pkgname"
  python setup.py install --root="$pkgdir/" --prefix=/usr --optimize=1
}

# vim:set ts=2 sw=2 et: