Arch Linux

jesusrop

Member

Registered: 2013-10-19

Posts: 14

PKGBUILD review request: stellarium-legacy

Hi all,

even though arch is a rolling release and likes to stay in the latest version, for stellarium that means that people wth modest hardware can't run the last version. Version 0.12 is maintained for legacy hardware and even some fixes are beeing introduced. Recently version 0.12.7 was launched, so I modified ianux's stellarium-bzr PKGBUILD (thanks!) to build this legacy version. Dependencies and compile instructions where modified according to the stellarium wiki and some guessing. This builds fine in my laptop, but I'm not sure if the dependencies are OK. Anyone can check this?

PKGBUILD

pkgname=stellarium-legacy
_dirname=stellarium-0.12.7
pkgver=0.12.7
pkgrel=1
pkgdesc="A 3D planetarium software which renders realistic skies in real time"
arch=('i686' 'x86_64')
url="http://stellarium.org/"
license=('GPL2')
conflicts=('stellarium' 'stellarium-svn' 'stellarium-bzr')
provides=('stellarium')
replaces=('stellarium')
depends=('desktop-file-utils' 'freetype2' 'glu' 'libgl' 'libpng' 'openssl' 'phonon-qt4' 'qt4' 'xdg-utils')
makedepends=('boost' 'cmake' 'mesa' 'mesa-libgl')
#optdepends:('phonon-qt4: sound support')
source=('http://downloads.sourceforge.net/project/stellarium/Stellarium-sources/0.12.7/stellarium-0.12.7.tar.gz')
sha256sums=('3c6de52fc1499041f0b7b9d271a7b698b59801cceb35f116ad8fb390dcb196db')
install='stellarium.install'

build() {
  cd $_dirname
  cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Release
  make
}

package() {
  cd $_dirname
  make DESTDIR="$pkgdir" install
}

stellarium.install

post_install() {
  update-desktop-database -q
  xdg-icon-resource forceupdate
}

post_upgrade() {
  post_install $1
}

post_remove() {
  post_install $1
}

Scimmia

Fellow

Registered: 2012-09-01

Posts: 11,544

Re: PKGBUILD review request: stellarium-legacy

This should not use "replaces". Get rid of that line.

Hooks now take care of updating the desktop mime database and the icon caches. Get rid of the install file.

Putting mesa-libgl in the makedepends will make a lot of people unhappy. It not necessarily wrong, but with the way the AUR is used, it just doesn't work very well.

I would suggest using "$pkgver" in the source array. This way you only need to change the version in one place instead of three.

There's no real need for _dirname. Just use "stellarium-$pkgver".

Would this be better called stellarium-lts? What does upstream call it?

Last edited by Scimmia (2017-01-02 04:35:50)

Lone_Wolf

Member

From: Netherlands, Europe

Registered: 2005-10-04

Posts: 11,911

Re: PKGBUILD review request: stellarium-legacy

I'd suggest depending on libgl instead of mesa.

---

Disliking systemd intensely, but not satisfied with alternatives so focusing on taming systemd.

(A works at time B)  && (time C > time B ) ≠  (A works at time C)