PKGBUILD review request: fet-timetabling

tikrass · 2017-01-10 16:26:09

Hello,
can someone please review this package for me? I am not sure about the architecture, because namcap gives me an error. I could not find any information about the architecture in the documentation of FET an assume, that it can be compiled for x64 and x32.

$ namcap PKGBUILD fet-timetabling-5.30.8-1-any.pkg.tar.xz 
fet-timetabling E: ELF file ('usr/bin/fet-cl') found in an 'any' package.
fet-timetabling E: ELF file ('usr/bin/fet') found in an 'any' package.

PKGBUILD (Updated)

# Maintainer: Thibaud Kehler <thibaud.kehler at gmx dot net>
pkgname='fet-timetabling'
_module='fet'
pkgver='5.30.8'
pkgrel=1
pkgdesc="A software for automatically scheduling the timetable of a school, high-school or university."
arch=('x86_64' 'i686')
url="http://lalescu.ro/liviu/fet/"
license=('AGPL3')
depends=('qt5-base' 'hicolor-icon-theme' 'gcc-libs')
source=("http://lalescu.ro/liviu/fet/download/$_module-$pkgver.tar.bz2")
md5sums=('fb40209e56ab5e66806e72b686846611')

build() {
	cd "$srcdir/$_module-$pkgver"
	qmake-qt5 fet.pro "DEFINES+=USE_SYSTEM_LOCALE"
	make
}

package() {
	cd "$srcdir/$_module-$pkgver"
	make INSTALL_ROOT="${pkgdir}/" install
}

Thanks in advance.

Last edited by tikrass (2017-01-10 17:14:04)

Scimmia · 2017-01-10 16:55:21

"any" means that the end package can be used on any architectures, such as script or data packages. If this builds anything architecture specific, you can't use "any".

Why in the world would gcc-libs-multilib be a dependency?

qt5-base is already in depends, it doesn't need to be in makedepends as well.

tikrass · 2017-01-10 17:13:45

Ok, thank you.

I copied the gcc-libs-multilib from namcap, without thinking about it. My bad. I now realise that gcc-libs would be better. Or should I remove it completely?

Updated the PKGBUILD in first post.

Slithery · 2017-01-10 17:50:30

The gcc-libs package is in base, which is assumed to be installed on all Arch systems. Remove it.

eschwartz · 2017-01-10 18:05:08

I always found it a bit off-putting that we scold people for listing dependencies that are in base, and then looking at the output of `pacman -Sii gcc-libs` I see:

Required By     : abuse  agg  alsa-tools  alsaplayer  apcupsd  apricots  archboot  aspell  asplib  assaultcube  assimp  astyle  atanks  atomicparsley
                  audiofile  augeas  avr-gcc  bbpager  belle-sip  blackbox  blas  bliss-graphs  bochs  boinctui  botan  botan1.10  bsd-games  capi4hylafax
                  cauchy  cdargs  cdrdao  ceph  chuck  clasp  clementine  clthreads  clucene  clxclient  cmt  commoncpp2  corrade  coxeter3  cppunit  cromfs
                  crypto++  cryptominisat2  ctemplate  darkstat  db  ddd  ddrescue  dillo  directfb  discid  docker-machine  dosbox  doxygen  dvd+rw-tools
                  dvgrab  dwarffortress  dxpc  exempi  exiv2  fbterm  fcgi  fftw  fillets-ng  fish  flac  freeimage  frei0r-plugins  gambas3-gb-db-sqlite2
                  gambas3-gb-db-sqlite3  gambas3-gb-image-effect  gambas3-gb-xml  gambatte-sdl  gc  gcc  geos  gettext  gflags  glee  glslang  gmock  gmp
                  gnucap  gnustep-back  gnustep-base  gnustep-gui  gnutls  google-glog  gost  gperf  gptfdisk  graphite  groff  gsoap  gtest  handbrake
                  handbrake-cli  hdf5-cpp-fortran  hex-a-hop  higan  ht  hunspell  i810-dri  ibam  icu  id3  id3lib  id3v2  idesk  ilmbase  incron  intel-tbb
                  iperf  iptstate  iverilog  ivtv-utils  jade  john  js  js17  js185  jsoncpp  keystone  ktoblzcheck  kyotocabinet  ladspa  lftp  libbraiding
                  libc++  libc++abi  libcdio  libconfig  libebml  libechonest  libelf  libfbclient  libfilezilla  libftdi-compat  libgme  libgooglepinyin
                  libharu  liblightdm-qt5  libmodplug  libmp4v2  libpgf  libproxy  libpst  libreoffice-fresh  libreoffice-fresh-sdk  libreoffice-still
                  libreoffice-still-sdk  libretro-bsnes  libretro-desmume  libretro-gambatte  libretro-mednafen-psx  libretro-nestopia  libretro-scummvm
                  libretro-snes9x  libsidplay  libsidplayfp  libsigc++  libsmbios  libsoxr  libstdc++5  libsynaptics  libtaginfo  libtiff  libtiff4  libunrar
                  libvdpau  libvirt  libvoikko  libvolk  libvpx  libwpd  libxcomp  libzen  live-media  llvm-libs  llvm35-libs  log4cplus  log4cpp  lshw
                  luajit  lzip  mac  mach64-dri  marisa  marsyas  mcqd  medit  mga-dri  milkytracker  mjpegtools  mkvtoolnix-cli  mongodb-tools  mpgtx
                  muparser  musicbrainz  ncurses  netcdf  netcdf-cxx  netcdf-fortran  nethogs  ngspice  ninja  nload  nspluginwrapper  ocrad  ode  ogmtools
                  opencc  opensips  openthreads  oprofile  p7zip  p8-platform  parity  patchelf  pbzip2  pcre  pcre2  pdf2djvu  pekwm  plotutils  poppler
                  portaudio  portsmf  powerdns-recursor  powertop  projectm-libvisual  protobuf  pstoedit  qemu-guest-agent  qhull  qpress  qqwing
                  qtcurve-utils  qucs  r  r128-dri  ragel  rarian  re2  re2c  retroarch  ripgrep  rlog  rubiks  rust  savage-dri  sbsms  schroedinger  sdcc
                  silly  simutrans  sis-dri  smartmontools  smpeg2  snappy  soundtouch  spirv-tools  splix  steghide  stk  sunpinyin  swig  synergy  tdfx-dri
                  tesseract  thin-provisioning-tools  thrift  tinyxml  tinyxml2  tlsh  tvision  tvtime  uchardet  uncrustify  unichrome-dri  unittestpp
                  unrar  v4l-utils  vamp-plugin-sdk  vapoursynth  vapoursynth-plugin-deblock  vapoursynth-plugin-f3kdb  vapoursynth-plugin-mvtools  vbindiff
                  vid.stab  vigra  virtualbox  vtk  vtk6  vulkan-validation-layers  wbar  webrtc-audio-processing  wine  wine-staging  wine-staging-nine
                  wvdial  x265  xbase  xerces-c  xmahjongg  xnc  xpacman2  xplc  yaml-cpp  zeromq  zimg  zinnia  zita-alsa-pcmi  zita-convolver
                  zita-resampler  zopfli  zsnes  zstd  zynaddsubfx

Worse is bash, with some "optional for", even!

Required By     : 9base  abcde  abs  acpid  afl  allegro4  antiword  antlr2  apache-ivy  arch-install-scripts  arch-wiki-lite  archboot  arptables  atop
                  audio-convert  aurphan  autoconf  autoconf-2.64  automake  bash-bats  bash-completion  bash-statemgr  bashburn  bashdb  bashrun  bison  boo
                  botan  botan1.10  bsd-games  bspwm  bwidget  bzip2  ca-certificates-utils  checksec  cjdns  clojure  commoncpp2  cppunit  cpupower
                  create_ap  cronie  cscope  datefudge  db  dejagnu  dguitar  dhclient  dhcpcd  dialog  dictd  diffutils  dkms  dmenu  drbd-utils  dvdrtools
                  e2fsprogs  easy-rsa  ebtables  ecl  ed  erlang-cl  fakeroot  fftw  figlet  findutils  fio  flex  foomatic-db-engine  freeradius-client
                  freetype2  gambit-c  gawk  gdbm  geos  gettext  glsof  gmock  gmp  gnome-common  gnuchess  gnump3d  gpm  gradle  gradle-doc  gradle-src
                  grails  groovy  grub  gsl  gtest  gzip  hardening-wrapper  haskell-dataenc  haskell-extensible-exceptions  haskell-filemanip
                  haskell-hashable  haskell-hashtables  haskell-http  haskell-mtl  haskell-network  haskell-network-uri  haskell-parsec  haskell-random
                  haskell-stm  haskell-text  haskell-utf8-string  hdapsd  hdf5  hdf5-cpp-fortran  hdf5-openmpi  hdf5_18  httrack  hwdetect  hwinfo  icu
                  ifplugd  ijs  incron  interlis-compiler  iptables  ipvsadm  isdn4k-utils  iverilog  jadx  jruby  jython  kakasi  keychain  keyutils  kim4
                  kotlin  lftp  libantlr3c  libdca  libgpg-error  libksba  libmbim  libmikmod  libnet  liboggz  libpaper  libpcap  libpng  libreoffice-fresh
                  libreoffice-fresh-sdk  libreoffice-still  libreoffice-still-sdk  libteam  libtool  libusb-compat  lksctp-tools  lrzip  lsb-release  lvm2
                  lxc  lynis  m4  man-db  maxima  minicom  miniupnpc  mkinitcpio  mlton  mono  moosefs  mtools  multibit  nano  nanoblogger
                  netsurf-buildsystem  nikto  nss  nuget  ode  oidentd  openresolv  openslp  oprofile  os-prober  ozerocdoff  p7zip  pacman  pacmatic  pass
                  pax-utils  paxtest  pcre  pcre2  pdcurses  pdfsam  pflask  pkgbuild-introspection  pkgstats  pm-utils  polipo  ponysay  procmail  quilt
                  radare2  ratpoison  rblcheck  refind-efi  rkhunter  rox  rp-pppoe  rpcbind  rpmextract  sane  sbt  screenfetch  sdcc  sdparm  sgml-common
                  shadow  slib  slmodem-utils  smali  smartmontools  smlnj  snap-confine  source-highlight  speakup-utils  speedtouch  sqlmap  steam  sxhkd
                  systemd  systemd-swap  tablelist  texinfo  tor  translate-toolkit  txt2man  ucblogo  ude  unzip  valabind  vde2  vigra  vnstat  vte-common
                  which  wings3d  wireless-regdb  wv  xbase  xdg-user-dirs  xdg-utils  xdm-archlinux  xe-guest-utilities  xf86-input-vmmouse  xmonad
                  xmonad-contrib  xorg-mkfontdir  xorg-xpr  xosd  xssstate  xz
Optional For    : alsa-tools  gstreamer0.10  hdparm  libkkc  mathomatic  txt2tags  wit

Scimmia · 2017-01-10 18:49:01

slithery wrote:

The gcc-libs package is in base, which is assumed to be installed on all Arch systems. Remove it.

There's no rule about this.

Arch Linux

#1 2017-01-10 16:26:09

PKGBUILD review request: fet-timetabling

#2 2017-01-10 16:55:21

Re: PKGBUILD review request: fet-timetabling

#3 2017-01-10 17:13:45

Re: PKGBUILD review request: fet-timetabling

#4 2017-01-10 17:50:30

Re: PKGBUILD review request: fet-timetabling

#5 2017-01-10 18:05:08

Re: PKGBUILD review request: fet-timetabling

#6 2017-01-10 18:49:01

Re: PKGBUILD review request: fet-timetabling

Board footer