Arch Linux

lorensgwine

Member

Registered: 2017-11-22

Posts: 3

PKGBUILD review request: tc-twitch-git

I wrote PKGBUILD for Tc, The chat client for Twitch. Please check it.

What I should write in license="" if github page says

https://github.com/mccxiv/tc
Copyright (c) 2017 by Andrea Stella adr.stella@gmail.com You may use this source code in any way you like for personal use. You may not distribute binaries, or their equivalent, created using this or significant portions of this source code.

PKGBUILD:

pkgname=tc-twitch-git
_pkgname=tc-twitch
pkgver=10.2.0.r0.ge8ed5df
pkgrel=1
pkgdesc="The chat client for Twitch™"
arch=('any')
url="https://github.com/mccxiv/${_pkgname}"
license=('custom')
provides=($_pkgname)
conflicts=($_pkgname)
makedepends=('git' 'npm')
source=("$pkgname::git+https://github.com/mccxiv/tc.git")
md5sums=('SKIP')

pkgver() {
  cd $pkgname
  git describe --tags --long | sed -r -e 's,^[^0-9]*,,;s,([^-]*-g),r\1,;s,[-_],.,g'
}

build() {
  cd $srcdir/$pkgname
  rm -rf _dist
  rm -rf _build
  mkdir -p _build
  npm install
  npm install 7zip-bin-linux
  node_modules/.bin/webpack
  cp src/tc-renderer/index.html _build/index.html
  cp src/package.json _build/package.json
  npm run dist:linux
}

package() {
  install -d "$pkgdir"/{usr/bin,opt}
  cp -a $srcdir/$pkgname/dist/linux-unpacked $pkgdir/opt/$_pkgname
  ln -s $pkgdit/opt/$_pkgname/Tc $pkgdir/usr/bin/tc-twitch
}

Trilby

Inspector Parrot

Registered: 2011-11-29

Posts: 29,524

Website

Re: PKGBUILD review request: tc-twitch-git

What I should write in license="" if github page says...

See the tip in the wiki which covers this exact situation.  While that text on it's own seems a bit ambiguous, the author specifically labeled that as "LICENSE" (the heading that was over what you quoted) so that removes any ambiguity: this is what the author intended as the license.

Last edited by Trilby (2017-11-22 12:20:40)

---

"UNIX is simple and coherent..." - Dennis Ritchie, "GNU's Not UNIX" -  Richard Stallman

lorensgwine

Member

Registered: 2017-11-22

Posts: 3

Re: PKGBUILD review request: tc-twitch-git

See the tip in the wiki which covers this exact situation.

Thanks!

Updated PKGBILD:

pkgname=tc-twitch-git
_pkgname=tc-twitch
pkgver=10.2.0.r0.ge8ed5df
pkgrel=1
pkgdesc="The chat client for Twitch™"
arch=('any')
url="https://github.com/mccxiv/${_pkgname}"
license=('custom')
provides=($_pkgname)
conflicts=($_pkgname)
makedepends=('git' 'npm')
source=("$pkgname::git+https://github.com/mccxiv/tc.git")
md5sums=('SKIP')

pkgver() {
  cd $pkgname
  git describe --tags --long | sed -r -e 's,^[^0-9]*,,;s,([^-]*-g),r\1,;s,[-_],.,g'
}

build() {
  cd $srcdir/$pkgname
  rm -rf _dist
  rm -rf _build
  mkdir -p _build
  npm install
  npm install 7zip-bin-linux 
  node_modules/.bin/webpack
  cp src/tc-renderer/index.html _build/index.html
  cp src/package.json _build/package.json
  npm run dist:linux
  # license
  sed -n '/### License/,/You may not/p' README.md > LICENSE
}

package() {
  install -d "$pkgdir"/{usr/bin,opt}
  cp -a $srcdir/$pkgname/dist/linux-unpacked $pkgdir/opt/$_pkgname
  ln -s $pkgdit/opt/$_pkgname/Tc $pkgdir/usr/bin/tc-twitch
  install -Dm644 $srcdir/$pkgname/LICENSE "$pkgdir"/usr/share/licenses/$_pkgname/LICENSE
}