You are not logged in.

#1 2018-03-17 21:33:31

therealpsv
Member
Registered: 2018-03-17
Posts: 1

PKGBUILD for wikiquote-movie-fortune - request for review

I've forked the wikiquote-fortune project to a new project called wikiquote-movie-fortune, as the original was primarily designed for and works with television show pages. wikiquote-movie-fortune is modified to work better with movie pages instead. I would like to ask for feedback on the PKGBUILD so I can add this to the AUR.

Here's the repository for the project: https://github.com/TheRealPSV/wikiquote-movie-fortune

And here's the contents of the PKGBUILD:

# Maintainer: Parthiv Vora <psvora94 at gmail dot com>
# Contributor: Mattias Andrée <maandree at member dot fsf dot org>

pkgname=wikiquote-movie-fortune
pkgver=2.0
pkgrel=1
pkgdesc="Generate fortune cookies from Wikiquote for movies"
arch=('any')
url="https://github.com/therealpsv/wikiquote-movie-fortune"
license=('GPL3')
depends=('python' 'wget')
makedepends=('coreutils' 'make' 'texinfo')
source=(https://github.com/TheRealPSV/wikiquote-movie-fortune/releases/download/${pkgver}/${pkgver}.tar.gz)
sha256sums=('c2f83ada0d874f6e314e3aa916a380a75115ec71d775f80657fcd8edfef056a7')


build() {
  cd "${srcdir}"
  make
}


package() {
  cd "${srcdir}"
  make install DESTDIR="${pkgdir}"
}

Last edited by therealpsv (2018-03-17 22:54:54)

Offline

#2 2018-03-18 13:07:36

eschwartz
Fellow
Registered: 2014-08-08
Posts: 4,097

Re: PKGBUILD for wikiquote-movie-fortune - request for review

1) makedepends are unnecessary, these are all in either base or base-devel and should not be listed here.

2) Your source array will download a file called "2.0.tar.gz" which may clash with other PKGBUILDs, if the user has set a shared $SRCDEST. Instead, you should use:

source=("${pkgname}-${pkgver}.tar.gz::${url}/archive/${pkgver}.tar.gz"

AFAICT the separately uploaded "releases/" download doesn't do anything as it is the same as the "Source code (tar.gz)" download. (Except for the PKGBUILD which someone downloading via a PKGBUILD does not care about...)


Managing AUR repos The Right Way -- aurpublish (now a standalone tool)

Offline

#3 2018-03-18 15:25:22

loqs
Member
Registered: 2014-03-06
Posts: 17,192

Re: PKGBUILD for wikiquote-movie-fortune - request for review

Eschwartz wrote:

1) makedepends are unnecessary, these are all in either base or base-devel and should not be listed here.

PKGBUILD#makedepends  Is the note incorrect and should be changed to both base and base-devel?

Offline

#4 2018-03-18 15:29:52

eschwartz
Fellow
Registered: 2014-08-08
Posts: 4,097

Re: PKGBUILD for wikiquote-movie-fortune - request for review

Well, they are all in base-devel, really. I fall on the side of the bikeshed that says base is also assumed installed. tongue

I mean, coreutils is not in base-devel, but on the other hand makepkg itself depends on coreutils (as does util-linux which is in base-devel) so it is sort of impossible to not have...


Managing AUR repos The Right Way -- aurpublish (now a standalone tool)

Offline

Board footer

Powered by FluxBB