Terminator classname

Frat_Papi · 2018-08-28 21:29:12

I recently had a problem fixed for me on this forum so I thought I'd throw one more bug that I haven't seemed to fix for months. I use Terminator as a terminal emulator and I have been trying to setup scratchpads in i3 for sometime, the problem is whenever I initialize a terminal with

 [sam@ArchLinux i3]$ terminator -c "test"

and try to move it to a scratchpad

 for_window [class="test"] move scratchpad

the window stays put. I xproped the window and I get this

 WM_CLASS(STRING) = "terminator", "Terminator"

which I means i'm guessing the class name doesn't change, anybody have any suggestions on what I should do? Thank you

Last edited by Frat_Papi (2018-08-28 21:30:14)

Trilby · 2018-08-28 21:46:37

I just installed Terminator to check this out - I've seen many user errors in misunderstanding the various window properties that are frequently all just call "classname" - but I confirmed there does seem to be an issue with Terminator or it's manual page. The '-c' flag indeed does not have any affect on any window property.

I may try to take a look at the code for it, but so far this looks like it may be a Terminator bug.

EDIT: Lines 86 and 87 in /terminatorlib/window.py are commented out in the source code, and these are what set the classname specified on the command line to the window. So it would seem this ability was deliberately removed, though I see no reason why it should have been, and the man page has not been updated to reflect the change. So it would seem to be an upstream bug of either accidentally commenting out those two lines, or of failing to adjust the man page.

Last edited by Trilby (2018-08-28 21:54:21)

Frat_Papi · 2018-08-28 21:58:35

Thank you I thought that may have been the case.

Frat_Papi · 2018-08-28 22:13:11

So I edited the python code in the package, I was wondering if you could help me out with one more thing and explain to me how you would go about replacing this modified package in pacman, thank you.

Trilby · 2018-08-28 23:29:55

Assuming you used the ABS to retrieve the source code that you edited, you should be able to just run `makepkg -esi`.

But also keep in mind there must have been a reason those lines were commented out upstream - I don't have any idea what that could have been though.

Last edited by Trilby (2018-08-28 23:31:14)

Frat_Papi · 2018-08-29 15:49:43

Will doing this overwrite the pacman Terminator install, or will I have to use the local binary?

Trilby · 2018-08-29 15:57:04

Yes, using ABS allows you to modify the package and install your modified version in place of the one from the repos. But your new version will also be a "pacman one" as it will be managed by pacman.

The one thing to keep in mind is that when Terminator in the repos is updated, the update will replace your version until you patch and rebuild again. But you should really be taking this issue upstream to figure out why they comment out those lines and what the best long term solution will be.

Frat_Papi · 2018-08-29 16:10:14

I'm sorry for the 21 questions, but I copy'd the Terminator package from var/cache/pacman unpacked it, then uncommented the lines, when I tried to run makepkg it said the file doesnt exist. is this the usually workflow for editing a abs

Trilby · 2018-08-29 16:45:08

No, this is.

Arch Linux

#1 2018-08-28 21:29:12

Terminator classname

#2 2018-08-28 21:46:37

Re: Terminator classname

#3 2018-08-28 21:58:35

Re: Terminator classname

#4 2018-08-28 22:13:11

Re: Terminator classname

#5 2018-08-28 23:29:55

Re: Terminator classname

#6 2018-08-29 15:49:43

Re: Terminator classname

#7 2018-08-29 15:57:04

Re: Terminator classname

#8 2018-08-29 16:10:14

Re: Terminator classname

#9 2018-08-29 16:45:08

Re: Terminator classname

Board footer