You are not logged in.

#1 2018-09-29 21:48:04

regid
Member
Registered: 2016-06-06
Posts: 83

mv static file to doc/lprng by an install script or at build time?

Can there be good reasons not to apply the following patch to the lprng AUR package? These 3 files are static. They were not created while installing the pkg. As far as I can say, the whole issue is negligible. It just looks to me a bit cleaner not to move them by an install script.
The maintainer did hasn't answered that, which is why I am asking here.

diff --git a/PKGBUILD b/PKGBUILD
index [`b500855`](https://aur.archlinux.org/cgit/aur.git/commit/?h=lprng&id=b500855)..69b38d4 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -70,6 +70,10 @@ package() {
          "${pkgdir}/usr/share/doc/lprng/"
      install -D -m 0644 "${srcdir}/lpd.perms" \
          "${pkgdir}/usr/share/doc/lprng/"
+     mv "${pkgdir}/etc/lprng/printcap.sample" \
+        "${pkgdir}/etc/lprng/lpd/lpd.conf.sample" \
+        "${pkgdir}/etc/lprng/lpd/lpd.perms.sample" \
+         "${pkgdir}/usr/share/doc/lprng/"
 }

 md5sums=('5901bed95e61d2bea3ba3056056af432'
@@ -82,4 +86,4 @@ md5sums=('5901bed95e61d2bea3ba3056056af432'
          '1768d2f81d6d14c22686293ca60528c1'
          '3ef9f91dc0de273da1f5f1b20d49cd17'
          '3f861c75c2d68c0e45b4095ab39ba1c8'
-         '0f21b173ae0f16d225b4519e0f3238ff')
+         'd3d4423db63a7242c3f68b61e8346fdc')


diff --git a/lprng.install b/lprng.install
index [`8039b18`](https://aur.archlinux.org/cgit/aur.git/commit/?h=lprng&id=8039b18)..5b6a80b 100755
--- a/lprng.install
+++ b/lprng.install
@@ -1,5 +1,3 @@ post_install() {
-  mv /etc/lprng/printcap.sample /etc/lprng/lpd/lpd.conf.sample \
-    /etc/lprng/lpd/lpd.perms.sample /usr/share/doc/lprng
   echo 'See /usr/share/doc/lprng/README to configure'
 }
 

Last edited by regid (2018-09-30 14:54:21)

Offline

#2 2018-09-30 02:57:44

eschwartz
Trusted User/Bug Wrangler
Registered: 2014-08-08
Posts: 2,523

Re: mv static file to doc/lprng by an install script or at build time?

I don't see where the maintainer said anything about this install script, but it definitely breaks the rules to do it in the install script.

It is completely and utterly wrong to lie to pacman and create untracked files and delete files which pacman thinks should exist, for this extremely pointless reason.

Putting on my Trusted User "I'm an AUR policeman" hat, this package needs to switch to using the package function properly.


Managing AUR repos The Right Way -- aurpublish (now a standalone tool)

Offline

#3 2018-09-30 14:50:33

regid
Member
Registered: 2016-06-06
Posts: 83

Re: mv static file to doc/lprng by an install script or at build time?

@Eschwartz, you might want to see my reply to your comment about the aur support for markdown at https://bbs.archlinux.org/viewtopic.php … 8#p1810438.

Offline

Board footer

Powered by FluxBB