You are not logged in.

#1 2018-10-18 11:39:34

figue
Member
Registered: 2007-12-16
Posts: 59

Usage of msg2 in PKGBUILD

Regarding this topic on the maillist:
https://lists.archlinux.org/pipermail/a … 34364.html

I've reviewed my packages because I use msg2 in a few... But, why in that thread msg2 is defined as "it's makepkg internal", but, for instance, in the official kernel package msg2 is widely used:

[figue:~]↥ $ curl -s 'https://git.archlinux.org/svntogit/packages.git/plain/trunk/PKGBUILD?h=packages/linux&id=655d7b7738cb46d05dd260c4d88bbde99d2d7829' | grep msg2
  msg2 "Setting version..."
    msg2 "Applying patch $src..."
  msg2 "Setting config..."
  msg2 "Prepared %s version %s" "$pkgbase" "$(<../version)"
  msg2 "Installing boot image..."
  msg2 "Installing modules..."
  msg2 "Installing hooks..."
  msg2 "Fixing permissions..."
  msg2 "Installing build files..."
  msg2 "Installing headers..."
  msg2 "Installing KConfig files..."
  msg2 "Removing unneeded architectures..."
  msg2 "Removing documentation..."
  msg2 "Removing broken symlinks..."
  msg2 "Removing loose objects..."
  msg2 "Stripping build tools..."
  msg2 "Adding symlink..."
  msg2 "Fixing permissions..."
  msg2 "Installing documentation..."
  msg2 "Removing doctrees..."
  msg2 "Moving HTML docs..."
  msg2 "Adding symlink..."
  msg2 "Fixing permissions..."

Has this any sense?

Offline

#2 2018-10-18 14:08:03

Trilby
Inspector Parrot
Registered: 2011-11-29
Posts: 29,442
Website

Re: Usage of msg2 in PKGBUILD

First the advice against using msg2 is out of context.  Previous messages in that thread note that there is no rule against it.  Eschwartz, in his own words, just thinks it is "messy".  This also was in reference to a particular potentially needless use of it where it had no purpose, as Doug (Scimmia) highlighted in a specific PKGBUILD it was being used "for no reason".

However Eschwartz also commented that he has yet to come across a justified use of it - so with respect to that comment it is worth noting that all the "msg2" use in the kernel PKGBUILD were just *added* recently, it wasn't used at all in 4.17.1.

Last edited by Trilby (2018-10-18 14:11:56)


"UNIX is simple and coherent..." - Dennis Ritchie, "GNU's Not UNIX" -  Richard Stallman

Offline

#3 2018-10-18 14:10:17

eschwartz
Fellow
Registered: 2014-08-08
Posts: 4,097

Re: Usage of msg2 in PKGBUILD

Because we're incredibly inconsistent with that "rule", as well, doesn't mean it's right.

The repos are also still full of unquoted $srcdir/$pkgdir, we've had Developers running sudo inside the PKGBUILD with the rationale that "I don't use makechrootpkg so I will just modify the operating system so my testsuite passes", and more.

It's simply not true to say that official PKGBUILDs are a paragon of "doing the right thing".

Last edited by eschwartz (2018-10-18 14:10:47)


Managing AUR repos The Right Way -- aurpublish (now a standalone tool)

Offline

#4 2018-10-18 21:00:22

figue
Member
Registered: 2007-12-16
Posts: 59

Re: Usage of msg2 in PKGBUILD

Ok, thank you both

Offline

Board footer

Powered by FluxBB