You are not logged in.
Pages: 1
I created pkgbuild and want to add it to AUR
# Maintainer: Peter Kabin <peterkabin@gmail.com>
pkgname=havoc-git
pkgver=r8.2f2b38e
pkgrel=1
pkgdesc="terminal emulator for wayland based on libtsm"
arch=('i686' 'x86_64' 'ARM')
url="https://github.com/ii8/havoc"
license=('MIT')
depends=('libtsm-patched-git' 'glibc' 'libxkbcommon' 'wayland')
makedepends=('git' 'gcc')
provides=("havoc-git")
source=('git+git://github.com/ii8/havoc')
md5sums=('SKIP')
pkgver() {
cd "$srcdir/havoc"
printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)"
}
build() {
cd "$srcdir/havoc"
make
}
package() {
cd "$srcdir/havoc"
mkdir "$pkgdir/usr/"
mkdir "$pkgdir/usr/bin/"
mkdir "$pkgdir/etc"
mkdir "$pkgdir/etc/havoc"
cp "$srcdir/havoc/havoc" "$pkgdir/usr/bin/"
cp "$srcdir/havoc/havoc.cfg" "$pkgdir/etc/havoc"
}
Last edited by KOTIK (2019-02-03 20:43:12)
Offline
Doesn't look too bad.
Having gcc in makedepends is redundant, it's part of the base-devel group which is assumed to be installed when building packages.
Your entire package function can be replaced by2 lines. Read man install.
You aren't including the license correctly. Please read this.
Offline
Welcome to the arch linux forums KOTIK.
makedepends=('git' 'gcc')
gcc is in the base-devel group which is expected to always be installed before makepkg is executed.
provides=("havoc-git")
Packages always provide themselves making this line redundant.
license=('MIT')
See PKGBUILD#license
mkdir "$pkgdir/usr/"
mkdir "$pkgdir/usr/bin/"
mkdir "$pkgdir/etc"
mkdir "$pkgdir/etc/havoc"
I would suggest using a single install invocation to perform this action similarly I would replace the cp lines below that block with the use of install.
From the upstream Makefile
LDFLAGS=-lrt -lm -lutil -lwayland-client -ltsm -lxkbcommon
This overwrites the LDFLAGS makepkg set which prevents FULL RELRO.
One possible workaround.
make LDFLAGS="$LDFLAGS -lrt -lm -lutil -lwayland-client -ltsm -lxkbcommon"
Offline
Pages: 1