You are not logged in.

#1 2019-02-08 14:46:22

ecloud
Member
Registered: 2010-09-15
Posts: 19

review request: PKGBUILD for md4c

I'm trying to follow the instructions on https://wiki.archlinux.org/index.php/Ar … g_packages and having trouble with the git setup. 

$ git clone ssh://aur@aur.archlinux.org/md4c-git.git
Cloning into 'md4c-git'...
aur@aur.archlinux.org: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

It seems odd to clone something that doesn't exist anyway.

So here's the PKGBUILD for md4c-git; I hope somebody can get it into the repo or help me figure out why I can't.

I'll make a proper md4c pkgbuild as soon as the next release is ready (which should be soon); upstream just now made it possible to build md4c as a shared library rather than static, so that's what should be in the package.

# Maintainer: Shawn Rutledge <s@ecloud.org>

_gitname=md4c
pkgname=md4c-git
pkgver=release.0.2.7.r14.gbfca107
pkgrel=1
pkgdesc="A Markdown parser implementation in C"
arch=('i686' 'x86_64')
url='https://github.com/mity/md4c'
license=('MIT')
depends=()
makedepends=('git')
conflicts=('md4c')
source=("git+https://github.com/mity/$_gitname.git")
sha256sums=('SKIP')

pkgver() {
  cd $_gitname
  git describe --long --always | sed 's/\([^-]*-g\)/r\1/;s/-/./g'
}

prepare() {
  mkdir -p build
}

build() {
  cd build
  cmake ../$_gitname \
    -DCMAKE_INSTALL_PREFIX=/usr \
    -DCMAKE_INSTALL_LIBDIR=/usr/lib \
    -DCMAKE_BUILD_TYPE=Release
  make
}

package() {
  cd build
  make DESTDIR="$pkgdir" install
}

Offline

#2 2019-02-08 19:39:18

eschwartz
Trusted User/Bug Wrangler
Registered: 2014-08-08
Posts: 2,853

Re: review request: PKGBUILD for md4c

ecloud wrote:

I'm trying to follow the instructions on https://wiki.archlinux.org/index.php/Ar … g_packages and having trouble with the git setup. 

$ git clone ssh://aur@aur.archlinux.org/md4c-git.git
Cloning into 'md4c-git'...
aur@aur.archlinux.org: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

It seems odd to clone something that doesn't exist anyway.

You used ssh to clone, which means you need an ssh key to do so. Did you add your SSH key to your AUR profile as instructed? https://wiki.archlinux.org/index.php/Ar … entication

...

You are of course free to git init a new repository, then add the necessary remote once you're ready, but it is generally "easier" to clone the empty repository first, which is why it is recommended.


Managing AUR repos The Right Way -- aurpublish (now a standalone tool)

Offline

#3 2019-02-08 20:13:51

Trilby
Inspector Parrot
Registered: 2011-11-29
Posts: 21,903
Website

Re: review request: PKGBUILD for md4c

Please also fix the dependencies.  If there really are no dependencies, remove the empty variable (but I doubt there really are none).

Also cmake, at least, should be a makedepends.


"UNIX is simple and coherent..." - Dennis Ritchie, "GNU's Not UNIX" -  Richard Stallman

Offline

#4 2019-02-28 08:19:05

ecloud
Member
Registered: 2010-09-15
Posts: 19

Re: review request: PKGBUILD for md4c

Yes I didn't add the public ssh key to the aur profile on the web site.  Fixed that.

The page also says "You should create a new key pair rather than use an existing one."  But I'm using gpg with a yubikey to store my private key (a key that I've had signed at a signing party too), so the result is I end up using the same key for everything (gpg, Qt git, github, ssh to various machines, and now AUR); I hope that's OK.  The yubikey doesn't support storing subkeys AFAIK, and I'm not clear on how to get ssh to use different subkeys anyway; but I think using that key is more secure (and proves my identity in a more trustworthy way) than leaving various single-use unsigned ssh private keys lying around on my hard drives, right?  But if I ever had to revoke the key, it would be a pain.

md4c really has no dependencies AFAICT, just a c compiler and libc.  Added cmake to makedepends.  And managed to push successfully.

Offline

Board footer

Powered by FluxBB