You are not logged in.

#1 2019-05-05 11:34:44

samhh
Member
Registered: 2017-12-25
Posts: 13

[SOLVED] PKGBUILD review request

Hi there! First time intending to contribute a package to the AUR. Here's the PKGBUILD:

# Maintainer: Sam A. Horvath-Hunt <contact at samhh dot com>

pkgname=bukubrow-host
_pkgname=bukubrow
pkgver=4.0.0
pkgrel=1
pkgdesc="Host application for the Bukubrow WebExtension"
url="https://github.com/SamHH/bukubrow-host/"
makedepends=('cargo')
arch=('any')
license=('GPL3')
source=("$pkgname-$pkgver.tar.gz::https://github.com/samhh/$pkgname/archive/v$pkgver.tar.gz")
md5sums=('8ef066f0a53038ae84b39ae9ebefbe25')

build() {
	cd "$pkgname-$pkgver"
	cargo build --release --locked
}

package() {
	cd "$pkgname-$pkgver"
	install -Dm 755 "target/release/$_pkgname" "$pkgdir/usr/bin/$_pkgname"
}

Review appreciated :-) Cheers!

Last edited by samhh (2019-05-05 14:06:50)

Offline

#2 2019-05-05 12:58:16

Trilby
Inspector Parrot
Registered: 2011-11-29
Posts: 22,375
Website

Re: [SOLVED] PKGBUILD review request

I haven't tested it, but it looks pretty good except for 1 error I can see in arch - that should not be any as this is compiled code.  List the architectures you've tested it on or are sure it works on.

Last edited by Trilby (2019-05-05 12:58:33)


"UNIX is simple and coherent..." - Dennis Ritchie, "GNU's Not UNIX" -  Richard Stallman

Offline

#3 2019-05-05 13:55:57

samhh
Member
Registered: 2017-12-25
Posts: 13

Re: [SOLVED] PKGBUILD review request

Thanks for taking a look!

I've updated it to only include the arch I'm confident it will work on, and I've also changed the package name to make a bit more sense, following browserpass's approach.

Offline

Board footer

Powered by FluxBB