You are not logged in.

#1 2019-10-03 20:08:18

wombatfever
Member
Registered: 2018-05-04
Posts: 2

PKGBUILD review request (rattlesnakeos-stack-git)

Hello,

Was hoping I could get some feedback for my PKGBUILD for the rattlesnakeOS-stack package. Thanks in advance!

pkgname=rattlesnakeos-stack-git
pkgver=10.0.0.beta.2.r0.g1aa32df
pkgrel=1
pkgdesc="Security focused Android OS in the cloud with OTA updates. "
arch=('i686' 'x86_64')
license=('MIT')
depends=('aws-cli')
makedepends=('go' 'git')
url='https://github.com/dan-v/rattlesnakeos-stack'
source=("git+${url}")
md5sums=('SKIP')

build() {
  cd "${srcdir}/${pkgname%-git}"
  export GOPATH="${srcdir}/gopath"
  make tools
  make build
}

package() {
  cd "${srcdir}/${pkgname%-git}"
  export GOPATH="${srcdir}/gopath"
  install -Dm755 "${pkgname%-git}" "${pkgdir}"/usr/bin/"${pkgname%-git}"
  install -Dm644 LICENSE "${pkgdir}/usr/share/licenses/"${pkgname%-git}"/LICENSE"
  chmod -R 644 "$GOPATH"
}

pkgver() {
  cd "${pkgname%-git}"
  git describe --long --tags | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g'
}

Offline

#2 2019-10-04 09:58:01

Lone_Wolf
Member
From: Netherlands, Europe
Registered: 2005-10-04
Posts: 7,469

Re: PKGBUILD review request (rattlesnakeos-stack-git)

read https://wiki.archlinux.org/index.php/Go … guidelines

The sourecode does have go.mod & go.sum files, so the section about "modern Go Projects" seems applicable.

Have you tested whether this package works on i686 ?
If not, please remove i686 from arch= array.


Multi-init booting with apg Openrc and systemd coexisting
Automounting : not needed, i prefer pmount
Aur helpers : makepkg + my own local repo === rarely need them

Offline

#3 2019-10-04 15:18:19

wombatfever
Member
Registered: 2018-05-04
Posts: 2

Re: PKGBUILD review request (rattlesnakeos-stack-git)

Thanks for the feedback. Yes, seems like like I can replace `make tools; make` with `go build .` And regarding the arch array, indeed, I have not tested it on i686. Thanks again!

Offline

Board footer

Powered by FluxBB