You are not logged in.

#1 2020-04-15 07:45:46

gjasso
Member
From: Bonn, Germany
Registered: 2011-09-08
Posts: 28

PKGBUILD review request: python-remarkable-mouse

Hi, this is my first PKGBUILD and I would appreciate if someone could provide some feedback before I submit it to the AUR. 

Thanks in advance!

P.S. In the submission guidelines it is recommended to disguise one's e-mail address; should one then use a fake one?

# Maintainer: Gustavo Jasso <flying at monkey dot net>
pkgname='python-remarkable-mouse'
pkgver=5
pkgrel=1
_name=${pkgname#python-}

pkgdesc="Python scripts to use reMarkable tablet as mouse input."

arch=('any')

url="https://pypi.org/project/remarkable-mouse/"

license=('GPLv3')

depends=('python-paramiko' 'python-libevdev' 'python-pynput' 'python-screeninfo')

makedepends=('python-setuptools')

source=("https://files.pythonhosted.org/packages/source/${_name::1}/$_name/$_name-$pkgver.tar.gz")

md5sums=('b46030d96d49e7e13baefec0360f50af')

build() {
    cd "$srcdir/$_name-$pkgver"
    python setup.py build
}

package() {
    cd "$srcdir/$_name-$pkgver"
    python setup.py install --root="$pkgdir" --optimize=1 --skip-build
}

Offline

#2 2020-04-15 11:25:49

Lone_Wolf
Member
From: Netherlands, Europe
Registered: 2005-10-04
Posts: 8,086

Re: PKGBUILD review request: python-remarkable-mouse

P.S. In the submission guidelines it is recommended to disguise one's e-mail address; should one then use a fake one?

The disguise is to make it harder for bots to send spam messages to the email address, it's questionable how much it protects though.
If you're worried about spam, use a separate email address for PKGBUILDs .
The maintainer email address is intended to be used when there are issues with the package and people need to contact you directly.
Never use a fake email address in a PKGBUILD .

Your license field is wrong, see https://wiki.archlinux.org/index.php/PKGBUILD#license

I've checked the url field and think https://github.com/evidlo/remarkable_mouse is a better choice .


Multi-init booting with apg Openrc and systemd coexisting
Automounting : not needed, i prefer pmount
Aur helpers : makepkg + my own local repo === rarely need them

Offline

#3 2020-04-15 11:36:52

gjasso
Member
From: Bonn, Germany
Registered: 2011-09-08
Posts: 28

Re: PKGBUILD review request: python-remarkable-mouse

Thank you for the feedback; I changed the license to GPL3 now.

About the URL, the one you suggests seems to be out-of-date: the last commit was on 15.07.2019 and the version.py file reports version 4.1. The one I included was updated on 26.02.2020 and it reports version 5.

I agree that it would be better to link directly to the GitHub repository than to pypi.org. I will e-mail the author and see if he is willing to update the GitHub repository before submitting to the AUR.

Re: P.S. Noted.

Last edited by gjasso (2020-04-15 11:40:20)

Offline

#4 2020-04-15 13:58:22

Trilby
Inspector Parrot
Registered: 2011-11-29
Posts: 23,479
Website

Re: PKGBUILD review request: python-remarkable-mouse

While harmless, doublespacing all the variables is odd.  It's odd enough that opening the PKGBUILD and seeing that is rather abruptly jarring.


"UNIX is simple and coherent..." - Dennis Ritchie, "GNU's Not UNIX" -  Richard Stallman

Online

#5 2020-04-15 14:02:53

gjasso
Member
From: Bonn, Germany
Registered: 2011-09-08
Posts: 28

Re: PKGBUILD review request: python-remarkable-mouse

@Trilby I actually agree; I spaced them before posting as I thought it might be easier to proofread.

Offline

#6 2020-04-15 14:07:03

Scimmia
Bug Wrangler
Registered: 2012-09-01
Posts: 7,620

Re: PKGBUILD review request: python-remarkable-mouse

The pkgdesc makes it sound like this is a utility, not a library. If that's the case, you don't need the 'python-' prefix in the pkgname. That would make _name unnecessary.

Online

#7 2020-04-15 14:09:28

gjasso
Member
From: Bonn, Germany
Registered: 2011-09-08
Posts: 28

Re: PKGBUILD review request: python-remarkable-mouse

@Scimmia You are right, this is really not a library. I will change the name to remarkable-mouse.

Offline

#8 2020-04-19 06:23:14

eschwartz
Trusted User/Bug Wrangler
Registered: 2014-08-08
Posts: 3,321

Re: PKGBUILD review request: python-remarkable-mouse

The setup.py from github includes this:

    entry_points={
        'console_scripts': [
            'remarkable-mouse = remarkable_mouse.remarkable_mouse:main',
            'remouse = remarkable_mouse.remarkable_mouse:main'
        ]
    },

This means that it will create scripts in /usr/bin/ for "remarkable-mouse" and "remouse", which import pkg_resources. Therefore python-setuptools must be a depends, not merely a makedepends.

See https://wiki.archlinux.org/index.php/Py … setuptools


Managing AUR repos The Right Way -- aurpublish (now a standalone tool)

Offline

#9 2020-04-19 06:54:31

gjasso
Member
From: Bonn, Germany
Registered: 2011-09-08
Posts: 28

Re: PKGBUILD review request: python-remarkable-mouse

@eschwartz Thanks for noticing. I have updated the PKGBUILD accordingly.

Offline

#10 2020-04-19 07:00:31

eschwartz
Trusted User/Bug Wrangler
Registered: 2014-08-08
Posts: 3,321

Re: PKGBUILD review request: python-remarkable-mouse

Thanks.

Looking at your package: https://aur.archlinux.org/cgit/aur.git/ … able-mouse

You can remove python-setuptools from makedepends now that it is in the global depends. smile

...

Also since I notice you initially forgot to update the .SRCINFO when adding this dependency, you might wish to investigate the utility mentioned in my forum signature (which I have taken advantage of being a Trusted User to move to [community], so you can 'pacman -S aurpublish' to get it. big_smile)


Managing AUR repos The Right Way -- aurpublish (now a standalone tool)

Offline

#11 2020-04-19 07:13:59

gjasso
Member
From: Bonn, Germany
Registered: 2011-09-08
Posts: 28

Re: PKGBUILD review request: python-remarkable-mouse

@eschwartz Thanks again for the comments; I updated the package again. I installed aurpublish, it will definitely be very helpful for me.

Offline

Board footer

Powered by FluxBB