You are not logged in.

#1 2020-12-27 19:11:51

Crion
Member
Registered: 2020-12-27
Posts: 6

PKGBUILD review request

Hi All,

It's been a long time since I've used arch. I put together a PKGBUILD for a piece of code I wrote and would appreciate if someone can look over it and see what I messed up.

The file is here: https://github.com/LBCrion/sfwbar/blob/ … g/PKGBUILD

Offline

#2 2020-12-27 23:02:00

eschwartz
Trusted User/Bug Wrangler
Registered: 2014-08-08
Posts: 4,097

Re: PKGBUILD review request

Looks ok, though you could use source=("$pkgname-$pkgver.tar.gz::$url/archive/v$pkgver.tar.gz")

Also GPL indicates GPL-2-or-later, I think you want license=('GPL3').

These are not actually used by your package: --auto-features=enabled --wrap-mode=nodownload


Managing AUR repos The Right Way -- aurpublish (now a standalone tool)

Offline

#3 2020-12-28 12:09:18

Crion
Member
Registered: 2020-12-27
Posts: 6

Re: PKGBUILD review request

Thank you eschwartz. I incorporated your comments into the PKGBUILD.

Offline

#4 2020-12-28 19:17:04

saf1
Member
From: morocco
Registered: 2011-04-04
Posts: 14

Re: PKGBUILD review request

also use

cd "$pkgname-$pkgver"

Last edited by saf1 (2020-12-28 19:17:19)

Offline

#5 2020-12-28 19:35:21

Crion
Member
Registered: 2020-12-27
Posts: 6

Re: PKGBUILD review request

Thanks saf1. Updated this as well.

Offline

Board footer

Powered by FluxBB