You are not logged in.

#1 2021-01-03 20:31:25

draptik
Member
Registered: 2012-07-13
Posts: 8

PKGBUILD review request: mobsh-bin

Hi,

first attempt at creating a PKBUILD. Could somebody take a look and tell me if I'm doing anything wrong?

https://github.com/draptik/arch-package … n/PKGBUILD

README: https://github.com/draptik/arch-package … /README.md

Thanks

Last edited by draptik (2021-01-03 20:33:07)

Offline

#2 2021-01-03 21:16:23

Slithery
Forum Moderator
From: Norfolk, UK
Registered: 2013-12-01
Posts: 4,075

Re: PKGBUILD review request: mobsh-bin

The description shouldn't contain the package name.

Do you have a good reason for creating a -bin package instead of one which builds from source?
https://wiki.archlinux.org/index.php/Go … guidelines


No, it didn't "fix" anything. It just shifted the brokeness one space to the right. - jasonwryan
Closing -- for deletion; Banning -- for muppetry. - jasonwryan

aur - dotfiles

Offline

#3 2021-01-03 21:27:48

draptik
Member
Registered: 2012-07-13
Posts: 8

Re: PKGBUILD review request: mobsh-bin

thanks for the feedback @slithery !

Concerning your question why I create a "-bin" package: Since I've never created a PKGBUILD before I figured it would be easiest for a beginner like myself to use the provided binary from upstream. Building from source might just be my next step ;-)

Offline

#4 2021-01-04 04:43:33

eschwartz
Trusted User/Bug Wrangler
Registered: 2014-08-08
Posts: 3,876

Re: PKGBUILD review request: mobsh-bin

source=("$url/releases/download/v${pkgver}/mob_v${pkgver}_linux_amd64.tar.gz"
        "https://raw.githubusercontent.com/remotemobprogramming/mob/master/LICENSE")

The first source is only for x86_64, so it should be in source_x86_64=().
The second source needs to get a unique name or else any of thousands of packages might also try to download files named "LICENSE". Usually one would wish the LICENSE file to be shipped in the binary tarball, consider opening an upstream bug.

source_x86_64=("$url/releases/download/v${pkgver}/mob_v${pkgver}_linux_amd64.tar.gz")
source=("${pkgname}-${pkgver}-LICENSE::${url}/raw/${pkgver}/LICENSE")

Last edited by eschwartz (2021-01-04 04:43:54)


Managing AUR repos The Right Way -- aurpublish (now a standalone tool)

Offline

#5 2021-01-04 10:19:14

draptik
Member
Registered: 2012-07-13
Posts: 8

Re: PKGBUILD review request: mobsh-bin

@eschwartz Thanks for the pointers: Just published another release!
I'll see if can get upstream to add the license to the binary tarball.

Offline

Board footer

Powered by FluxBB