You are not logged in.

#1 2021-05-23 07:32:29

PhotonX
Member
From: Munich
Registered: 2008-08-10
Posts: 522

[Request] Please move shutter to the official repo

Hi guys,

I am the maintainer of Shutter's AUR package and have been involved in Shutter's maintainance upstream a little bit. Some months ago a new developer picked up Shutter and yesterday there was a long awaited new release which dropped all of the outdated gtk2 dependencies. Now Shutter only depends on the following AUR packages, which are, however, not outdated:

https://aur.archlinux.org/packages/perl-json-maybexs/ --  last upstream release was in December 2020
https://aur.archlinux.org/packages/perl … airotypes/ -- last upstream release was in February 2021
https://aur.archlinux.org/packages/perl … w-shutter/ -- basically just a more recent version of perl-gtk3-imageview which is already in community/ and requires an update

optional: https://aur.archlinux.org/packages/perl … e-gyazo-b/ -- last release was in June 2020 (only required for one of the image hosting upload plugins)
optional: https://aur.archlinux.org/packages/gnome-web-photo/ -- very outdated (only required for website capture)

Would be great if some TU could take care of Shutter and bring it back to community/! If there are any problems which need to be figured out upstream, please let me know.

Greetings,
PhotonX


Desktop: http://www.sysprofile.de/id15562, Arch Linux    |    Notebook: Thinkpad X200 Tablet, Manjaro

The very worst thing you can do with free software is to download it, see that it doesn't work for some reason, leave it, and tell your friends that it doesn't work.  -  Tuomas Lukka

Offline

#2 2021-05-23 11:33:08

Muflone
Trusted User (TU)
From: Italy
Registered: 2013-10-08
Posts: 87
Website

Re: [Request] Please move shutter to the official repo

Hi

I'll update the perl-gtk3-imageview package ASAP but please don't publish duplicated packages in the AUR (read the AUR submission guidelines).

I'll take a try to shutter, thank you for pointing this update

Last edited by Muflone (2021-05-23 11:33:31)

Offline

#3 2021-05-23 11:38:48

PhotonX
Member
From: Munich
Registered: 2008-08-10
Posts: 522

Re: [Request] Please move shutter to the official repo

I am aware that the perl-gtk3-imageview-shutter package is not the best solution, I reported perl-gtk3-imageview as out of date two weeks ago and didn't know what else I could do in this situation. Sorry for the clumsy solution I came up with... Please let me know when perl-gtk3-imageview is updated so I can submit a deletion request for perl-gtk3-imageview-shutter!

edit: I figured, if there are older versions and also -git and other development versions of some packages in the AUR which are not considered duplicates, a newer version might also have its right to exist, at least temporarily.

Last edited by PhotonX (2021-05-23 11:43:14)


Desktop: http://www.sysprofile.de/id15562, Arch Linux    |    Notebook: Thinkpad X200 Tablet, Manjaro

The very worst thing you can do with free software is to download it, see that it doesn't work for some reason, leave it, and tell your friends that it doesn't work.  -  Tuomas Lukka

Offline

#4 2021-05-23 12:24:31

Muflone
Trusted User (TU)
From: Italy
Registered: 2013-10-08
Posts: 87
Website

Re: [Request] Please move shutter to the official repo

PhotonX wrote:

edit: I figured, if there are older versions and also -git and other development versions of some packages in the AUR which are not considered duplicates, a newer version might also have its right to exist, at least temporarily.

https://wiki.archlinux.org/title/AUR_su … submission

Offline

#5 2021-05-23 12:33:18

PhotonX
Member
From: Munich
Registered: 2008-08-10
Posts: 522

Re: [Request] Please move shutter to the official repo

Well, one could argue that

Exception to this strict rule may only be packages having extra features enabled and/or patches in comparison to the official ones. In such an occasion the pkgname should be different to express that difference.

applies in this case, as the newer versions of perl-gtk3-imageview include extra features that are necessary to run Shutter. smile But I think, I got the idea that I should take the package down asap, just waiting for the perl-gtk3-imageview update!


Desktop: http://www.sysprofile.de/id15562, Arch Linux    |    Notebook: Thinkpad X200 Tablet, Manjaro

The very worst thing you can do with free software is to download it, see that it doesn't work for some reason, leave it, and tell your friends that it doesn't work.  -  Tuomas Lukka

Offline

#6 2021-05-23 13:00:14

Muflone
Trusted User (TU)
From: Italy
Registered: 2013-10-08
Posts: 87
Website

Re: [Request] Please move shutter to the official repo

PhotonX wrote:

Well, one could argue that

Exception to this strict rule may only be packages having extra features enabled and/or patches in comparison to the official ones. In such an occasion the pkgname should be different to express that difference.

applies in this case, as the newer versions of perl-gtk3-imageview include extra features that are necessary to run Shutter. smile


It doesn't, perl-gtk3-imageview-shutter is a mere newer version for perl-gtk3-imageview, not a patched package to gain extra features. Please don't submit again newer versions for packages already present in the official repository.

Offline

#7 2021-05-23 17:59:05

PhotonX
Member
From: Munich
Registered: 2008-08-10
Posts: 522

Re: [Request] Please move shutter to the official repo

Sure, I won't!


Desktop: http://www.sysprofile.de/id15562, Arch Linux    |    Notebook: Thinkpad X200 Tablet, Manjaro

The very worst thing you can do with free software is to download it, see that it doesn't work for some reason, leave it, and tell your friends that it doesn't work.  -  Tuomas Lukka

Offline

#8 2021-05-24 23:16:59

Muflone
Trusted User (TU)
From: Italy
Registered: 2013-10-08
Posts: 87
Website

Re: [Request] Please move shutter to the official repo

perl-gtk3-imageview 9-1 is in the staging repository
https://archlinux.org/packages/communit … imageview/

After the perl rebuild is complete, it will be moved in the community repository

Offline

#9 2021-05-25 05:10:29

PhotonX
Member
From: Munich
Registered: 2008-08-10
Posts: 522

Re: [Request] Please move shutter to the official repo

Great, thanks! I have updated perl-gtk3-imageview-shutter to provide perl-gtk3-imageview=9, as well as shutter and shutter-git to depend on perl-gtk3-imageview>=9 rather than explicitly on perl-gtk3-imageview-shutter. Will file a deletion request for perl-gtk3-imageview-shutter as soon as perl-gtk3-imageview hits community.


Desktop: http://www.sysprofile.de/id15562, Arch Linux    |    Notebook: Thinkpad X200 Tablet, Manjaro

The very worst thing you can do with free software is to download it, see that it doesn't work for some reason, leave it, and tell your friends that it doesn't work.  -  Tuomas Lukka

Offline

#10 2021-05-29 18:06:30

Muflone
Trusted User (TU)
From: Italy
Registered: 2013-10-08
Posts: 87
Website

Re: [Request] Please move shutter to the official repo

Hi PhotonX

I'm currently trying the package, it may interested in being moved in the community repo, but there's a major bug which afflicts the full screen captures.

When I press the Desktop button (in any variants) I can see the following debug trace:

full was emitted by widget Gtk3::MenuToolButton=HASH(0x5616ec28a198)
*** unhandled exception in callback:
***   Can't locate object method "new" via package "Gtk3::Gdk::Region" (perhaps you forgot to load "Gtk3::Gdk::Region"?) at /usr/share/shutter/resources/modules/Shutter/Screenshot/Main.pm line 137.
***   	Shutter::Screenshot::Main::get_monitor_region(Shutter::Screenshot::Workspace=HASH(0x5616ed6c3ca0)) called at /usr/share/shutter/resources/modules/Shutter/Screenshot/Workspace.pm line 254
***   	Shutter::Screenshot::Workspace::workspace(Shutter::Screenshot::Workspace=HASH(0x5616ed6c3ca0)) called at /usr/bin/shutter line 5876
***   	Shutter::App::fct_take_screenshot(Gtk3::MenuToolButton=HASH(0x5616ec28a198), "full", undef, undef) called at /usr/bin/shutter line 3024
***   	Shutter::App::__ANON__() called at /usr/lib/perl5/5.34/vendor_perl/Glib/Object/Introspection.pm line 67
***   	eval {...} called at /usr/lib/perl5/5.34/vendor_perl/Glib/Object/Introspection.pm line 67
***   	Glib::Object::Introspection::__ANON__(Shutter::App=HASH(0x5616ebd851b0)) called at /usr/bin/shutter line 10789
***  ignoring at /usr/lib/perl5/5.34/vendor_perl/Glib/Object/Introspection.pm line 67.
 at /usr/bin/shutter line 10789.

The shutter dialog disappears and no screenshot is captured

Do you have an idea if this is an upstream bug or is there some missing dependency?

Upstream issue: https://github.com/shutter-project/shutter/issues/340

Last edited by Muflone (2021-05-29 18:16:45)

Offline

#11 2021-05-29 19:05:07

PhotonX
Member
From: Munich
Registered: 2008-08-10
Posts: 522

Re: [Request] Please move shutter to the official repo

Yeah, several bugs popped out in 0.96, it was a big update after all. I think, it is better to wait for the next release before putting Shutter into the official repos. The particular issue you mentioned should be fixed in the git version though (I commented in your report accordingly).


Desktop: http://www.sysprofile.de/id15562, Arch Linux    |    Notebook: Thinkpad X200 Tablet, Manjaro

The very worst thing you can do with free software is to download it, see that it doesn't work for some reason, leave it, and tell your friends that it doesn't work.  -  Tuomas Lukka

Offline

#12 2021-06-19 15:25:14

PhotonX
Member
From: Munich
Registered: 2008-08-10
Posts: 522

Re: [Request] Please move shutter to the official repo

@Muflone: A new 0.97 release is out today fixing the bug you discovered and several other regressions. I updated the AUR package, maybe it can be moved to community/ now?


Desktop: http://www.sysprofile.de/id15562, Arch Linux    |    Notebook: Thinkpad X200 Tablet, Manjaro

The very worst thing you can do with free software is to download it, see that it doesn't work for some reason, leave it, and tell your friends that it doesn't work.  -  Tuomas Lukka

Offline

#13 2021-06-19 16:39:09

Muflone
Trusted User (TU)
From: Italy
Registered: 2013-10-08
Posts: 87
Website

Re: [Request] Please move shutter to the official repo

@PhotonX let me test the package a bit, I'll reply you later

Offline

#14 2021-06-20 14:55:09

Muflone
Trusted User (TU)
From: Italy
Registered: 2013-10-08
Posts: 87
Website

Re: [Request] Please move shutter to the official repo

the packages shutter, perl-json-maybexs, perl-cpanel-json-xs, perl-goocanvas2-cairotypes have just moved to the community-testing repository

Feel free to test the package if everything is working fine.

from your package I've removed the patches for the icon theme. Please ask the developer to integrate it, in the case

Offline

#15 2021-06-20 16:11:46

PhotonX
Member
From: Munich
Registered: 2008-08-10
Posts: 522

Re: [Request] Please move shutter to the official repo

Great, thanks, and also thanks for the hint regarding the sed line, I already forgot about its existence...

edit: Asked upstream: https://github.com/shutter-project/shutter/issues/356

Last edited by PhotonX (2021-06-20 16:17:57)


Desktop: http://www.sysprofile.de/id15562, Arch Linux    |    Notebook: Thinkpad X200 Tablet, Manjaro

The very worst thing you can do with free software is to download it, see that it doesn't work for some reason, leave it, and tell your friends that it doesn't work.  -  Tuomas Lukka

Offline

#16 2021-06-20 17:06:09

eschwartz
Trusted User/Bug Wrangler
Registered: 2014-08-08
Posts: 4,083

Re: [Request] Please move shutter to the official repo

diff --git a/bin/shutter b/bin/shutter
index 31956be5..dbb18696 100755
--- a/bin/shutter
+++ b/bin/shutter
@@ -632,7 +632,7 @@ sub STARTUP {
 	unless ($sc->get_disable_systray) {
 
 		$tray = Gtk3::StatusIcon->new();
-		$tray->set_from_icon_name("shutter-panel");
+		$tray->set_from_file("/usr/share/icons/hicolor/scalable/apps/shutter-panel.svg");
 		$tray->set_visible(1);
 
 		fct_update_gui();
@@ -655,7 +655,7 @@ sub STARTUP {
 
 		if ($appindicator && !defined $tray) {
 			# Fallback to AppIndicator. This one doesn't allow left-click signal, but it seems to be the only option for Gnome on Ubuntu 21.04...
-			$tray = AppIndicator::Indicator->new("Shutter", "shutter-panel", 'application-status');
+			$tray = AppIndicator::Indicator->new("Shutter", "/usr/share/icons/hicolor/scalable/apps/shutter-panel.svg", 'application-status');
 			$tray->set_menu($tray_menu);
 			$tray->set_status('active');
 		}

This seems quite wrong... it's saying "don't even try to use the icon theme spec, just hardcode filenames everywhere", and will break quite horridly in the default Makefile action of installing to /usr/local

"under many icon themes" what, exactly, is happening? These icon themes don't include their *own* icon for shutter-panel? That's fine! Most themes don't include icons for every single application out there! The icon theme spec specifically states if an icon is not found in the current theme, the fallback "hicolor" theme is searched.

So this inadvisably terrible sed appears to exist in order to fix some software that COMPLETELY violates the spec and ignores the fallback "hicolor" theme if the user specifies another theme.

Do NOT include this sed, if you do it counts as a bug in shutter. smile


Managing AUR repos The Right Way -- aurpublish (now a standalone tool)

Offline

#17 2021-06-20 17:52:02

PhotonX
Member
From: Munich
Registered: 2008-08-10
Posts: 522

Re: [Request] Please move shutter to the official repo

@eschwartz: Thanks for the explanation! I'm not familiar with Shutter's code and only know that the sed line came this way from the Shutter community/ package when it was dropped to the AUR in 2017: https://aur.archlinux.org/cgit/aur.git/ … b9b2d4f612 Muflone removed this line from his new community/ package so the issue should be solved.

Last edited by PhotonX (2021-06-20 17:55:12)


Desktop: http://www.sysprofile.de/id15562, Arch Linux    |    Notebook: Thinkpad X200 Tablet, Manjaro

The very worst thing you can do with free software is to download it, see that it doesn't work for some reason, leave it, and tell your friends that it doesn't work.  -  Tuomas Lukka

Offline

Board footer

Powered by FluxBB