You are not logged in.

#1 2021-07-27 01:10:39

TomTsagk
Member
From: Leamington Spa, UK
Registered: 2016-01-28
Posts: 6
Website

Made a new PKGBUILD after a few years. Does it look reasonable?

Hi all,

This is not exactly my first PKGBUILD, but it's been a few years since I made one. I like to think for the most part it looks alright, but I'm looking for feedback to improve it.
Is there anything that needs urgent change? Or anything that will make my future builds better in the long-term?

Any kind of feedback is appreciated. Here is the PKGBUILD:

# Maintainer: Tom Tsagk <tomtsagk@darkdimension.org>
pkgname=rue
pkgdesc="A card game about deduction, love and regret"
pkgver=0.0.1
pkgrel=1
arch=('x86_64')
url="https://darkdimension.org/games/rue.html"
license=('GPL2')
makedepends=('avdl')
depends=('sdl2' 'sdl2_mixer' 'freeglut' 'glew')
source=($pkgname-$pkgver.tar.gz::https://notabug.org/tomtsagk/$pkgname/archive/v$pkgver.tar.gz)
sha256sums=('b18daa8a50f80de02862514a8a78c69f94001768841758e025feb4d032a0b4f3')

build() {
        cd "$pkgname"
        ./configure --install-loc /usr/share/rue/
        make
}

package() {
        cd "$pkgname"
        make INSTALL_LOCATION_PREFIX="$pkgdir" install
}

Thanks in advance

Last edited by TomTsagk (2021-07-27 09:41:20)


Video game developer, I like making unusual games.
You can find my work at https://darkdimension.org/.

Offline

#2 2021-07-27 02:16:50

loqs
Member
Registered: 2014-03-06
Posts: 13,940

Re: Made a new PKGBUILD after a few years. Does it look reasonable?

Just minor things:

source=(https://notabug.org/tomtsagk/$pkgname/archive/v$pkgver.tar.gz)

Is it preferable to rename files that only contain a version to a unique name for instance

source=($pkgname-$pkgver.tar.gz::https://notabug.org/tomtsagk/$pkgname/archive/v$pkgver.tar.gz)
        make INSTALL_LOCATION_PREFIX=$pkgdir install

Please always quote $pkgdir and $srcdir as their paths may contain spaces which require quoting.

Offline

#3 2021-07-27 09:39:24

TomTsagk
Member
From: Leamington Spa, UK
Registered: 2016-01-28
Posts: 6
Website

Re: Made a new PKGBUILD after a few years. Does it look reasonable?

Thanks! This is exactly the type of feedback I was looking for.
Both improvements you mentioned sound really good.

I'll edit the original post to add these, to make sure the same feedback is not repeated by future readers.


Video game developer, I like making unusual games.
You can find my work at https://darkdimension.org/.

Offline

#4 2021-07-28 11:34:59

Lone_Wolf
Member
From: Netherlands, Europe
Registered: 2005-10-04
Posts: 9,496

Re: Made a new PKGBUILD after a few years. Does it look reasonable?

I wondered about the download url, but it seems you are the creator of the game and owner of darkdimension.org ?


Disliking systemd intensely, but not satisfied with alternatives so focusing on taming systemd.
Did you use the guided installer ? If yes, I can't help you.

(A works at time B)  && (time C > time B ) ≠  (A works at time C)

Offline

#5 2021-07-28 11:44:14

TomTsagk
Member
From: Leamington Spa, UK
Registered: 2016-01-28
Posts: 6
Website

Re: Made a new PKGBUILD after a few years. Does it look reasonable?

Lone_Wolf wrote:

I wondered about the download url, but it seems you are the creator of the game and owner of darkdimension.org ?

Yes, this is exactly the case. This is a game I made and I also own darkdimension.org. I thought it would be better to link to the game's official page, that has generic information about it, and also links to other pages, including its source code (which I've yet to add on that page).

I hope this is a reasonable approach, as it can show a lot more information about a project.


Video game developer, I like making unusual games.
You can find my work at https://darkdimension.org/.

Offline

#6 2021-07-28 11:55:08

Lone_Wolf
Member
From: Netherlands, Europe
Registered: 2005-10-04
Posts: 9,496

Re: Made a new PKGBUILD after a few years. Does it look reasonable?

It's fine, you may want to add an about page to darkdimensions.org .

One comment : in avdl PKGBUILD you have GPL3  as license, but in rue PKGBUILD GPL2+ .
Is this intentional ?


Disliking systemd intensely, but not satisfied with alternatives so focusing on taming systemd.
Did you use the guided installer ? If yes, I can't help you.

(A works at time B)  && (time C > time B ) ≠  (A works at time C)

Offline

#7 2021-07-28 13:25:50

TomTsagk
Member
From: Leamington Spa, UK
Registered: 2016-01-28
Posts: 6
Website

Re: Made a new PKGBUILD after a few years. Does it look reasonable?

Lone_Wolf wrote:

It's fine, you may want to add an about page to darkdimensions.org .

That sounds like an excellent idea, I'll make sure to add it at some point.

Lone_Wolf wrote:

One comment : in avdl PKGBUILD you have GPL3  as license, but in rue PKGBUILD GPL2+ .
Is this intentional ?

This is kinda intentional. `avdl`'s source code contains the `GPL3` licence, while `rue`'s source code contains the `GPL2+` license. There's no significant reason (yet) to why one was picked one over the other. I haven't decided for sure which version to publish my code on, I believe both versions cover my desired use case.


Video game developer, I like making unusual games.
You can find my work at https://darkdimension.org/.

Offline

Board footer

Powered by FluxBB