You are not logged in.

#1 2022-03-09 12:02:01

calamity
Member
Registered: 2022-03-09
Posts: 2

PKGBUILD review request: doasedit-alternative

Hello,
I know this is not a very sophisticated PKGBUILD, but it will be my first one and I wanted to play safe. Therefore, I kindly request a review. Thanks to anyone in advance.

# Maintainer: calamity
pkgname=doasedit-alternative
pkgver=1.0.0
pkgrel=1
pkgdesc="Enable doers to edit non-user-writable files with an unprivileged editor"
arch=('any')
url="https://codeberg.org/TotallyLeGIT/doasedit"
license=('MIT')
depends=('doas' 'sh')
provides=('doasedit')
conflicts=('doasedit')
source=("${pkgname}-${pkgver}.tar.gz::${url}/archive/${pkgver}.tar.gz")
sha256sums=('0048e21ccf5a3c6a5093e1727e0dad11551b3747cb6baa70511c06e6b665aad3')

package() {
	cd doasedit
	install -Dm 755 doasedit -t "${pkgdir}/usr/bin/"
	install -Dm 644 LICENSE -t "${pkgdir}/usr/share/licenses/${pkgname}/"
}

Offline

#2 2022-03-09 13:23:54

Head_on_a_Stick
Member
From: London
Registered: 2014-02-20
Posts: 6,350

Re: PKGBUILD review request: doasedit-alternative

  • The checksum is wrong, it should be 59f78cf9336250b6fc72a763cce144cbcdd2236b9b388e11a0962db4ab9a7775.

  • You should include an email address in the Maintainer line (see also RFC 5322).

  • Curly brackets around variable names are only required if an underscore or alphanumeric character follows the variable. Not a problem though and many official Arch PKGBUILDs have superfluous curly braces.

Offline

#3 2022-03-09 16:57:07

calamity
Member
Registered: 2022-03-09
Posts: 2

Re: PKGBUILD review request: doasedit-alternative

Thank you very much for your ansewr.

  • Good catch! The checksum is from a (different) cached version which I missed to remove before updating the pkgsums. Fixed.

  • Will do that. I don't really get the RFC reference though. I will assume it is for showing how it should look like.

  • I do that by habit because I rather enclose every variable in curly braces than miss a pair once it's really necessary.

Offline

Board footer

Powered by FluxBB