Plethora of issues on a MacBook7,1

adr77 · 2024-07-03 15:02:43

oh, forgot about that, I'll get on it now.

update: the module is still reported as "added" and not "installed". I've made the module package on the monolith, and copied it over to the Mac, and installed locally. dkms seemed to have done something following the installation, and once it was done, I rebooted.

Last edited by adr77 (2024-07-03 15:15:12)

seth · 2024-07-03 22:11:57

modinfo nvidia-bl

adr77 · 2024-07-03 22:14:26

[andaro@sevencommaone ~]$ modinfo nvidia-bl
modinfo: ERROR: Module nvidia-bl not found.

adr77 · 2024-07-09 02:18:37

erm... it's been a few days... can I have a working laptop please?

seth · 2024-07-09 05:49:31

errrm… what have you don't to build the nvidia-bl module?
In doubt rebuild it and post the dkms log.

Also read https://wiki.archlinux.org/title/Genera … es#Bumping

adr77 · 2024-07-09 05:56:12

Sorry about the bumping, but I did some research and found that the nvidia-bl module isn't building on the LTS kernel.

log:

[andaro@sevencommaone ~]$ sudo dkms autoinstall -k 6.6.37-1-lts
[sudo] password for andaro: 
Sign command: /usr/lib/modules/6.6.37-1-lts/build/scripts/sign-file
Signing key: /var/lib/dkms/mok.key
Public certificate (MOK): /var/lib/dkms/mok.pub

Building module:
Cleaning build area....(bad exit status: 2)
make -j2 KERNELRELEASE=6.6.37-1-lts KVER=6.6.37-1-lts....(bad exit status: 2)
Error! Bad return status for module build on kernel: 6.6.37-1-lts (x86_64)
Consult /var/lib/dkms/nvidia-bl/18.11.0/build/make.log for more information.
dkms autoinstall on 6.6.37-1-lts/x86_64 succeeded for nvidia
dkms autoinstall on 6.6.37-1-lts/x86_64 failed for nvidia-bl(10)
Error! One or more modules failed to install during autoinstall.
Refer to previous errors for more information.

what should I do?

seth · 2024-07-09 06:04:35

dkms wrote:

Consult /var/lib/dkms/nvidia-bl/18.11.0/build/make.log for more information.

adr77 · 2024-07-09 06:07:35

as asked:

DKMS make.log for nvidia-bl-18.11.0 for kernel 6.6.37-1-lts (x86_64)
Tue 09 Jul 2024 08:59:23 IDT
make -C /usr/lib/modules/6.6.37-1-lts/build SUBDIRS=/var/lib/dkms/nvidia-bl/18.11.0/build modules
make[1]: Entering directory '/usr/lib/modules/6.6.37-1-lts/build'
  SYNC    include/config/auto.conf
crypto/Kconfig:1426: can't open file "arch/arm/crypto/Kconfig"
make[4]: *** [scripts/kconfig/Makefile:77: syncconfig] Error 1
make[3]: *** [Makefile:697: syncconfig] Error 2
make[2]: *** [/usr/lib/modules/6.6.37-1-lts/build/Makefile:798: include/config/auto.conf] Error 2
make[1]: *** [Makefile:234: __sub-make] Error 2
make[1]: Leaving directory '/usr/lib/modules/6.6.37-1-lts/build'
make: *** [Makefile:12: default] Error 2

seth · 2024-07-09 06:30:43

Did you see the comments in https://aur.archlinux.org/packages/nvidia-bl-dkms
The package is orphaned and not properly maintained, but patches to fix the build have been posted by its users - did you apply any of them?

adr77 · 2024-07-09 06:31:40

Oh, erm, not yet. I'll take a look and be back in a sec.

I noticed a patch to make it work on the mainline kernel - should I switch back or will it also work on the LTS kernel?

and also, where does it go? as in, which file do I insert the code into.

Last edited by adr77 (2024-07-09 06:36:25)

seth · 2024-07-09 06:45:37

The filename doesn't matter, but you'll have to "git am file.patch" to actually apply it ("git diff" should afterwards show the uncommitted changes)
The moormaster patch will likely build on LTS but not on the main kernel, the sumdudelr will build on the main kernel but possibly also still on the LTS one - pick your poison and try.
"git reset --hard HEAD" will undo the patch if you didn't commit it.

adr77 · 2024-07-09 07:09:08

you sure that's the correct command or am I just doing something wrong?

I copied the moormaster patch into KWrite and saved as "nvidia-bl.patch" on the root of my /home folder.

[andaro@sevencommaone ~]$ git am ~/nvidia-bl.patch
fatal: not a git repository (or any of the parent directories): .git

Should I use something else or is it an error of mine?

note: I'll choose to continue using the LTS kernel, seems that it runs just that bit better on my Mac.

Last edited by adr77 (2024-07-09 07:09:57)

seth · 2024-07-09 07:19:23

You want to Run Git in the path where you git cloned the aur package.

adr77 · 2024-07-09 07:20:32

so not even on the Mac, aight... gotcha, after that I build the package then install?

update: it sort of works, I'm unsure if it does anything as "git diff" also doesnt do anything.

[adr77@monolith nvidia-bl-dkms]$ git am bldkms.patch 
Patch format detection failed.

Last edited by adr77 (2024-07-09 07:33:28)

seth · 2024-07-09 11:39:34

The patch isn't acutally in mbox format, try "git apply bldkms.patch"

adr77 · 2024-07-09 11:47:37

[adr77@monolith nvidia-bl-dkms]$ git apply bldkms.patch 
error: corrupt patch at line 72

line 72 is empty.

seth · 2024-07-09 12:00:00

Is that the older patch?
The whitespace in the posts might be screwed up

diff --git a/Makefile b/Makefile
index 4c16ce1..1121cf6 100644
--- a/Makefile
+++ b/Makefile
@@ -9,7 +9,7 @@ KDIR    := /usr/lib/modules/$(KVER)/build
 PWD    := $(shell pwd)

 default:
-   $(MAKE) -C $(KDIR) SUBDIRS=$(PWD) modules
+   $(MAKE) -C $(KDIR) M=$(PWD) SUBDIRS=$(PWD) modules

 clean:
-   $(MAKE) -C $(KDIR) SUBDIRS=$(PWD) clean
+   $(MAKE) -C $(KDIR) M=$(PWD) SUBDIRS=$(PWD) clean
diff --git a/PKGBUILD b/PKGBUILD
index 2ffb049..c0add82 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -20,8 +20,8 @@ source=('nvidia_bl.c'
         'nvidia_bl.conf'
         'nvidia_bl_ml.conf'
         'dkms.conf')
-md5sums=('52131bc4de928fbc13c00a44a3538486'
-         'e6a6a05f27e49c53783243e278ad6551'
+md5sums=('ec32107661f01b63e565fedb00a6acc2'
+         'ab33e47171098009a47d11574bbc6ebd'
          '897ee78c30e6b498d0e3ce07c06dabc5'
          '5771d2ea826f76d8f27bd9fdcb78a76f'
          'b5547c594e8c2d72620e95888bd79d7f')
diff --git a/nvidia_bl.c b/nvidia_bl.c
index c1d3593..e7dfccb 100644
--- a/nvidia_bl.c
+++ b/nvidia_bl.c
@@ -538,17 +538,17 @@ static const unsigned nvidia_bl_subvendors[] __initdata = {
 /*
  * Machine specific quirks used below.
  */
-static const struct machine_quirks apple_quirks __initdata = {
+static const struct machine_quirks apple_quirks = {
    .dev_id     = PCI_ANY_ID,
    .max_level  = 1023
 };

-static const struct machine_quirks apple_quirks_320m __initdata = {
+static const struct machine_quirks apple_quirks_320m = {
    .dev_id     = PCI_ANY_ID,
    .max_level  = 44000
 };

-static const struct machine_quirks max_level_0x1ffff __initdata = {
+static const struct machine_quirks max_level_0x1ffff = {
    .dev_id     = PCI_ANY_ID,
    .max_level  = 0x1ffff
 };
@@ -565,7 +565,7 @@ static int nvidia_bl_dmi_match(const struct dmi_system_id *id)
    return 1;
 }

-static const struct dmi_system_id nvidia_bl_machine_table[] __initdata = {
+static const struct dmi_system_id nvidia_bl_machine_table[] = {
    /*
     * Apple machines: Intel chipset, Nvidia graphics
     */
@@ -925,7 +925,7 @@ static int nvidia_bl_map_smartdimmer(struct driver_data *dd)
               "smartdimmer at 0x%lx\n", dd->bar, bar_start, reg_addr);

    /* Now really map (The address need not be page-aligned.) */
-   dd->smartdimmer = ioremap_nocache(reg_addr, dd->reg_size);
+   dd->smartdimmer = ioremap_cache(reg_addr, dd->reg_size);
    if (!dd->smartdimmer)
        return -ENXIO;

adr77 · 2024-07-09 12:07:15

[adr77@monolith nvidia-bl-dkms]$ git apply bldkms.patch 
error: patch failed: Makefile:9
error: Makefile: patch does not apply
error: patch failed: nvidia_bl.c:538
error: nvidia_bl.c: patch does not apply
[adr77@monolith nvidia-bl-dkms]$ git diff

"git diff" returns nothing after installing less.

seth · 2024-07-09 12:28:36

patch -l -p1 < bldkms.patch

The whitespace is probably fucked up beyond any repair through the browser/webpage/copypaste

adr77 · 2024-07-09 12:33:55

ok, do I run makepkg then install on the Mac now?

ended up trying to install it anyway, and...

[adr77@monolith nvidia-bl-dkms]$ makepkg -sf
==> Making package: nvidia-bl-dkms 18.11.0-2 (Tue 09 Jul 2024 15:34:17)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving sources...
  -> Found nvidia_bl.c
  -> Found Makefile
  -> Found nvidia_bl.conf
  -> Found nvidia_bl_ml.conf
  -> Found dkms.conf
==> Validating source files with md5sums...
    nvidia_bl.c ... FAILED
    Makefile ... FAILED
    nvidia_bl.conf ... Passed
    nvidia_bl_ml.conf ... Passed
    dkms.conf ... Passed
==> ERROR: One or more files did not pass the validity check!

yea...

Last edited by adr77 (2024-07-09 12:45:41)

seth · 2024-07-09 14:02:21

The patch only changes one md5sum but two files.
And they're probably now both wrong b/c of the whitespace mess.
=> draw the md5sums of the two files and change them in the PKGBUILD manually.

adr77 · 2024-07-09 15:15:44

screw it, I have no idea how to generate an md5sum, but I sure as heck got some fingers, free time and nano.

just gonna manually program the patch file then apply it. brb.

seth · 2024-07-09 15:55:50

md5sum Makefile

You don't need to manually Patch anything and IT won't Help you - the md5sum still hast to be aligned.

adr77 · 2024-07-09 15:56:26

too late lol, almost done

...and I spent my time for nothing, there's an error at line 40 that I can't decipher what's wrong.

also, I can't understand what to do with the md5sum afterwards, where do I put it at?

Last edited by adr77 (2024-07-09 16:04:50)

seth · 2024-07-09 18:22:39

I spent my time for nothing

We learn everyday.
Today you learned: first think, then act.

The md5sums go into the respective array in the PKGBUILD, the order has to match the order in the source array above.
The previous patch -l worked, but the md5sums can't match anymore, so apply the patch, draw the md5sums, manually fix the PKGBUILD with them and then run makepkg.

Arch Linux

#76 2024-07-03 15:02:43

Re: Plethora of issues on a MacBook7,1

#77 2024-07-03 22:11:57

Re: Plethora of issues on a MacBook7,1

#78 2024-07-03 22:14:26

Re: Plethora of issues on a MacBook7,1

#79 2024-07-09 02:18:37

Re: Plethora of issues on a MacBook7,1

#80 2024-07-09 05:49:31

Re: Plethora of issues on a MacBook7,1

#81 2024-07-09 05:56:12

Re: Plethora of issues on a MacBook7,1

#82 2024-07-09 06:04:35

Re: Plethora of issues on a MacBook7,1

#83 2024-07-09 06:07:35

Re: Plethora of issues on a MacBook7,1

#84 2024-07-09 06:30:43

Re: Plethora of issues on a MacBook7,1

#85 2024-07-09 06:31:40

Re: Plethora of issues on a MacBook7,1

#86 2024-07-09 06:45:37

Re: Plethora of issues on a MacBook7,1

#87 2024-07-09 07:09:08

Re: Plethora of issues on a MacBook7,1

#88 2024-07-09 07:19:23

Re: Plethora of issues on a MacBook7,1

#89 2024-07-09 07:20:32

Re: Plethora of issues on a MacBook7,1

#90 2024-07-09 11:39:34

Re: Plethora of issues on a MacBook7,1

#91 2024-07-09 11:47:37

Re: Plethora of issues on a MacBook7,1

#92 2024-07-09 12:00:00

Re: Plethora of issues on a MacBook7,1

#93 2024-07-09 12:07:15

Re: Plethora of issues on a MacBook7,1

#94 2024-07-09 12:28:36

Re: Plethora of issues on a MacBook7,1

#95 2024-07-09 12:33:55

Re: Plethora of issues on a MacBook7,1

#96 2024-07-09 14:02:21

Re: Plethora of issues on a MacBook7,1

#97 2024-07-09 15:15:44

Re: Plethora of issues on a MacBook7,1

#98 2024-07-09 15:55:50

Re: Plethora of issues on a MacBook7,1

#99 2024-07-09 15:56:26

Re: Plethora of issues on a MacBook7,1

#100 2024-07-09 18:22:39

Re: Plethora of issues on a MacBook7,1

Board footer