You are not logged in.

#1 2024-08-10 00:29:46

OhKay_Bet
Member
Registered: 2023-11-16
Posts: 35

[SOLVED]PKGBUILD review: bbfpromix

First time doing a PKGBUILD. still in the process of reading through the building in a clean chroot in order to set that up. Was curious if theres any critique to the PKGBUILD or any advice since ive yet to install the package to my system.

pkgname='bbfpromix'
pkgver=0.1.0
pkgrel=1
pkgdesc="Rust fork of unmaintained bbfpromix ALSA Mixer Frontend for RME Babyface Pro (FS)"
arch=('x86-64')
url="https://github.com/slowtec/$pkgname"
license=("GPL-3.0")
depends= ('rustup'
          'alsa-utils'
          'gtk3')
makedepends= ('cargo')
optdepends= ('pipewire-alsa')
provides=('bbfpromix')
conflicts=('bbfpromix')
source=("$pkgname-$pkgver.tar.gz::https://github.com/slowtec/bbfpromix/archive/refs/tags/v0.1.0.tar.gz")
sha256sums=('SKIP')

prepare() {
  cd "$pkgname-$pkgver"
  export RUSTUP_TOOLCHAIN=stable
  cargo fetch --locked --target "$(rustc -vV | sed -n 's/host: //p')"
}

build () {
  cd "$pkgname-$pkgver"
  export RUSTUP_TOOLCHAIN=stable
  export CARGO_TARGET=target
  cargo build --frozen 
}

check () {
  export RUSTUP_TOOLCHAIN=stable
  cargo test --frozen
}

package() {
  cd "$pkgname-$pkgver"
  install -Dm0755 -t "$pkgdir/usr/bin" "target/release/$pkgname"
}

Last edited by OhKay_Bet (2024-08-10 20:16:12)

Offline

#2 2024-08-10 17:52:10

yochananmarqos
Member
Registered: 2020-02-05
Posts: 211

Re: [SOLVED]PKGBUILD review: bbfpromix

Looks good except for rustup should be removed from the depends array. Rust / Rustup is only required to build covered by cargo in makedepends.

EDIT: Remove the provides and conflicts arrays. A package already provides and conflicts with itself.

Last edited by yochananmarqos (2024-08-10 17:52:45)

Offline

#3 2024-08-10 19:31:49

OhKay_Bet
Member
Registered: 2023-11-16
Posts: 35

Re: [SOLVED]PKGBUILD review: bbfpromix

@yochananmarqos, i used the conflicts array since theirs a archived version on the aur. would it be better to put it in a replaces array?

Offline

#4 2024-08-10 20:09:25

yochananmarqos
Member
Registered: 2020-02-05
Posts: 211

Re: [SOLVED]PKGBUILD review: bbfpromix

There's nothing to conflict with as the package name is the same. How can a package replace itself?

See:

If you submit this to the AUR, you'll just be taking over the "deleted" (actually archived) package of the same name.

Offline

#5 2024-08-10 20:12:30

OhKay_Bet
Member
Registered: 2023-11-16
Posts: 35

Re: [SOLVED]PKGBUILD review: bbfpromix

@yochananmarqos thank you for your help and assistance as well as giving extra readings. Time to build it in a clean chroot and see if it works.

Offline

Board footer

Powered by FluxBB