Arch Linux

oech3

Member

Registered: 2017-09-03

Posts: 43

Unneeded unzip make dependencies are exists in official PKGBUILDs

I noticed that some packages in official PKGBUILDs sets makedepends=(unzip) without using unzip command even makepkg passes without it.
I consider it was needed by previous pacman to extract .zip sources before.
unzip is not needed if it is directly called since bsdunzip exists in libarchive.

However, I can't test every package and send MR for them.Does anyone help me?

Discussing at forum is wrong. But where shoud I report?

Lone_Wolf

Administrator

From: Netherlands, Europe

Registered: 2005-10-04

Posts: 13,535

Re: Unneeded unzip make dependencies are exists in official PKGBUILDs

Verify first if your assumption bsdunzip in libarchive makes adding unzip to makedepends unnecessary is correct .

Set up clean chroot building .
Remove unzip from makedeps and try to build with the clean chroot .

If the build fails, unzip is needed.

---

Disliking systemd intensely, but not satisfied with alternatives so focusing on taming systemd.

clean chroot building not flexible enough ?
Try clean chroot manager by graysky

oech3

Member

Registered: 2017-09-03

Posts: 43

Re: Unneeded unzip make dependencies are exists in official PKGBUILDs

@Lone_Wolf I type

unzip

after build passed for the sake. I check files in pkg.

Some package runs unzip in make,cmake,ninja,etc... So unzip is not removed completely even bsdunzip exists (without dirty hack).

Last edited by oech3 (2025-04-15 13:47:28)

mackin_cheese

Member

Registered: 2025-01-07

Posts: 434

Re: Unneeded unzip make dependencies are exists in official PKGBUILDs

I noticed that some packages

Care to provide an example or two? You can't just make this claim without providing some examples so others can test and verify.

oech3

Member

Registered: 2017-09-03

Posts: 43

Re: Unneeded unzip make dependencies are exists in official PKGBUILDs

@mackin_cheese I sended PR. Some are merged. I comment again once things have settled down, and difficult examples are found.

I leave a interesting case.
unzip is technically removable from make deps of file-rooler. However, namcap warn it since it is also optdeps.
Because it is a risk that unzip is not linked with file-rooler. But unzip is just binary...

loqs

Member

Registered: 2014-03-06

Posts: 18,402

Re: Unneeded unzip make dependencies are exists in official PKGBUILDs

I noticed that some packages in official PKGBUILDs sets makedepends=(unzip) without using unzip command even makepkg passes without it.

This is not a valid argument that a dependency is not needed as multiple build systems allow for additional features to be added depending on build time detection of available dependencies. Which is why you need to use diffoscope or similar to verify the generated packages are identical without or without except for expected changes to .BUILDINFO .MTREE and .PKGINFO.

However, I can't test every package and send MR for them.Does anyone help me?

Propose on https://gitlab.archlinux.org/archlinux/ideas

Care to provide an example or two?

You can see the issues and merge requests opened by https://gitlab.archlinux.org/oech3 in the last day are all related to this issue.

libarchive previously has issues with handling of split zip files, encrypted zip files, UTF-8 in zip files which is why when pkzip was removed from the repositories 7zip was provided as the symlink replacement instead of bsdunzip.

mackin_cheese

Member

Registered: 2025-01-07

Posts: 434

Re: Unneeded unzip make dependencies are exists in official PKGBUILDs

I noticed that some packages in official PKGBUILDs sets makedepends=(unzip) without using unzip command even makepkg passes without it.

This is not a valid argument that a dependency is not needed as multiple build systems allow for additional features to be added depending on build time detection of available dependencies. Which is why you need to use diffoscope or similar to verify the generated packages are identical without or without except for expected changes to .BUILDINFO .MTREE and .PKGINFO.

However, I can't test every package and send MR for them.Does anyone help me?

Propose on https://gitlab.archlinux.org/archlinux/ideas

Care to provide an example or two?

You can see the issues and merge requests opened by https://gitlab.archlinux.org/oech3 in the last day are all related to this issue.

libarchive previously has issues with handling of split zip files, encrypted zip files, UTF-8 in zip files which is why when pkzip was removed from the repositories 7zip was provided as the symlink replacement instead of bsdunzip.

alright i'll check a few

Last edited by mackin_cheese (2025-04-15 22:44:15)

oech3

Member

Registered: 2017-09-03

Posts: 43

Re: Unneeded unzip make dependencies are exists in official PKGBUILDs

Which is why you need to use diffoscope

Is it may applied for optional deps does not have shared libralies?

https://gitlab.archlinux.org/archlinux/ideas

I bookmarked it.

7zip was provided as the symlink replacement

Where is the real package in Arch/AUR?

Thankyou.

oech3

Member

Registered: 2017-09-03

Posts: 43

Re: Unneeded unzip make dependencies are exists in official PKGBUILDs

Is there any fork of unzip instead of combination of https://infozip.sourceforge.net/ and random patches (mostly from Fedora)?

loqs

Member

Registered: 2014-03-06

Posts: 18,402

Re: Unneeded unzip make dependencies are exists in official PKGBUILDs

7zip was provided as the symlink replacement

Where is the real package in Arch/AUR?

https://gitlab.archlinux.org/archlinux/ … ages/p7zip.  It is up to the package maintainers if a dropped package is moved to AUR.

twelveeighty

Member

Registered: 2011-09-04

Posts: 1,311

Re: Unneeded unzip make dependencies are exists in official PKGBUILDs

It is up to the package maintainers if a dropped package is moved to AUR.

Just to clarify for those new to Arch: but if the package maintainer decides not to drop it to AUR (typically as an orphaned package), any other person can add it to the AUR once it has been removed from the official repos, assuming that package still adheres to the AUR Rules of submission.

loqs

Member

Registered: 2014-03-06

Posts: 18,402

Re: Unneeded unzip make dependencies are exists in official PKGBUILDs

I wonder is someone will attempt to add it to AUR as there is no explicit rule against unmaintained packages or packages that are marked as replaced by an official package.