Arch Linux

ryanbarillos

Member

Registered: 2023-11-29

Posts: 48

edk2-ovmf-fedora - Is the PKGBUILD formatted right?

So I'm the maintainer for edk2-ovmf-fedora
and I've got some questions & doubts.

Currently this is my PKGBUILD:

# custom, local variables used by this PKGBUILD
_pkgnameMeta="edk2-ovmf"
_fedoraVersion=43
_rpmRelease=24

pkgname=$_pkgnameMeta-fedora
pkgver=20250812
pkgrel=3
pkgdesc="UEFI firmware for x86_64 virtual machines (from Fedora ${_fedoraVersion}) — with Secure Boot enabled"
arch=('any')
url="https://packages.fedoraproject.org/pkgs/edk2/${_pkgnameMeta}/"
license=('BSD')

# Rest of the info below isn't needed

The package itself is only ever a Fedora binary package & so I've some doubts regarding my translation of the package info for a PKGBUILD particularly in 2 areas:

1. Licenses
Looking at the upstream URL for this package reveals that this package has the following license:

License(s): Apache-2.0 AND
(BSD-2-Clause OR GPL-2.0-or-later)
AND BSD-2-Clause-Patent AND
BSD-4-Clause AND ISC AND
LicenseRef-Fedora-Public-Domain

In my PKGBUILD, I'm currently updating the licenses it has to better reflect what it has.
I wonder if I should add all of these in like so:

license=(
  Apache-2.0
  BSD-2-Clause-Patent
  BSD-4-Clause
  ISC
  LicenseRef-Fedora-Public-Domain     #Do I add this in, considering the source is from Fedora's download site?
)

Or just follow based on what I find from this package's /usr/share/licenses/edk2-ovmf-fedora/License.OvmfPkg.txt:

license=(
  BSD-2-Clause-Patent
  MIT
  LicenseRef-Fedora-Public-Domain     #Do I add this in, considering the source is from Fedora's download site?
)

That's first question I have in mind.

2. Package Versioning
The way the source package version is formatted is as follows:

{year}{month}{date}-{rpmRelease}.fc{fedoraVersion}

Given this, the versioning of this Fedora binary package can be translated as such:

20250812-24.fc43

year=2025
month=08
date=12
rpmRelease=24
fedoraVersion=43

Given this package version, how do I format it best for my PKGBUILD?

Currently the way I do it is the following:

1. Keep the core version in tact—that'd be "20250812"—so that pkgver=20250812
2. I never include the RPM release no. nor the Fedora version—so it is never and will never be pkgver=20250812-{_rpmRelease}.fc{_fedoraVersion}
3. Whenever the RPM release version updates, I only increase the pkgrel property by 1 inside my PKGBUILD
4. Whenever I update this package to grab its source from the newest Fedora stable release (say on the day Fedora 44 releases in 2026), then as long as the core version remains unchanged the previous rule is enforced

This is the 2nd question I have in mind.
------
These are my 2 doubts regarding the PKGBUILD of one of my maintained packages (that pulls its source from Fedora's binaries). Hoping someone can chime in and let me know if I'm doing this right or can this be improved.

Thanks!

Last edited by ryanbarillos (2025-11-14 17:38:27)