I need a review for my PKGBUILD

Everything2067 · 2026-02-13 07:39:01

This is my first PKGBUILD for the browser extension Plasma Integration:

# Maintainer: Everything2067 <anand shaurya at proton dot me>
pkgname=librewolf-extension-plasma-integration-bin
pkgver=2.1
pkgrel=1
pkgdesc="Plasma Integration extension for LibreWolf"
arch=(any)
url="https://addons.mozilla.org/en-US/firefox/addon/plasma-integration"
license=('GPL-3.0-only')
groups=(librewolf-addons)
depends=(librewolf)
provides=(librewolf-extension-plasma-integration)
conflicts=(librewolf-extension-plasma-integration)
_filename=plasma-browser-integration@kde.org.xpi
source=("$_filename::https://addons.mozilla.org/firefox/downloads/file/4614817/plasma_integration-2.1.xpi")
noextract=("$_filename")
sha256sums=(35bfa3766e097160e74f525bde54d97bbba90d725daa425b9de6fef6ec5e9d44)

package() {
	install -Dm 644 "$_filename" "$pkgdir/usr/lib/librewolf/browser/extensions/$_filename"
}

I have checked and corrected any errors in the PKGBUILD using namcap and shellcheck. Please check for any more errors.
Also, the package plasma-browser-integration is a backend for this extension. Without this backend, the extension is useless. So should I put this in optdepends or depends?

Allan · 2026-02-13 11:01:18

source=("$_filename::https://addons.mozilla.org/firefox/downloads/file/4614817/plasma_integration-2.1.xpi")

Renaming a file without a version in makes updates more difficult. Just use the proper filename and the ${pkgver} variable.

Luciddream · 2026-02-13 11:55:25

Also check that you are using spaces and not tabs for indentations, I think there is a bug in pacman for tabs inside the dependencies array, but I didn't have time to replicate it and report it. And there is no mention in the wiki about not using tabs, so it's easy to miss.

edit: for anyone that wants to take a look into that, this initial commit triggered that (possible) bug.

Last edited by Luciddream (2026-02-13 14:43:57)

Scimmia · 2026-02-13 13:50:46

That has nothing to do with this PKGBUILD. Don't hijack threads.

Luciddream · 2026-02-13 13:54:58

Scimmia wrote:

That has nothing to do with this PKGBUILD. Don't hijack threads.

Of course it does. He is using a tab character in this PKGBUILD. I'm providing tips and an example to support my tip.

Scimmia · 2026-02-13 13:57:25

Nowhere in that PKGBUILD do they have a tab in any array. The depends array which you say is the problem has a single entry.

The only tab here is in the package function, where there's no way it could be a problem. I seriously doubt your entire issue, as you say there's a bug in pacman, but pacman never sees a PKGBUILD at all.

Luciddream · 2026-02-13 14:02:47

Scimmia wrote:

Nowhere in that PKGBUILD do they have a tab in any array. The depends array which you say is the problem has a single entry.
The only tab here is in the package function, where there's no way it could be a problem. I seriously doubt your entire issue, as you say there's a bug in pacman, but pacman never sees a PKGBUILD at all.

Yes, but the only reason there isn't a tab in the depends array is it only has one dependency. And a tab character is allowed by makepkg. I don't see why me suggesting that is that big of an issue. Anyway, I don't have all day to argue. Have a good day

Everything2067 · 2026-02-13 17:36:43

Also check that you are using spaces and not tabs for indentations

I think there is a bug in pacman for tabs inside the dependencies array

Which one is it?
A tab in the package() function was already present in the PKGBUILD.proto file. I did not have a problem in running makepkg.

Also, the package plasma-browser-integration is a backend for this extension. Without this backend, the extension is useless. So should I put this in optdepends or depends?

Please answer this too.

Last edited by Everything2067 (2026-02-13 17:37:31)

Scimmia · 2026-02-13 17:43:14

Ignore everything Luciddream said.

As for plasma-browser-integration, if the extension is useless without it, it's a dep. If it can be used with other backends, it's an optdep.

Arch Linux

#1 2026-02-13 07:39:01

I need a review for my PKGBUILD

#2 2026-02-13 11:01:18

Re: I need a review for my PKGBUILD

#3 2026-02-13 11:55:25

Re: I need a review for my PKGBUILD

#4 2026-02-13 13:50:46

Re: I need a review for my PKGBUILD

#5 2026-02-13 13:54:58

Re: I need a review for my PKGBUILD

#6 2026-02-13 13:57:25

Re: I need a review for my PKGBUILD

#7 2026-02-13 14:02:47

Re: I need a review for my PKGBUILD

#8 2026-02-13 17:36:43

Re: I need a review for my PKGBUILD

#9 2026-02-13 17:43:14

Re: I need a review for my PKGBUILD

Board footer