Arch Linux

Teld

Member

From: Nice, France

Registered: 2007-08-01

Posts: 15

Website

New PKGBUILD for MathMap

My first message on these forums and my first PKGBUILD. It is a plugin for the GIMP and the installation is not a big deal really. Its functionality however is impressive, IMHO. Nevertheless, I would like to post the PKGBUILD here for a peer review. A mistake is easily made despite all checking and double checking. All C&C are welcome.

# Contributor: Serge Gielkens <gielkens.serge@mumeli.org>

# Command line interface and Quicktime support are disabled

pkgname=gimp-mathmap
pkgver=1.2.1
pkgrel=1
pkgdesc="A GIMP plug-in which allows distortion of images specified by mathematical formulae"
url="http://www.complang.tuwien.ac.at/schani/mathmap/"
makedepends=('gimp>=2.2' 'gsl')
depends=('gimp>=2.2' 'gsl')
source=(http://www.complang.tuwien.ac.at/schani/mathmap/files/mathmap-${pkgver}.tar.gz)
arch=('i686')
license=('GPL')
md5sums=('e06610008184d553ec3ab247c277d20f')

build() {
  cd $startdir/src/mathmap-$pkgver
  make || return 1
  /bin/install -D -m 755 mathmap $startdir/pkg/usr/lib/gimp/2.0/plug-ins/mathmap
  /bin/install -D -m 644 new_template.c $startdir/pkg/usr/share/gimp/2.0/mathmap/new_template.c
  /bin/install -D -m 644 opmacros.h $startdir/pkg/usr/share/gimp/2.0/mathmap/opmacros.h
  cp -r examples $startdir/pkg/usr/share/gimp/2.0/mathmap/expressions
}

Last edited by Teld (2007-08-02 11:11:13)

Cerebral

Forum Fellow

From: Waterloo, ON, CA

Registered: 2005-04-08

Posts: 3,108

Website

Re: New PKGBUILD for MathMap

Looks good!  One single suggestion:

. You don't need to repeat the depends in the makedepends area - every depend is automatically a makedepend, so you can remove the makedepends line.

Teld

Member

From: Nice, France

Registered: 2007-08-01

Posts: 15

Website

Re: New PKGBUILD for MathMap

@Cerebral. Thanks for your quick reply. The makedepends line will be removed.