Arch Linux

chimeric

Member

From: Munich, Germany

Registered: 2007-10-07

Posts: 254

Website

First PKGBUILD - viking GPS tool - please review

Hi,

I made my first PKGBUILD for viking, a GTK2 app to display/edit GPS data, and thought it would be wise to post it here for being reviewed before uploading it to the AUR. Here it is:

# Contributor: Michael Klier <chi@chimeric.de>
pkgname=viking
pkgver=0.9.3
pkgrel=1
pkgdesc="GTK+2 application to manage GPS data."
arch=('i686')
url="http://viking.sourceforge.net"
license=('GPL2')
depends=('gtk2' 'gpsd' 'curl')
makedepends=('pkgconfig')
provides=()
conflicts=()
replaces=()
source=("http://prdownloads.sourceforge.net/viking/$pkgname-$pkgver.tar.gz")
md5sums=('83b15a395fa08d7c6ee852559e4ddf9e')

build() {
  cd "$startdir/src/$pkgname-$pkgver"

  ./configure --prefix=/usr
  make || return 1
  make DESTDIR="$startdir/pkg" install
}

# setup vim:ts=2:sw=2:et:enc=utf-8:

TIA for any feedback (if someone would like to test it it would be great, I still need to read up on what's the best method to test things [chroot a.s.o.])

PS.: I wonder how many of you provide some sort of "last modified" date below the contributer field? Would that be a good thing to add?

Snowman

Developer/Forum Fellow

From: Montreal, Canada

Registered: 2004-08-20

Posts: 5,212

Re: First PKGBUILD - viking GPS tool - please review

For the source, use:
source=("http://downloads.sourceforge.net/viking/$pkgname-$pkgver.tar.gz")

You can also remove the unused fields:
provides=()
conflicts=()
replaces=()
to clean up the PKGBUILD.

The "last modified" date is displayed by the AUR interface. I don't recall seeing it explicitely in a PKGBUILD.

nofxx

Member

Registered: 2008-01-03

Posts: 11

Re: First PKGBUILD - viking GPS tool - please review

Yea..remove the unused..
But I tought you need to leave 'install=' hmmm....
and src= (even if it is cvs/svn)

and
provides=(viking)
conflicts=(viking)

Pls some clarify

Allan

Pacman

From: Brisbane, AU

Registered: 2007-06-09

Posts: 11,400

Website

Re: First PKGBUILD - viking GPS tool - please review

You don't need to keep any empty feilds, including install().  It does not need to provide/conflict viking, given it is viking so that should be obvious!

For the source, it is best to uses the "downloads.sourceforge.net" url so that it can select a mirror close to each user.

---

PGP Key: F99FFE0FEAE999BD

chimeric

Member

From: Munich, Germany

Registered: 2007-10-07

Posts: 254

Website

Re: First PKGBUILD - viking GPS tool - please review

Thanks for all the replies ! I'll gonna apply the suggested changes and upload it to the AUR.

Xinix

Member

Registered: 2008-03-14

Posts: 83

Re: First PKGBUILD - viking GPS tool - please review

Sorry to revive an old thread, but I cannot download data from the Garmin. It works without issues in Debian. Dmesg shows me the device is connected and I have gpsd loaded.

I click 'download data' and get the message 'Done. GPS Device: N/A'.

chimeric

Member

From: Munich, Germany

Registered: 2007-10-07

Posts: 254

Website

Re: First PKGBUILD - viking GPS tool - please review

Try to blacklist the garmin_gps kernel module, I had troubel with it too, but gpsbabel has inbuild support for most Garmin devices anyway.