You are not logged in.

#1 2008-03-28 17:01:31

bgc1954
Member
From: Edmonton, AB, Canada
Registered: 2006-03-14
Posts: 1,110

E17 edje still not working after upgrade

Well, e-cvs seems to be ok on my laptop now.  Still an issue in the battery module, excess space between the battery icon and status text, but that's minor.  edje-cvs still doesn't seem to work for me.  I get an "ERROR: Invalid root filename" when I try to edje_decc filename.edj, but that's been like that since after edje-cvs-20080218 so I didn't file a bug report as nothings really changed.  Anyone else having this problem?

Edit: BTW, I just downloaded pressh's Kandy.edj and tried to edje_decc it and got the same "ERROR:Invalid root filename" but it works on other downloaded .edj files with 20080218 ??????

Last edited by bgc1954 (2008-03-28 19:09:58)


configs... Time is a great teacher, but unfortunately it kills all its pupils ... - Louis Hector Berlioz

Offline

#2 2008-03-29 19:31:04

pressh
Developer/TU
From: Netherlands
Registered: 2005-08-14
Posts: 1,717

Re: E17 edje still not working after upgrade

bgc1954 wrote:

Well, e-cvs seems to be ok on my laptop now.  Still an issue in the battery module, excess space between the battery icon and status text, but that's minor.

You can theme the modules (picture/text size & location). Can you try the Kandy theme and see if you still have the problem with the battery module (provide me a screenshot if you do and tell me what you want to achieve).

bgc1954 wrote:

edje-cvs still doesn't seem to work for me.  I get an "ERROR: Invalid root filename" when I try to edje_decc filename.edj, but that's been like that since after edje-cvs-20080218 so I didn't file a bug report as nothings really changed.  Anyone else having this problem?

No I don't have that problem and I seem not be able to replicate it. Have you tried it with a clean ~/.e (although I'm not sure if that would make a difference) ?
If the problem remains can you send me an edj with which you have the problem ?

bgc1954 wrote:

Edit: BTW, I just downloaded pressh's Kandy.edj and tried to edje_decc it and got the same "ERROR:Invalid root filename" but it works on other downloaded .edj files with 20080218 ??????

a well, I'm obviously able to extract my own theme. I'm a bit confused what is happening on your machine. Answer above questions first before I try to find out what could be going wrong.

Offline

#3 2008-03-29 21:24:17

skottish
Forum Fellow
From: Here
Registered: 2006-06-16
Posts: 7,880

Re: E17 edje still not working after upgrade

This may shed some light (from http://www.enlightenment.org/viewvc/e17 … iew=markup ):

static int
root_filename_is_sane()
{
   SrcFile *sf = srcfiles->list->data;
   char *f = sf->name, *ptr;

   if (!f || !*f)
     {
    return 0;
     }

   for (ptr = f; ptr && *ptr; ptr++)
     {
    /* only allow [a-z][A-Z][0-9]_-./ */
    switch (*ptr)
      {
       case '_': case '-':  case '.': case '/':
          break;
       default:
          if (!isalnum(*ptr))
        {
           return 0;
        }
      }
     }
   return 1;
}

Offline

#4 2008-03-30 12:54:17

bgc1954
Member
From: Edmonton, AB, Canada
Registered: 2006-03-14
Posts: 1,110

Re: E17 edje still not working after upgrade

Now I'm really confused--well not too badly.

I upgraded back to edje-cvs-20080327 and now I can edje_decc Kandy.edj.  The original problem only happens now with a custom theme I was working on but I can edje that with edje-cvs-20080218 and not 0327 so it must be something specific to that file.  It also happened to a chrome.edj that I customized from get-e.org but when I did a fresh download, no more problems.  Another customized theme I did will edje_decc no problem either with 0327.  Kinda weird but probably specific only to me so not to worry.

As far as the battery module thing here are two screenshots showing Kandy and chrome themes with the text spaced way to the right of the battery icon.  This is on my desktop so no status shows but you can see the spacing issue.  I tried your previous suggestion in another post and and changing the spacing line in battery.edc didn't help at all.  But when I use e-cvs-20080218 there is no space between the text and battery.

http://www.mediafire.com/imageview.php? … tj&thumb=4

http://www.mediafire.com/imageview.php? … jm&thumb=4

Btw, pressh, if you want to check that custom theme that won't decompress it's posted on e17-stuff.org as Star Theme.  EDIT: I just had an idea that worked.  I decompressed my custom theme with 0218 and then compressed with 0327 and now it behaves properly.  tongue
I guess I'll repost my theme on e17-stuff.org so that it is usable by the new edje-cvs.

Last edited by bgc1954 (2008-03-30 14:50:57)


configs... Time is a great teacher, but unfortunately it kills all its pupils ... - Louis Hector Berlioz

Offline

#5 2008-03-30 15:52:11

pressh
Developer/TU
From: Netherlands
Registered: 2005-08-14
Posts: 1,717

Re: E17 edje still not working after upgrade

bgc1954 wrote:

As far as the battery module thing here are two screenshots showing Kandy and chrome themes with the text spaced way to the right of the battery icon.  This is on my desktop so no status shows but you can see the spacing issue.  I tried your previous suggestion in another post and and changing the spacing line in battery.edc didn't help at all.

How about something like this:
200803301735011024x768sal2.th.png
Details of what I changed in battery.edc from Kandy.edj are to be found in the screenshot. Note that it is a dirty hack (resizing the panel below a certain size, the text will be on top of the image) but playing with those numbers you should be able to adjust it for your situation. I'm a bit short on time at the moment (exams) so I only can give you a dirty solution at the moment.

bgc1954 wrote:

But when I use e-cvs-20080218 there is no space between the text and battery.

I don't have that version anymore. Does the default_battery.edc included in the default.edj of e-cvs-20080218 give the same behavior when you include it with a current theme?

Offline

#6 2008-03-30 16:51:41

bgc1954
Member
From: Edmonton, AB, Canada
Registered: 2006-03-14
Posts: 1,110

Re: E17 edje still not working after upgrade

pressh wrote:

I don't have that version anymore. Does the default_battery.edc included in the default.edj of e-cvs-20080218 give the same behavior when you include it with a current theme?

Yes, those two screenshots are from my desktop which is running the current e-cvs-20080327 and the space issue disappears when I run the same theme on my laptop with 0218.  I have just been running e-cvs-20080218 on my laptop lately as the space issue was kind of bugging me.

And as far as a proper solution, don't sweat it, your studying is much more important. smile

I'll play around with what you've given me to try.  Thanks for all your effort!

Edit: Worked like a charm.  I ended up setting it at 0.6 for my laptop screen.  Thanks again. big_smile

Last edited by bgc1954 (2008-03-30 19:12:15)


configs... Time is a great teacher, but unfortunately it kills all its pupils ... - Louis Hector Berlioz

Offline

Board footer

Powered by FluxBB