You are not logged in.

#1 2005-07-11 20:22:38

ecoffey
Member
Registered: 2005-06-24
Posts: 14

Beep Media Player + Visualization Patch

Recently bmp started crashing when hiding the player by clicking the bmp-docklet icon.  I found this fix in gentoo portage.

Here's the modified PKGBUILD and the patch:

PKGBUILD:

pkgname=bmp
pkgver=0.9.7
pkgrel=2
pkgdesc="gtk2 port of xmms"
url="http://beepmp.sourceforge.net/"
depends=('gtk2' 'libvorbis' 'esd' 'alsa-lib' 'expat' 'libglade' 'x-server')
source=(http://dl.sourceforge.net/sourceforge/beepmp/$pkgname-$pkgver.tar.gz $pkgver-visualization.patch)
md5sums=('5d74113f5de3d11a400d1d6c118d41c0' 'fa1bdf5a8d03e8539a6bed5caa471176')

build() {
  cd $startdir/src/$pkgname-$pkgver
  cd beep/ && patch -p1 -i ../../${pkgver}-visualization.patch && cd ..
  ./configure --prefix=/usr
  /usr/bin/make || return 1
  /usr/bin/make DESTDIR=$startdir/pkg install
}
# vim: ts=2 sw=2 et ft=sh

0.9.7-visualization.patch:

--- beep/vis.c  2004-12-04 10:04:29.000000000 +0100
+++ beep/vis.c  2005-02-17 12:02:25.391044008 +0100
@@ -223,7 +223,8 @@ vis_draw(Widget * w)
     /* FIXME: The check "shouldn't" be neccessary? */
     /* if (GTK_IS_WINDOW(vis->vs_window)) { */
     GDK_THREADS_ENTER();
-    gdk_draw_indexed_image(vis->vs_window, vis->vs_widget.gc,
+    if (GDK_IS_DRAWABLE(vis->vs_window))
+        gdk_draw_indexed_image(vis->vs_window, vis->vs_widget.gc,
                            vis->vs_widget.x, vis->vs_widget.y,
                            vis->vs_widget.width, vis->vs_widget.height,
                            GDK_RGB_DITHER_NORMAL, (guchar *) rgb_data,

Note that I already tried contacting the current maintainer (Eric) but the given email is broken.

Offline

#2 2005-07-11 20:39:22

T-Dawg
Forum Fellow
From: Wilmington, NC
Registered: 2005-01-29
Posts: 2,734

Re: Beep Media Player + Visualization Patch

you could submit a bug report and offer the patch and PKGBUILD.
Thats the proper way to do it. Maintainers don't read email often..

Offline

#3 2005-07-11 23:24:57

ecoffey
Member
Registered: 2005-06-24
Posts: 14

Re: Beep Media Player + Visualization Patch

Penguin wrote:

you could submit a bug report and offer the patch and PKGBUILD.
Thats the proper way to do it. Maintainers don't read email often..

$DEITY, I don't know why I didn't think of a bug report....not like I haven't done this kinda stuff before.

It's not that I didn't get a response but that it was a delivery failure.  As far as the archlinux.org mailserver knows "eric" doesn't exist.

Offline

#4 2005-07-11 23:35:41

Snowman
Developer/Forum Fellow
From: Montreal, Canada
Registered: 2004-08-20
Posts: 5,212

Re: Beep Media Player + Visualization Patch

Eric has left the AL dev team. That's why the email isn't working. Kevin Piche is now the maintainer according to the AL home page pkg list.

Offline

#5 2005-07-12 00:14:37

T-Dawg
Forum Fellow
From: Wilmington, NC
Registered: 2005-01-29
Posts: 2,734

Re: Beep Media Player + Visualization Patch

ecoffey wrote:

It's not that I didn't get a response but that it was a delivery failure.  As far as the archlinux.org mailserver knows "eric" doesn't exist.

like I said, if you file a bug report, supa will assign it to the proper maintainer.

Offline

Board footer

Powered by FluxBB