Arch Linux

erufu

Member

Registered: 2011-10-18

Posts: 2

Review of my package

Hi,

Somebody can review and test my first package before I post it on AUR.

Description : A Keynote-like presentation tool for PDF (e.g. beamer)

It's a reimplementation of aur/pdf_presenter_console with qt and poppler.
The developper is a friend of mine who is not a Arch user, he asked me to package it for Arch.

Website : https://lissyx.dyndns.org/redmine/proje … terconsole

qpdfpresenterconsole-2.2.1-1.src.tar.gz

Thanks for readings.

Erufu

Lone_Wolf

Administrator

From: Netherlands, Europe

Registered: 2005-10-04

Posts: 14,849

Re: Review of my package

firefox says the  issuer certificate is not trusted, does your friend use  a self-signed certificate ?

i've downloaded the src-file, and this is the PKGBUILD.

# Maintainer: Sébastien Lacroix <erufu.sennin@gmail.com>
pkgname=qpdfpresenterconsole
pkgver=2.2.1
pkgrel=1
epoch=
pkgdesc="A Keynote-like presentation tool for PDF (e.g. beamer)"
arch=('any')
url="https://lissyx.dyndns.org/redmine/projects/qpdfpresenterconsole"
license=('GPL')
depends=('qt' 'poppler' 'asciidoc' 'cmake')
source=($pkgname-$pkgver.tar.gz)
md5sums=('a5a86132e0d0bb6031343d51e4f91f18')

build() {
  cd "$srcdir/$pkgname-$pkgver"
  mkdir build
  cd build
  cmake -DCMAKE_INSTALL_PREFIX=/usr ../
}

package() {
  cd "$srcdir/$pkgname-$pkgver/build/"
  make DESTDIR="$pkgdir/" install
}

any files included in the src.tar.gz should be small and definitely NOT include the entire sourcecode.
You or your friend should put the sourcecode somewhere on the net where it can be downloaded
(dropbox.com and box.net are 2 filesharing hosts where you can get a free account).

I've looked at the license file from the project, and it doesn't look like it's published under the GPL.

use License=('custom') in the PKGBUILD and add a command to copy the license file to $pkgdir/usr/share/licenses/$pkgname .

You also need to look at the dependencies because when building cmake complained it couldn't find poppler-qt4 .
installing poppler-qt solved this.

---

Disliking systemd intensely, but not satisfied with alternatives so focusing on taming systemd.

clean chroot building not flexible enough ?
Try clean chroot manager by graysky

erufu

Member

Registered: 2011-10-18

Posts: 2

Re: Review of my package

Thanks for the answer.

For the certificate, I will talk about with my friend.

I will upload the source code somewhere and modify the PKGBUILD with yours advices.

thanks

Snowman

Developer/Forum Fellow

From: Montreal, Canada

Registered: 2004-08-20

Posts: 5,212

Re: Review of my package

I believe that cmake should be a makedepends, not a depends.