minidlna daemon fixes [patch]

nfm · 2012-01-17 01:05:08

I have a patch that gets rid of the following error:

daemonize.c:98: error: Unable to open pidfile for writing /var/run/minidlna.pid: Permission denied

from /var/log/minidlna/minidlna.log

However I was not able to get rid of this one:

minidlna.c:1285: error: Failed to remove pidfile /var/run/minidlna.pid: Permission denied

This is probably upstream bug, since permissions are correct, so I just went ahead and added a line of code that cleans up the pid.

It seems that minidlna writes to its own pid (that we have to create it manually), and removes
that pid when it gets killed (unlike most daemons), where this is done manually by a script in /etc/rc.d/

Also /etc/rc.d/minidlna for some reason is sourcing /etc/minidlna.conf, but for what and why? This is bad, bash complains when it tries to interpret the following line

friendly_name=My DLNA Server

http://pastie.org/3198587
ftp://kkaminsk.com/patches/minidlna_fix … _vars.diff

.:B:. · 2012-01-17 02:28:55

It's great that you got fixes, but you should open a bugreport, rather than posting here. The package is in community, not in AUR, and there's a big chance your contributions will go unnoticed here in the forum.

As for sourcing config files, that's routine for service scripts, but those config files go in /etc/conf.d/, not in /etc. Something else that the maintainer should fix .

nfm · 2012-01-17 08:46:22

OK it seems like maintainer applied my patch, cool, but he forgot to mention me as a contributor , this is my first Arch patch! My bash is quite poor but decent enough to write a patch heh. I thought that I would be able to git clone or svn checkout the community/minidlna somehow but I couldn't find a way (this way it would be easy to create patches, e.g. git diff or git format-patch). I retrieved files from ABS.

ftp://notpartofthis.com/patches/minidln … an_v3.diff

Last edited by nfm (2014-10-06 17:16:07)

Arch Linux

#1 2012-01-17 01:05:08

minidlna daemon fixes [patch]

#2 2012-01-17 02:28:55

Re: minidlna daemon fixes [patch]

#3 2012-01-17 08:46:22

Re: minidlna daemon fixes [patch]

Board footer