Arch Linux

anarsoul

Member

Registered: 2011-10-08

Posts: 14

Re: kernel 3 can't reboot nor sleep Acer 110 netbook

I am some days with 3.1.5-1-ARCH version of kernel and still doesn't work, everyone is in the same situation?

Works OK for me with 3.1.5, so probably you hit another bug.

stripwax

Member

Registered: 2011-06-14

Posts: 26

Re: kernel 3 can't reboot nor sleep Acer 110 netbook

I just found this thread - quite a long time after posting the following bug originally:
https://bbs.archlinux.org/viewtopic.php?id=120890

So, from reading the above, I gather that the default reboot method was changed back to kbd in a recent kernel patch.  Some questions then:

1.  Does that mean that, in the meantime, I can just set reboot=kbd on the boot options in grub?  (I have confirmed that neither reboot=b nor reboot=a work for me, and everything used to work perfectly fine prior to kernel 2.6.39.1-1, and I also have a 'quirk' motherboard).
2.  Has anyone confirmed that the submitted kernel patch has *actually* made its way into 3.1.5?#

Gusar

Member

Registered: 2009-08-25

Posts: 3,605

Re: kernel 3 can't reboot nor sleep Acer 110 netbook

1.  Does that mean that, in the meantime, I can just set reboot=kbd on the boot options in grub?

No. That's the first thing I tried. If a quirk is set, that will be used, no way to override it. That's why I wrote a patch.

2.  Has anyone confirmed that the submitted kernel patch has *actually* made its way into 3.1.5?#

Yes, it's in. Changelog:http://www.kernel.org/pub/linux/kernel/ … eLog-3.1.5. Repository: http://git.kernel.org/?p=linux/kernel/g … ags/v3.1.5 - scroll down a bit, you'll see "x86: Fix "Acer Aspire 1" reboot hang"

stripwax

Member

Registered: 2011-06-14

Posts: 26

Re: kernel 3 can't reboot nor sleep Acer 110 netbook

Ah, that's annoying. In that case the kernel probably needs another, separate, patch for my device (SBC fit-pc2), to do the same thing to fix the same thing that broke the Acer. What's the best way to encourage kernel maintainers to fix their regressions (I raised an upstream bugzilla.kernel.org bug about six months ago)

Gusar

Member

Registered: 2009-08-25

Posts: 3,605

Re: kernel 3 can't reboot nor sleep Acer 110 netbook

A problem is that upstream bugzilla is not operational at the moment. The best way is you provide a patch. However, is there actually a quirk set for your machine, as in do you see in dmesg similar messages to what's reported here? If not, then the reboot= command will work.

stripwax

Member

Registered: 2011-06-14

Posts: 26

Re: kernel 3 can't reboot nor sleep Acer 110 netbook

Yes, I see a similar message in dmesg output (see the archlinux issue I posted in my previous message). I don't have the time to learn kernel sources sufficiently to develop my own patch, unfortunately, but I suppose there must be zero active linux developers/maintainers who use the fiit-pc hardware.

Gusar

Member

Registered: 2009-08-25

Posts: 3,605

Re: kernel 3 can't reboot nor sleep Acer 110 netbook

Post the full dmesg message. If I know how your machine is identified, I can create a patch for you.

stripwax

Member

Registered: 2011-06-14

Posts: 26

Re: kernel 3 can't reboot nor sleep Acer 110 netbook

I can do that when I get home tonight, but in the meantime you could look at google's cache for bugzilla upstream id 37712, which has the full details originally posted upstream including dmesg, config, etc.

But, I don't really think another per-platform targeted patch is necessarily the right solution. Even though my platform is setup as a 'quirk', it worked absolutely fine (presumably using bios reboot) until the aforementioned kernel version. So it sounds to me like the right fix is to investigate/revert the change that broke this for my platform and the other platforms.. you can see from my archlinux bug posted earlier that the problem is not just on my platform either.  I would kindof hope that the author that broke the kernel reboot behaviour might know why their code change broke it and be able to fix it 'for all' without requiring a succession of 'my platform broke too' targeted patches. Thoughts? (I realise you are not the author of the kernel change that broke this all, of course, and hugely appreciate your offer of assistance!)

Gusar

Member

Registered: 2009-08-25

Posts: 3,605

Re: kernel 3 can't reboot nor sleep Acer 110 netbook

Kernel bugzilla is up again, so I could have a look at your report there. Try this patch:

--- arch/x86/kernel/reboot.c.orig	2012-01-20 00:04:48.000000000 +0100
+++ arch/x86/kernel/reboot.c	2012-01-22 14:19:00.711731508 +0100
@@ -280,7 +280,7 @@
 		},
 	},
 	{	/* Handle problems with rebooting on CompuLab SBC-FITPC2 */
-		.callback = set_bios_reboot,
+		.callback = set_kbd_reboot,
 		.ident = "CompuLab SBC-FITPC2",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "CompuLab"),

As for you semi-rant , the change that broke your machine won't be reverted as it fixes a lot more than it breaks, and makes it possible to have a lot shorter quirks list. Also, this list is not new, per-platform targeted patches have been needed since pretty much forever. There's no other way around it, there is no magic that would make all machines work. If you have an aversion towards such quirk lists then do not, I repeat, *do not* look at the snd_hda_intel driver

stripwax

Member

Registered: 2011-06-14

Posts: 26

Re: kernel 3 can't reboot nor sleep Acer 110 netbook

Thanks for the reply and patch, I will try this when I get a chance.
Isn't (wasn't?) Keyboard reboot the default? If the patch works, it would make me wonder why the quirk was added in the first place.. also makes me wonder (a) whether the quirk should just be removed, and also still (b) whether the regression in the kernel would/could be fixed (whether there are more devices for which bios reboot used to work and has been broken by the kernel change). The various comments suggest my device might not be the only regression.

Gusar

Member

Registered: 2009-08-25

Posts: 3,605

Re: kernel 3 can't reboot nor sleep Acer 110 netbook

Keyboard reboot *was* the default. Now acpi is. And as I said, it won't be reverted because it fixes a lot more than it breaks. The quirks list to set acpi was growing longer and longer. So instead of continuing that, acpi reboot was made default. The machines that broke through this are few. Oh, and you know the reason most machines nowadays only reboot with the acpi method? Shouldn't be hard to guess.

You can try to simply remove the quirk for your machine, see if the acpi method works. If it does, then that's the patch to send upstream. If it doesn't and the keyboard method works, then my patch is the one to send.

stripwax

Member

Registered: 2011-06-14

Posts: 26

Re: kernel 3 can't reboot nor sleep Acer 110 netbook

Ah-hah, I understand now. Right, I will try acpi (and I expect it will work).

stripwax

Member

Registered: 2011-06-14

Posts: 26

Re: kernel 3 can't reboot nor sleep Acer 110 netbook

Great news - and Gusar, many thanks for the explanation.  Removing the quirk entirely for the FitPC2 enables successful rebooting.  What's the best way to patch upstream with that change?

Also - and I apologise for hijacking the thread in the first place - but the Acer Aspire One A110 has the quirk code to enable kbd reboot - has it actually been confirmed that ACPI reboot does NOT work?  (e.g. should that A110 quirk similarly be just removed completely, has anyone with an Acer 110 tried that? This thread documents that kbd reboot works and bios reboot got broken but not that acpi does /not/ work.)

Gusar

Member

Registered: 2009-08-25

Posts: 3,605

Re: kernel 3 can't reboot nor sleep Acer 110 netbook

What's the best way to patch upstream with that change?

You could attach the patch to your bug report. Or send it to the kernel (linux-kernel _at_ vger.kernel.org) and x86 (x86 _at_ kernel.org) mailing lists.

has it actually been confirmed that ACPI reboot does NOT work?

Yes. There was no quirk for the A110 whatsoever. When the change in the kernel was made, the machine would fail to reboot. Someone tested all the options and determined that bios and kbd methods worked. So the machine was added to the bios quirk list (there was no kbd list at that time). But this didn't work for some of us. I removed the quirk and tested all the options myself. Only kbd worked, so I did the logical thing - created the kbd quirk and made the A110 use it.

Gusar

Member

Registered: 2009-08-25

Posts: 3,605

Re: kernel 3 can't reboot nor sleep Acer 110 netbook

I just saw an interesting patch on the kernel mailing list, it'll go onto 3.3-rc3: "Skip DMI checks if reboot set by user". The comment in the code itself reads:

/* This variable is used privately to keep track of whether or not
 * reboot_type is still set to its default value (i.e., reboot= hasn't
 * been set on the command line). This is needed so that we can
 * suppress DMI scanning for reboot quirks. Without it, it's
 * impossible to override a faulty reboot quirk without recompiling.
 */

This makes things a lot easier for people in such situations as discussed in this thread.