You are not logged in.

#76 2012-03-12 18:08:57

ninian
Member
From: United Kingdom
Registered: 2008-02-24
Posts: 694
Website

Re: ldm - Lightweight Device Mounter

TheLemonMan wrote:

What filesystem is on the device ?

When I mount the device with udisks, here's what 'df -Th' reports:

/dev/sdf       vfat      108M   80M   28M  75% /media/disk

So vfat it is.

Offline

#77 2012-03-13 15:14:18

TheLemonMan
Member
From: Italy
Registered: 2011-09-04
Posts: 214
Website

Re: ldm - Lightweight Device Mounter

So, build it from source and apply this patch. Then run it and post your /var/log/daemon.log after plugging the frame.

Quick'n'dirty howto (forgive the errors, im in a hurry)

mkdir test
cd test
git clone git://github.com/LemonBoy/ldm.git
cd ldm
<move the patch named dump_info.patch into this folder>
patch -p1 < dump_info.patch
make
sudo rc.d stop ldm
sudo ./ldm

Last edited by TheLemonMan (2012-03-13 15:15:43)

Offline

#78 2012-03-13 21:01:12

ninian
Member
From: United Kingdom
Registered: 2008-02-24
Posts: 694
Website

Re: ldm - Lightweight Device Mounter

TheLemonMan wrote:

So, build it from source and apply this patch. Then run it and post your /var/log/daemon.log after plugging the frame

Thank you, your instructions worked well, and apologies for the delay in testing them out. Here's the /var/log/daemon.log information:

Mar 13 20:55:47 localhost ldm: device->filesystem (NULL)
Mar 13 20:55:47 localhost ldm: dev_type disk
Mar 13 20:55:47 localhost ldm: dev_idtype (null)
Mar 13 20:55:47 localhost ldm: device->filesystem (NULL)
Mar 13 20:55:47 localhost ldm: dev_type disk
Mar 13 20:55:47 localhost ldm: dev_idtype (null)
Mar 13 20:55:47 localhost ldm: device->filesystem (NULL)
Mar 13 20:55:47 localhost ldm: dev_type disk
Mar 13 20:55:47 localhost ldm: dev_idtype (null)
Mar 13 20:55:47 localhost ldm: Entering the main loop
# Plugged in photo frame here
Mar 13 20:57:11 localhost ldm: device->filesystem (NULL)
Mar 13 20:57:11 localhost ldm: dev_type disk
Mar 13 20:57:11 localhost ldm: dev_idtype disk
Mar 13 20:57:11 localhost ldm: device->filesystem (NULL)
Mar 13 20:57:11 localhost ldm: dev_type disk
Mar 13 20:57:11 localhost ldm: dev_idtype disk
Mar 13 20:57:11 localhost ldm: device->filesystem (NULL)
Mar 13 20:57:11 localhost ldm: dev_type disk
Mar 13 20:57:11 localhost ldm: dev_idtype disk
Mar 13 20:57:11 localhost ldm: device->filesystem (NULL)
Mar 13 20:57:11 localhost ldm: dev_type disk
Mar 13 20:57:11 localhost ldm: dev_idtype disk
Mar 13 20:57:11 localhost ldm: device->filesystem (NULL)
Mar 13 20:57:11 localhost ldm: dev_type disk
Mar 13 20:57:11 localhost ldm: dev_idtype disk
Mar 13 20:57:11 localhost ldm: device->filesystem (NULL)
Mar 13 20:57:11 localhost ldm: dev_type disk
Mar 13 20:57:11 localhost ldm: dev_idtype disk
Mar 13 20:57:12 localhost ldm: device->filesystem (NULL)
Mar 13 20:57:12 localhost ldm: dev_type disk
Mar 13 20:57:12 localhost ldm: dev_idtype disk

Offline

#79 2012-03-14 15:11:46

TheLemonMan
Member
From: Italy
Registered: 2011-09-04
Posts: 214
Website

Re: ldm - Lightweight Device Mounter

Its a nasty bug on the device end, it doesnt handle usb requests correctly leading to strange bugs like this one. In this case it reports the device as without a filesystem so ldm skips it.
I cant think of the right way to get around this problem in a clean way atm

Last edited by TheLemonMan (2012-03-14 15:12:04)

Offline

#80 2012-03-15 11:12:54

ninian
Member
From: United Kingdom
Registered: 2008-02-24
Posts: 694
Website

Re: ldm - Lightweight Device Mounter

TheLemonMan wrote:

Its a nasty bug on the device end, it doesnt handle usb requests correctly leading to strange bugs like this one. In this case it reports the device as without a filesystem so ldm skips it.
I cant think of the right way to get around this problem in a clean way atm

Thanks for trying anyway - it's much appreciated.
I can still mount it with udisks for now.

Offline

#81 2012-03-15 12:46:55

Army
Member
Registered: 2007-12-07
Posts: 1,784

Re: ldm - Lightweight Device Mounter

Wanted to take a look at ldm again to see how well it works. It actually works very well, except one thing I just discovered:

I run a fully encrypted system, a not-encrypted /boot partition, an encrypted / and /home partition. All partitions are being mounted on startup, but as soon as ldm is being started, both root and home get mounted into /media as well. Here's my output of "mount"

rootfs on / type rootfs (rw)
proc on /proc type proc (rw,nosuid,nodev,noexec,relatime)
sys on /sys type sysfs (rw,nosuid,nodev,noexec,relatime)
/dev on /dev type devtmpfs (rw,nosuid,relatime,size=1820496k,nr_inodes=455124,mode=755)
run on /run type tmpfs (rw,nosuid,nodev,relatime,mode=755)
/dev/mapper/root on / type xfs (rw,relatime,attr2,delaylog,noquota)
devpts on /dev/pts type devpts (rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=000)
shm on /dev/shm type tmpfs (rw,nosuid,nodev,relatime)
tmpfs on /media type tmpfs (rw,relatime,size=4k)
/dev/sda1 on /boot type ext2 (rw,relatime,user_xattr,barrier=1)
/dev/mapper/home on /home type xfs (rw,relatime,attr2,delaylog,noquota)
/dev/sdb1 on /media/1500GB type xfs (rw,relatime,attr2,delaylog,noquota)
/dev/mapper/root on /media/root type xfs (rw,relatime,attr2,delaylog,noquota)
/dev/mapper/home on /media/home type xfs (rw,relatime,attr2,delaylog,noquota)

Offline

#82 2012-03-15 14:25:42

TheLemonMan
Member
From: Italy
Registered: 2011-09-04
Posts: 214
Website

Re: ldm - Lightweight Device Mounter

@Army

Do what i said to ninian but using this patch and paste your /etc/mtab along with your /var/log/daemon.log

@ninian

I could write a patch for you if you want, its just a matter of minutes smile

Offline

#83 2012-03-17 23:17:42

skottish
Forum Fellow
From: Here
Registered: 2006-06-16
Posts: 7,931

Re: ldm - Lightweight Device Mounter

Hey TheLemonMan,

This is great. Thanks.

I have an issue in that optical media does not automount on an internal SATA Blu-Ray drive. The only error message in the logs is "localhost ldm: Cannot chown the mountpoint". Any ideas?

========================================================================
Showing information for /org/freedesktop/UDisks/devices/sr0
  native-path:                 /sys/devices/pci0000:00/0000:00:11.0/host2/target2:0:0/2:0:0:0/block/sr0
  device:                      11:0
  device-file:                 /dev/sr0
    presentation:              /dev/sr0
    by-id:                     /dev/disk/by-id/ata-ATAPI_iHBS212_2_3772512013_216045500
    by-path:                   /dev/disk/by-path/pci-0000:00:11.0-scsi-2:0:0:0
  detected at:                 Sat 17 Mar 2012 03:51:30 PM PDT
  system internal:             0
  removable:                   1
  has media:                   1 (detected at Sat 17 Mar 2012 04:13:59 PM PDT)
    detects change:            1
    detection by polling:      1
    detection inhibitable:     1
    detection inhibited:       0
  is read only:                0
  is mounted:                  0
  mount paths:             
  mounted by uid:              0
  presentation hide:           0
  presentation nopolicy:       0
  presentation name:           
  presentation icon:           
  automount hint:              
  size:                        41554870272
  block size:                  2048
  job underway:                no
  usage:                       filesystem
  type:                        udf
  version:                     
  uuid:                        
  label:                       STARTREK11D1AC
  optical disc:
    blank:                     0
    appendable:                0
    closed:                    1
    num tracks:                1
    num audio tracks:          0
    num sessions:              1
  drive:
    vendor:                    ATAPI
    model:                     ATAPI   iHBS212   2
    revision:                  5L06
    serial:                    3772512013_216045500
    WWN:                       
    detachable:                0
    can spindown:              0
    rotational media:          Yes, unknown rate
    write-cache:               unknown
    ejectable:                 1
    adapter:                   /org/freedesktop/UDisks/adapters/0000_3a00_3a11_2e0
    ports:
      /org/freedesktop/UDisks/adapters/0000_3a00_3a11_2e0/host2
    similar devices:
    media:                     optical_bd
      compat:                  optical_bd optical_bd_r optical_bd_re optical_cd optical_cd_r optical_cd_rw optical_dvd optical_dvd_plus_r optical_dvd_plus_r_dl optical_dvd_plus_rw optical_dvd_r optical_dvd_ram optical_dvd_rw
    interface:                 scsi
    if speed:                  (unknown)
    ATA SMART:                 not available

========================================================================

Offline

#84 2012-03-18 00:11:15

ninian
Member
From: United Kingdom
Registered: 2008-02-24
Posts: 694
Website

Re: ldm - Lightweight Device Mounter

TheLemonMan wrote:

@ninian

I could write a patch for you if you want, its just a matter of minutes smile

Thank you, if it really isn't a bother that would be good to have.

Offline

#85 2012-03-18 09:03:29

TheLemonMan
Member
From: Italy
Registered: 2011-09-04
Posts: 214
Website

Re: ldm - Lightweight Device Mounter

@skottish

Fixed in upstream branch big_smile

@ninian

Heres your patch, let me know if doesnt work

Offline

#86 2012-03-18 14:50:31

skottish
Forum Fellow
From: Here
Registered: 2006-06-16
Posts: 7,931

Re: ldm - Lightweight Device Mounter

Thanks a bunch! This solution is so much more elegant than anything that I've tried yet. I wish that I knew about this before the whole mess that I was using to get consolekit/udisks working properly. Much gratitude TheLemonMan.

Offline

#87 2012-03-18 16:53:01

ninian
Member
From: United Kingdom
Registered: 2008-02-24
Posts: 694
Website

Re: ldm - Lightweight Device Mounter

TheLemonMan wrote:

@ninian
Heres your patch, let me know if doesnt work

Thank you for the patch; I had to adjust the line numbers a little for the latest git version.
Unfortunately, the photo frame device still doesn't mount with the patch applied.
Maybe, it's trying to mount sdc, sdd, or sde instead of sdf?

Offline

#88 2012-03-18 19:56:58

TheLemonMan
Member
From: Italy
Registered: 2011-09-04
Posts: 214
Website

Re: ldm - Lightweight Device Mounter

ninian wrote:
TheLemonMan wrote:

@ninian
Heres your patch, let me know if doesnt work

Thank you for the patch; I had to adjust the line numbers a little for the latest git version.
Unfortunately, the photo frame device still doesn't mount with the patch applied.
Maybe, it's trying to mount sdc, sdd, or sde instead of sdf?

I just got an idea, what about creating a rule in fstab ? ldm discards detected settings if a fstab rule is present. (You still need the patch)

On a side note, can someone test this with a floppy drive ? I dont have one and I fear I might have broken floppy detection with this morning commit.

Offline

#89 2012-03-18 23:12:34

magicalChicken
Member
From: in the sky
Registered: 2012-03-03
Posts: 73
Website

Re: ldm - Lightweight Device Mounter

Just wanted to say that this is a very nice piece of software. I have been looking for something like this for a while, tried with autofs but had troubles. Can't believe that this has been out for yours without me knowing about it. Thanks.

Offline

#90 2012-03-20 12:01:09

Army
Member
Registered: 2007-12-07
Posts: 1,784

Re: ldm - Lightweight Device Mounter

TheLemonMan wrote:

@Army

Do what i said to ninian but using this patch and paste your /etc/mtab along with your /var/log/daemon.log

Thanks!

Sorry for the delay, but here are the requested informations:

/var/log/daemon.log

Mar 20 12:59:32 Archlinux [    1.990618] udevd[36]: starting version 181
Mar 20 12:59:32 Archlinux [   12.485641] udevd[176]: starting version 181
Mar 20 12:59:33 Archlinux acpid: starting up with netlink and the input layer
Mar 20 12:59:33 Archlinux acpid: 4 rules loaded
Mar 20 12:59:33 Archlinux acpid: waiting for events: event logging is off
Mar 20 12:59:33 Archlinux ldm: ldm 0.2
Mar 20 12:59:33 Archlinux ldm: Starting up...
Mar 20 12:59:33 Archlinux ldm: device->devnode : /dev/sda
Mar 20 12:59:33 Archlinux ldm: device->devnode : /dev/sda2
Mar 20 12:59:33 Archlinux ldm: Error while executing mount
Mar 20 12:59:33 Archlinux ldm: device->devnode : /dev/sda3
Mar 20 12:59:33 Archlinux ldm: Error while executing mount
Mar 20 12:59:33 Archlinux ldm: device->devnode : /dev/dm-0
Mar 20 12:59:33 Archlinux ldm: device->devnode : /dev/dm-1
Mar 20 12:59:33 Archlinux ldm: Entering the main loop
Mar 20 12:59:34 Archlinux /usr/sbin/irqbalance: WARNING: MSI interrupts found in /proc/interrupts
Mar 20 12:59:34 Archlinux /usr/sbin/irqbalance: But none found in sysfs, you need to update your kernel
Mar 20 12:59:34 Archlinux /usr/sbin/irqbalance: Until then, IRQs will be improperly classified
Mar 20 12:59:35 Archlinux netplugd[740]: /etc/netplug.d/netplug eth0 in -> pid 740
Mar 20 12:59:35 Archlinux mpdscribble: mpd error (5): Connection refused
Mar 20 12:59:35 Archlinux laptop-mode: Laptop mode 
Mar 20 12:59:35 Archlinux laptop-mode: enabled, not active
Mar 20 12:59:36 Archlinux mpdscribble: [last.fm] handshake error: got HTTP status 2 (Cannot resolve hostname (post.audioscrobbler.com))
Mar 20 12:59:36 Archlinux mpdscribble: [last.fm] waiting 60 seconds before trying again
Mar 20 12:59:36 Archlinux laptop-mode: Swapping out configuration files.
Mar 20 12:59:36 Archlinux laptop-mode: /etc/syslog-ng/syslog-ng.conf is not a symlink.
Mar 20 12:59:36 Archlinux laptop-mode: Saving it to /etc/syslog-ng/syslog-ng.conf.lmbackup.
Mar 20 12:59:36 Archlinux laptop-mode: Pointing config file /etc/syslog-ng/syslog-ng.conf to /etc/syslog-ng/syslog-ng.conf-nolm-ac.
Mar 20 12:59:37 Archlinux acpid: client connected from 823[0:100]
Mar 20 12:59:37 Archlinux acpid: 1 client rule loaded
Mar 20 12:59:40 Archlinux laptop-mode: Failed.
Mar 20 12:59:42 Archlinux netcfg: Profile eth/kelternweg on eth0 up - arping not found - succeeded
Mar 20 12:59:42 Archlinux netplugd[739]: eth0: state INNING pid 740 exited status 0
Mar 20 12:59:55 Archlinux ntpd[1308]: dispatch_imsg in main: pipe closed
Mar 20 12:59:55 Archlinux ntpd[1308]: Terminating
Mar 20 12:59:55 Archlinux netcfg: Profile eth/kelternweg on eth0 down - succeeded
Mar 20 12:59:55 Archlinux netplugd[739]: caught signal 15 - exiting
Mar 20 12:59:55 Archlinux netcfg: Interface eth0 down - succeeded
Mar 20 13:00:05 Archlinux dbus[613]: [system] Failed to activate service 'org.freedesktop.Avahi': timed out

/etc/mtab:

rootfs / rootfs rw 0 0
proc /proc proc rw,nosuid,nodev,noexec,relatime 0 0
sys /sys sysfs rw,nosuid,nodev,noexec,relatime 0 0
/dev /dev devtmpfs rw,nosuid,relatime,size=1820492k,nr_inodes=455123,mode=755 0 0
run /run tmpfs rw,nosuid,nodev,relatime,mode=755 0 0
/dev/mapper/root / xfs rw,relatime,attr2,delaylog,noquota 0 0
devpts /dev/pts devpts rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=000 0 0
shm /dev/shm tmpfs rw,nosuid,nodev,relatime 0 0
tmpfs /media tmpfs rw,relatime,size=4k 0 0
/dev/sda1 /boot ext2 rw,relatime,user_xattr,barrier=1 0 0
/dev/mapper/home /home xfs rw,relatime,attr2,delaylog,noquota 0 0
/dev/mapper/root /media/root xfs rw,relatime,attr2,delaylog,noquota 0 0
/dev/mapper/home /media/home xfs rw,relatime,attr2,delaylog,noquota 0 0

edit:

vfat (and probably ntfs as well, don't have a drive in range to test it) formatted external drives are mounted as read-only.

Here's what appears in the /var/log/daemon.log after pluggin in the drive

Mar 20 13:14:09 Archlinux ldm: device->devnode : /dev/sdb
Mar 20 13:14:09 Archlinux ldm: device->devnode : /dev/sdb1
% grep vfat /etc/mtab
/dev/sdb1 /media/16GB vfat ro,relatime,uid=1000,gid=100,fmask=0022,dmask=0022,codepage=cp437,iocharset=iso8859-1,shortname=mixed,errors=remount-ro 0 0
% cd /media/16GB
% touch test
touch: cannot touch `test': Read-only file system

How can I fix this?

Last edited by Army (2012-03-20 12:13:41)

Offline

#91 2012-03-20 14:51:36

TheLemonMan
Member
From: Italy
Registered: 2011-09-04
Posts: 214
Website

Re: ldm - Lightweight Device Mounter

About the drive being mounted as read only, by default ldm uses the standard mount options which include the "ro" flag, unless a fstab rule is set. So doublecheck your fstab.
I already have a fix for the lvm issue, i just need to test it, but please dont hold your breath tongue
Edit: Could you post your /proc/mounts too ?
On a side note, can you post the output of 'sudo fdisk -l' ? I see /dev/sda{2,3} failing in the log, dont know if its linked to the lvm problem or just a general bug. Anyway if you could test this patch and post your /var/log/daemon.log you'd help me a lot smile
Thanks again for the patience and for using ldm.

Last edited by TheLemonMan (2012-03-20 14:58:31)

Offline

#92 2012-03-20 15:43:05

Army
Member
Registered: 2007-12-07
Posts: 1,784

Re: ldm - Lightweight Device Mounter

Is it possible to configure the default mount options for EVERY drive in the fstab? I mean, if e.g. a friend comes over and wants me to put some stuff on his fat32-formatted usb stick, I don't want to be forced to make an entry in the fstab before it works. Doesn't look good and it's wrong especially if the friend is a girl wink
Btw, I don't use lvm, just encrypted partitions.

# cat /proc/mounts
rootfs / rootfs rw 0 0
proc /proc proc rw,nosuid,nodev,noexec,relatime 0 0
sys /sys sysfs rw,nosuid,nodev,noexec,relatime 0 0
/dev /dev devtmpfs rw,nosuid,relatime,size=1820492k,nr_inodes=455123,mode=755 0 0
run /run tmpfs rw,nosuid,nodev,relatime,mode=755 0 0
/dev/mapper/root / xfs rw,relatime,attr2,delaylog,noquota 0 0
devpts /dev/pts devpts rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=000 0 0
shm /dev/shm tmpfs rw,nosuid,nodev,relatime 0 0
tmpfs /media tmpfs rw,relatime,size=4k 0 0
/dev/sda1 /boot ext2 rw,relatime,user_xattr,barrier=1 0 0
/dev/mapper/home /home xfs rw,relatime,attr2,delaylog,noquota 0 0
/dev/mapper/root /media/root xfs rw,relatime,attr2,delaylog,noquota 0 0
/dev/mapper/home /media/home xfs rw,relatime,attr2,delaylog,noquota 0 0
# fdisk -l

Disk /dev/sda: 500.1 GB, 500107862016 bytes
255 heads, 63 sectors/track, 60801 cylinders, total 976773168 sectors
Units = sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disk identifier: 0x0004a1a6

   Device Boot      Start         End      Blocks   Id  System
/dev/sda1   *        2048       67583       32768   83  Linux
/dev/sda2           67584    14747647     7340032   83  Linux
/dev/sda3        14747648   976773167   481012760   83  Linux

Disk /dev/mapper/root: 7514 MB, 7514095616 bytes
255 heads, 63 sectors/track, 913 cylinders, total 14675968 sectors
Units = sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes

Disk /dev/mapper/root doesn't contain a valid partition table

Disk /dev/mapper/home: 492.6 GB, 492554969088 bytes
255 heads, 63 sectors/track, 59883 cylinders, total 962021424 sectors
Units = sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes

Disk /dev/mapper/home doesn't contain a valid partition table

That looks odd, something's not right...

I'll use the new patch and post the output here, brb.

edit: That was fast, the compilation doesn't run with this patch

patching file ldm.c
gcc ldm.c -g -ludev -o ldm
ldm.c: In function ‘device_mount’:
ldm.c:428:12: error: ‘SYS_DEBUG’ undeclared (first use in this function)
ldm.c:428:12: note: each undeclared identifier is reported only once for each function it appears in
make: *** [all] Error 1
==> ERROR: A failure occurred in build().
    Aborting..

Last edited by Army (2012-03-20 15:46:15)

Offline

#93 2012-03-20 19:38:08

TheLemonMan
Member
From: Italy
Registered: 2011-09-04
Posts: 214
Website

Re: ldm - Lightweight Device Mounter

Arr,I hate myself when i rush patches. Just change SYS_DEBUG to LOG_DEBUG.
Try posting the output of 'cat /sys/block/dm-0/dm/name', if it works then the lvm issue is settled without carrying in other dependencies.
Talking of the fstab problem, many users are using ldm with fat drives (myself included) and works, there might be something wrong in your system. Try mounting it by hand with 'mount -o default /dev/sdb1 /media/16GB' and see if its still mounted as read only (check in /etc/mtab).

Offline

#94 2012-05-17 20:20:16

shetland_breeder
Member
From: England
Registered: 2010-05-17
Posts: 57
Website

Re: ldm - Lightweight Device Mounter

LemonMan, I've come across this recently and I like it! Getting rid of all the udisks/udisks2/gvfs/gnome-*** stuff that otherwise seems to be necessary.

I have a question though, why do you strip everything from the first hyphen onwards from the disk label when creating the mountpoint?

This screws things up for me - I have three partitions that I use to multiboot different Arch setups named arch-root, arch-i386 and arch-test. The two that I'm not using (and don't mount in fstab) get mounted as arch on top of each other - not so clever. Of course I can change it in my own build but I wondered why you do it this way?

Pete

Offline

#95 2012-05-17 20:43:08

shetland_breeder
Member
From: England
Registered: 2010-05-17
Posts: 57
Website

Re: ldm - Lightweight Device Mounter

shetland_breeder wrote:

LemonMan, I've come across this recently and I like it! Getting rid of all the udisks/udisks2/gvfs/gnome-*** stuff that otherwise seems to be necessary.

I have a question though, why do you strip everything from the first hyphen onwards from the disk label when creating the mountpoint?

This screws things up for me - I have three partitions that I use to multiboot different Arch setups named arch-root, arch-i386 and arch-test. The two that I'm not using (and don't mount in fstab) get mounted as arch on top of each other - not so clever. Of course I can change it in my own build but I wondered why you do it this way?

Pete

RTFS! Of course you are doing it to truncate the mindlessly long UUIDs. Better to only do it for UUIDs and leave labels alone apart from changing spaces to hyphens? And ids need truncating differently too because the characters before the first hyphen in an id indicate the device type - all my USB memory sticks start usb- which could give multiple mounts at the same mountpoint.

Maybe the first eight characters for UUID and id_serial? 

Pete

Offline

#96 2012-05-18 13:42:11

TheLemonMan
Member
From: Italy
Registered: 2011-09-04
Posts: 214
Website

Re: ldm - Lightweight Device Mounter

That was a silly move indeed smile Now it doesnt truncate anything, if your mountpoint has an ugly name just set your drive label

Offline

#97 2012-05-18 21:01:49

Rolinh
Member
From: Switzerland
Registered: 2011-05-07
Posts: 144
Website

Re: ldm - Lightweight Device Mounter

Hi,

this project seems like a really good idea. smile
I cloned the git repository and I had a look at the source code and... I've seen quite a few things that should be fixed.
Briefly:
* prototypes like this one: int lock_remove() are not correct (you need to specify void if your function does not take any argument)
* unused variables here and there
* non-void function that does not return
* a variable declared in the middle of  function
* should use int main(void) for the main prototype as you do not make use of argc/argv

If you are interested by a patch, just say so and I will write and send you one. wink

Cheers

Offline

#98 2012-05-19 10:00:51

TheLemonMan
Member
From: Italy
Registered: 2011-09-04
Posts: 214
Website

Re: ldm - Lightweight Device Mounter

Feel free to fork the repository and send a pull request on github smile

Offline

#99 2012-05-19 10:56:42

Rolinh
Member
From: Switzerland
Registered: 2011-05-07
Posts: 144
Website

Re: ldm - Lightweight Device Mounter

All right, expect a pull request then. wink

Offline

#100 2012-05-19 11:16:57

theGunslinger
Member
Registered: 2011-05-20
Posts: 299

Re: ldm - Lightweight Device Mounter

LDM has made my life so much easier, thanks for the great work LemonMan.

Offline

Board footer

Powered by FluxBB