You are not logged in.

#1 2012-09-25 11:18:24

moere
Member
Registered: 2010-02-14
Posts: 29

Galapix in the AUR is broken

Hi there,

http://aur.archlinux.org/packages.php?ID=44181

I tried to install galapix from the AUR.

It didnt work.

g++ -o build/src/database/database.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/database/database.cpp
g++ -o build/src/database/file_database.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/database/file_database.cpp
g++ -o build/src/database/file_entry.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/database/file_entry.cpp
g++ -o build/src/database/file_id.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/database/file_id.cpp
g++ -o build/src/database/tile_cache.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/database/tile_cache.cpp
g++ -o build/src/database/tile_database.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/database/tile_database.cpp
g++ -o build/src/display/framebuffer.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/display/framebuffer.cpp
g++ -o build/src/display/surface.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/display/surface.cpp
g++ -o build/src/display/texture.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/display/texture.cpp
g++ -o build/src/galapix/database_thread.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/galapix/database_thread.cpp
g++ -o build/src/galapix/galapix.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/galapix/galapix.cpp
g++ -o build/src/galapix/image.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/galapix/image.cpp
g++ -o build/src/galapix/image_collection.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/galapix/image_collection.cpp
g++ -o build/src/galapix/image_renderer.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/galapix/image_renderer.cpp
g++ -o build/src/galapix/image_tile_cache.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/galapix/image_tile_cache.cpp
g++ -o build/src/galapix/random_layouter.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/galapix/random_layouter.cpp
g++ -o build/src/galapix/regular_layouter.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/galapix/regular_layouter.cpp
g++ -o build/src/galapix/selection.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/galapix/selection.cpp
g++ -o build/src/galapix/spiral_layouter.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/galapix/spiral_layouter.cpp
g++ -o build/src/galapix/tight_layouter.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/galapix/tight_layouter.cpp
g++ -o build/src/galapix/viewer.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/galapix/viewer.cpp
g++ -o build/src/galapix/viewer_state.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/galapix/viewer_state.cpp
g++ -o build/src/galapix/workspace.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/galapix/workspace.cpp
g++ -o build/src/galapix/zoomify_tile_provider.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/galapix/zoomify_tile_provider.cpp
g++ -o build/src/job/job_handle.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/job/job_handle.cpp
g++ -o build/src/job/job_manager.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/job/job_manager.cpp
g++ -o build/src/job/job_worker_thread.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/job/job_worker_thread.cpp
g++ -o build/src/job/thread.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/job/thread.cpp
g++ -o build/src/jobs/test_job.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/jobs/test_job.cpp
g++ -o build/src/jobs/tile_generation_job.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/jobs/tile_generation_job.cpp
g++ -o build/src/jobs/tile_generator.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/jobs/tile_generator.cpp
g++ -o build/src/sqlite/connection.o -c -O3 -s -isystem/usr/include/libpng15 -isystem/usr/include/SDL -isystem/usr/include/ImageMagick -D_GNU_SOURCE=1 -D_REENTRANT -Ibuild/src -Isrc src/sqlite/connection.cpp
src/sqlite/connection.cpp: In function 'int busy_callback(void*, int)':
src/sqlite/connection.cpp:28:17: error: 'usleep' was not declared in this scope
scons: *** [build/src/sqlite/connection.o] Error 1
scons: building terminated because of errors.

Could somebody fix this?

Or give me a hint, how I can fix it.

Greets,
moere

Offline

#2 2012-09-25 11:41:13

Trilby
Inspector Parrot
Registered: 2011-11-29
Posts: 29,442
Website

Re: Galapix in the AUR is broken

The error message should give all the hint needed.  usleep is defined in unistd.h, is that file included in connection.cpp?  If not add it.


"UNIX is simple and coherent..." - Dennis Ritchie, "GNU's Not UNIX" -  Richard Stallman

Offline

#3 2012-09-25 12:13:19

stefanwilkens
Member
From: Enschede, the Netherlands
Registered: 2008-12-10
Posts: 624

Re: Galapix in the AUR is broken

Looks like somebody forgot an include, this should be reported upstream (http://code.google.com/p/galapix/issues/list). No development since 2009 might be an indicator as to why this broke over time though big_smile

The fix is trivial, adding "#include <unistd.h>" to connection.hpp should fix this.

I expect you'll run into other similar issues after fixing this one though.

*edit*

oops, had this open while grabbing a drink and failed to refresh before posting.

Last edited by stefanwilkens (2012-09-25 12:14:14)


Arch i686 on Phenom X4 | GTX760

Offline

#4 2012-09-25 12:19:12

moere
Member
Registered: 2010-02-14
Posts: 29

Re: Galapix in the AUR is broken

Hm .. where do I find connection.cpp?

In the Galapix Source Code Tarball? (From their website)

Offline

#5 2012-09-25 12:23:26

Trilby
Inspector Parrot
Registered: 2011-11-29
Posts: 29,442
Website

Re: Galapix in the AUR is broken

Right where the error message tells you it is: src/galapix-0.1.2/src/sqlite/connection.cpp.

READ error messages.


"UNIX is simple and coherent..." - Dennis Ritchie, "GNU's Not UNIX" -  Richard Stallman

Offline

#6 2012-09-25 12:24:34

stefanwilkens
Member
From: Enschede, the Netherlands
Registered: 2008-12-10
Posts: 624

Re: Galapix in the AUR is broken

moere wrote:

Hm .. where do I find connection.cpp?

In the Galapix Source Code Tarball? (From their website)

This will be part of their source tarball, yes. Ideally, you should be making a patch and adding this to the PKGBUILD. (otherwise, makepkg will simply overwrite the sources and remove your changes).

*edit*

it happened again!

Last edited by stefanwilkens (2012-09-25 12:24:53)


Arch i686 on Phenom X4 | GTX760

Offline

#7 2012-09-25 12:38:07

moere
Member
Registered: 2010-02-14
Posts: 29

Re: Galapix in the AUR is broken

Alright .. so now I know where to start ... hm
yes I also saw that there was no development since 2009 ...
and I am not sure whether I want to try Galapix or not ..

Its features sound nice tough.

Offline

#8 2012-09-25 12:58:26

Trilby
Inspector Parrot
Registered: 2011-11-29
Posts: 29,442
Website

Re: Galapix in the AUR is broken

It looks like there is already a patch in the aur tarball.  Most of the entries in it seem to be for adding other missing header files.  The good news from this is that you can follow the template of what is already there, and just add one more patch to that patch file.  The bad news is that it really doesn't bode well for this program: unless I'm missing something that many missing includes suggests the developer(s) may not really have been in their best form when making this one.

In fairness, as the patch name has "gcc" in it, perhaps these are all headers that would be infered and included by some other compiler that the developers used and my assumption of their failure is hasty.

If you want you can try appending the following lines to the end of the existing patch file then rerun makepkg

diff -ruN galapix-0.1.2-orig/src/util/weak_functor.hpp galapix-0.1.2/src/util/weak_functor.hpp
--- galapix-0.1.2-orig/src/sqlite/connection.hpp	2009-10-25 02:26:51.000000000 +0200
+++ galapix-0.1.2/src/sqlite/connection.hpp	2012-08-25 08:01:14.000000000 +0100
@@ -20,4 +20,5 @@
 #define HEADER_GALAPIX_SQLITE_CONNECTION_HPP
 
 #include <sqlite3.h>
+#include <unistd.h>
 #include <string>

I'm far from a patch expert.  I'd usually use a sed line in the PKGBUILD, but as there is already a patch file it'd be better to keep all the changes in one place.
If this works, please contact the aur maintainer so they can add it to the AUR tarball.


"UNIX is simple and coherent..." - Dennis Ritchie, "GNU's Not UNIX" -  Richard Stallman

Offline

#9 2012-09-25 13:23:52

moere
Member
Registered: 2010-02-14
Posts: 29

Re: Galapix in the AUR is broken

Ok, I tried a bit ...

but I cant figure out where I can find
galapix-gcc44.patch

Offline

#10 2012-09-25 13:28:02

stefanwilkens
Member
From: Enschede, the Netherlands
Registered: 2008-12-10
Posts: 624

Re: Galapix in the AUR is broken

FYI, generally patches should only refer to one specific issue. Stacking changes in patches is usually a bad idea for multiple reasons.
- which patch holds what changes?
- patching order may be of importance

Not that is matters much in this case smile

Anyway, i did make a patch and built the app. It breaks on a similar issue with the ImageMagick stating 'Quantum' was undefined. This needs more love than my coffee break allows.


Arch i686 on Phenom X4 | GTX760

Offline

#11 2012-09-25 13:36:04

Trilby
Inspector Parrot
Registered: 2011-11-29
Posts: 29,442
Website

Re: Galapix in the AUR is broken

If everyone else jumped off a bridge, I guess I would to.  I happily defer to that advice about patches - as I really haven't used patches much, I just followed the trend already set in the current patch which does address many different issues.


"UNIX is simple and coherent..." - Dennis Ritchie, "GNU's Not UNIX" -  Richard Stallman

Offline

Board footer

Powered by FluxBB